Linux kernel -stable discussions
 help / color / mirror / Atom feed
* Re: Patch "vhost: vringh: use get_user()/put_user() for IOTLB 16-bit accesses" has been added to the 6.18-stable tree
       [not found] <20261117162917.1995578-1-sashal@kernel.org>
@ 2026-11-17 16:44 ` Linus Torvalds
  2026-11-18  0:19   ` Sasha Levin
  0 siblings, 1 reply; 3+ messages in thread
From: Linus Torvalds @ 2026-11-17 16:44 UTC (permalink / raw)
  To: stable; +Cc: stable-commits, Michael S. Tsirkin, Jason Wang,
	Eugenio Pérez

On Tue, 17 Nov 2026 at 08:29, Sasha Levin <sashal@kernel.org> wrote:
>
>     vhost: vringh: use get_user()/put_user() for IOTLB 16-bit accesses
>
>     [ Upstream commit 95a214f31a3b1ef40034f1e1cb3b9d758a374f01 ]
>
>     getu16_iotlb() and putu16_iotlb() use __get_user() and __put_user() when
>     the IOTLB maps to user virtual addresses.  Nothing nearby checks the
>     translated address: that relies on the mapping having been validated
>     against the user's VMAs when it was set up.
>
>     Use get_user() and put_user(), which do the same single, untorn access
>     and also check the address.  The only atomic-context use, the vdpa
>     simulators' notification check, now disables page faults around it, so
>     the might_fault() in the checked accessors stays quiet there.

Note that the "now disables page faults around it" is not true in
stable kernels unless you also take the previous commit:

  05fb07c40e00 ("vdpa_sim: disable page faults around
vringh_need_notify_iotlb()")

and I didn't see that being sent out, so it looks like you didn't (but
I didn't check your queues, I only looked at my own inbox, which is
the same disaster area it always is)

               Linus

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Patch "vhost: vringh: use get_user()/put_user() for IOTLB 16-bit accesses" has been added to the 6.18-stable tree
  2026-11-17 16:44 ` Patch "vhost: vringh: use get_user()/put_user() for IOTLB 16-bit accesses" has been added to the 6.18-stable tree Linus Torvalds
@ 2026-11-18  0:19   ` Sasha Levin
  2026-11-18  0:22     ` Sasha Levin
  0 siblings, 1 reply; 3+ messages in thread
From: Sasha Levin @ 2026-11-18  0:19 UTC (permalink / raw)
  To: stable
  Cc: Sasha Levin, stable-commits, Michael S. Tsirkin, Jason Wang,
	Eugenio Pérez, Linus Torvalds

> Note that the "now disables page faults around it" is not true in
> stable kernels unless you also take the previous commit:
>
>   05fb07c40e00 ("vdpa_sim: disable page faults around
> vringh_need_notify_iotlb()")

Thanks, queued that one for 7.3, 6.18, 6.12 and 6.6.

-- 
Thanks,
Sasha

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Patch "vhost: vringh: use get_user()/put_user() for IOTLB 16-bit accesses" has been added to the 6.18-stable tree
  2026-11-18  0:19   ` Sasha Levin
@ 2026-11-18  0:22     ` Sasha Levin
  0 siblings, 0 replies; 3+ messages in thread
From: Sasha Levin @ 2026-11-18  0:22 UTC (permalink / raw)
  To: stable
  Cc: stable-commits, Michael S. Tsirkin, Jason Wang,
	Eugenio Pérez, Linus Torvalds

> Note that the "now disables page faults around it" is not true in
> stable kernels unless you also take the previous commit:
>
>   05fb07c40e00 ("vdpa_sim: disable page faults around
> vringh_need_notify_iotlb()")

Thanks, queued that one for 7.3, 6.18, 6.12 and 6.6.

-- 
Thanks,
Sasha

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-18  0:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20261117162917.1995578-1-sashal@kernel.org>
2026-11-17 16:44 ` Patch "vhost: vringh: use get_user()/put_user() for IOTLB 16-bit accesses" has been added to the 6.18-stable tree Linus Torvalds
2026-11-18  0:19   ` Sasha Levin
2026-11-18  0:22     ` Sasha Levin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox