* [PATCH 5.10.y] mt76: mt7615: Fix memory leak in mt7615_mcu_wtbl_sta_add()
@ 2026-11-18 5:32 Nobuhiro Iwamatsu
2026-11-19 16:08 ` Sasha Levin
0 siblings, 1 reply; 2+ messages in thread
From: Nobuhiro Iwamatsu @ 2026-11-18 5:32 UTC (permalink / raw)
To: stable; +Cc: gregkh, sashal, Zilin Guan, Felix Fietkau, Nobuhiro Iwamatsu
From: Zilin Guan <zilin@seu.edu.cn>
commit 53d1548612670aa8b5d89745116cc33d9d172863 upstream.
In mt7615_mcu_wtbl_sta_add(), an skb sskb is allocated. If the
subsequent call to mt76_connac_mcu_alloc_wtbl_req() fails, the function
returns an error without freeing sskb, leading to a memory leak.
Fix this by calling dev_kfree_skb() on sskb in the error handling path
to ensure it is properly released.
Fixes: 99c457d902cf9 ("mt76: mt7615: move mt7615_mcu_set_bmc to mt7615_mcu_ops")
Signed-off-by: Zilin Guan <zilin@seu.edu.cn>
Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
Link: https://patch.msgid.link/20251113062415.103611-1-zilin@seu.edu.cn
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Nobuhiro Iwamatsu (CIP) <nobuhiro.iwamatsu.x90@mail.toshiba>
---
drivers/net/wireless/mediatek/mt76/mt7615/mcu.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
index 62a971660da7..ff5a1edd8dfc 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
@@ -1379,8 +1379,10 @@ mt7615_mcu_wtbl_sta_add(struct mt7615_dev *dev, struct ieee80211_vif *vif,
wtbl_hdr = mt7615_mcu_alloc_wtbl_req(dev, msta, WTBL_RESET_AND_SET,
NULL, &wskb);
- if (IS_ERR(wtbl_hdr))
+ if (IS_ERR(wtbl_hdr)) {
+ dev_kfree_skb(sskb);
return PTR_ERR(wtbl_hdr);
+ }
if (enable) {
mt7615_mcu_wtbl_generic_tlv(wskb, vif, sta, NULL, wtbl_hdr);
--
2.55.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 5.10.y] mt76: mt7615: Fix memory leak in mt7615_mcu_wtbl_sta_add()
2026-11-18 5:32 [PATCH 5.10.y] mt76: mt7615: Fix memory leak in mt7615_mcu_wtbl_sta_add() Nobuhiro Iwamatsu
@ 2026-11-19 16:08 ` Sasha Levin
0 siblings, 0 replies; 2+ messages in thread
From: Sasha Levin @ 2026-11-19 16:08 UTC (permalink / raw)
To: stable; +Cc: Sasha Levin, gregkh, Zilin Guan, Felix Fietkau, Nobuhiro Iwamatsu
> commit 53d1548612670aa8b5d89745116cc33d9d172863 upstream.
Queued for 5.10, thanks.
--
Thanks,
Sasha
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-19 16:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18 5:32 [PATCH 5.10.y] mt76: mt7615: Fix memory leak in mt7615_mcu_wtbl_sta_add() Nobuhiro Iwamatsu
2026-11-19 16:08 ` Sasha Levin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox