* [PATCH] drm/i915/psr: Init variable to avoid early exit from et alignment loop
@ 2026-04-13 11:23 Jouni Högander
2026-04-13 12:38 ` Garg, Nemesa
2026-04-14 8:56 ` Andi Shyti
0 siblings, 2 replies; 4+ messages in thread
From: Jouni Högander @ 2026-04-13 11:23 UTC (permalink / raw)
To: intel-gfx, intel-xe; +Cc: Jouni Högander, stable
Uninitialized boolean variable may cause unwanted exit from et alignment
loop. Fix this by initializing it as false.
Fixes: 681e12440d8b ("drm/i915/psr: Repeat Selective Update area alignment")
Cc: <stable@vger.kernel.org> # v6.9+
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
drivers/gpu/drm/i915/display/intel_psr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index b4ca5843d098..63c19958a9e3 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -3002,7 +3002,7 @@ int intel_psr2_sel_fetch_update(struct intel_atomic_state *state,
return ret;
do {
- bool cursor_in_su_area;
+ bool cursor_in_su_area = false;
/*
* Adjust su area to cover cursor fully as necessary
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [PATCH] drm/i915/psr: Init variable to avoid early exit from et alignment loop
2026-04-13 11:23 [PATCH] drm/i915/psr: Init variable to avoid early exit from et alignment loop Jouni Högander
@ 2026-04-13 12:38 ` Garg, Nemesa
2026-04-14 8:56 ` Andi Shyti
1 sibling, 0 replies; 4+ messages in thread
From: Garg, Nemesa @ 2026-04-13 12:38 UTC (permalink / raw)
To: Hogander, Jouni, intel-gfx@lists.freedesktop.org,
intel-xe@lists.freedesktop.org
Cc: Hogander, Jouni, stable@vger.kernel.org
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Jouni
> Högander
> Sent: Monday, April 13, 2026 4:54 PM
> To: intel-gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org
> Cc: Hogander, Jouni <jouni.hogander@intel.com>; stable@vger.kernel.org
> Subject: [PATCH] drm/i915/psr: Init variable to avoid early exit from et
> alignment loop
>
> Uninitialized boolean variable may cause unwanted exit from et alignment
> loop. Fix this by initializing it as false.
>
> Fixes: 681e12440d8b ("drm/i915/psr: Repeat Selective Update area
> alignment")
> Cc: <stable@vger.kernel.org> # v6.9+
> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_psr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> b/drivers/gpu/drm/i915/display/intel_psr.c
> index b4ca5843d098..63c19958a9e3 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -3002,7 +3002,7 @@ int intel_psr2_sel_fetch_update(struct
> intel_atomic_state *state,
> return ret;
>
> do {
> - bool cursor_in_su_area;
> + bool cursor_in_su_area = false;
>
LGTM,
Reviewed-by: Nemesa Garg <nemesa.garg@intel.com>
> /*
> * Adjust su area to cover cursor fully as necessary
> --
> 2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915/psr: Init variable to avoid early exit from et alignment loop
2026-04-13 11:23 [PATCH] drm/i915/psr: Init variable to avoid early exit from et alignment loop Jouni Högander
2026-04-13 12:38 ` Garg, Nemesa
@ 2026-04-14 8:56 ` Andi Shyti
2026-04-15 7:02 ` Hogander, Jouni
1 sibling, 1 reply; 4+ messages in thread
From: Andi Shyti @ 2026-04-14 8:56 UTC (permalink / raw)
To: Jouni Högander; +Cc: intel-gfx, intel-xe, stable, Dan Carpenter
Hi Jouni,
On Mon, Apr 13, 2026 at 02:23:45PM +0300, Jouni Högander wrote:
> Uninitialized boolean variable may cause unwanted exit from et alignment
> loop. Fix this by initializing it as false.
>
> Fixes: 681e12440d8b ("drm/i915/psr: Repeat Selective Update area alignment")
> Cc: <stable@vger.kernel.org> # v6.9+
> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Thanks,
Andi
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915/psr: Init variable to avoid early exit from et alignment loop
2026-04-14 8:56 ` Andi Shyti
@ 2026-04-15 7:02 ` Hogander, Jouni
0 siblings, 0 replies; 4+ messages in thread
From: Hogander, Jouni @ 2026-04-15 7:02 UTC (permalink / raw)
To: andi.shyti@linux.intel.com
Cc: intel-xe@lists.freedesktop.org, stable@vger.kernel.org,
Garg, Nemesa, intel-gfx@lists.freedesktop.org, error27@gmail.com
On Tue, 2026-04-14 at 10:56 +0200, Andi Shyti wrote:
> Hi Jouni,
>
> On Mon, Apr 13, 2026 at 02:23:45PM +0300, Jouni Högander wrote:
> > Uninitialized boolean variable may cause unwanted exit from et
> > alignment
> > loop. Fix this by initializing it as false.
> >
> > Fixes: 681e12440d8b ("drm/i915/psr: Repeat Selective Update area
> > alignment")
> > Cc: <stable@vger.kernel.org> # v6.9+
> > Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Thank you for reporting the issue Dan. Thank you Nemesa and Andi for
your reviews. This is now pushed to drm-intel-next.
BR,
Jouni Högander
>
> Thanks,
> Andi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-04-15 7:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-13 11:23 [PATCH] drm/i915/psr: Init variable to avoid early exit from et alignment loop Jouni Högander
2026-04-13 12:38 ` Garg, Nemesa
2026-04-14 8:56 ` Andi Shyti
2026-04-15 7:02 ` Hogander, Jouni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox