* [for 5.10.y] Please revert "8af1c121b0102 riscv: Sparse-Memory/vmemmap out-of-bounds fix"
@ 2026-03-18 2:03 nobuhiro.iwamatsu.x90
2026-04-23 12:01 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: nobuhiro.iwamatsu.x90 @ 2026-03-18 2:03 UTC (permalink / raw)
To: gregkh, sashal; +Cc: stable, cip-dev, pavel, chris.paterson2
Hi Greg and Sasha,
Please revert "8af1c121b0102 riscv: Sparse-Memory/vmemmap out-of-bounds fix" in Linux-5.10.y branch.
Since `phys_ram_base` is not defined in riscv, a build error will occur if `CONFIG_SPARSEMEM_MANUAL=y`.
```
[...]
from arch/riscv/kernel/soc.c:7:
./arch/riscv/include/asm/pgtable-64.h: In function ‘pud_page’:
./arch/riscv/include/asm/pgtable.h:47:58: error: ‘phys_ram_base’ undeclared (first use in this function)
47 | #define vmemmap ((struct page *)VMEMMAP_START - (phys_ram_base >> PAGE_SHIFT))
| ^~~~~~~~~~~~~
./include/asm-generic/memory_model.h:54:34: note: in expansion of macro ‘vmemmap’
54 | #define __pfn_to_page(pfn) (vmemmap + (pfn))
| ^~~~~~~
./include/asm-generic/memory_model.h:82:21: note: in expansion of macro ‘__pfn_to_page’
82 | #define pfn_to_page __pfn_to_page
| ^~~~~~~~~~~~~
./arch/riscv/include/asm/pgtable-64.h:70:16: note: in expansion of macro ‘pfn_to_page’
70 | return pfn_to_page(pud_val(pud) >> _PAGE_PFN_SHIFT);
| ^~~~~~~~~~~
./arch/riscv/include/asm/pgtable.h:47:58: note: each undeclared identifier is reported only once for each function it appears in
47 | #define vmemmap ((struct page *)VMEMMAP_START - (phys_ram_base >> PAGE_SHIFT))
| ^~~~~~~~~~~~~
./include/asm-generic/memory_model.h:54:34: note: in expansion of macro ‘vmemmap’
54 | #define __pfn_to_page(pfn) (vmemmap + (pfn))
| ^~~~~~~
./include/asm-generic/memory_model.h:82:21: note: in expansion of macro ‘__pfn_to_page’
82 | #define pfn_to_page __pfn_to_page
| ^~~~~~~~~~~~~
./arch/riscv/include/asm/pgtable-64.h:70:16: note: in expansion of macro ‘pfn_to_page’
70 | return pfn_to_page(pud_val(pud) >> _PAGE_PFN_SHIFT);
| ^~~~~~~~~~~
AS arch/riscv/kernel/vdso/flush_icache.o
./arch/riscv/include/asm/pgtable.h: In function ‘pmd_page’:
./arch/riscv/include/asm/pgtable.h:47:58: error: ‘phys_ram_base’ undeclared (first use in this function)
47 | #define vmemmap ((struct page *)VMEMMAP_START - (phys_ram_base >> PAGE_SHIFT))
| ^~~~~~~~~~~~~
./include/asm-generic/memory_model.h:54:34: note: in expansion of macro ‘vmemmap’
54 | #define __pfn_to_page(pfn) (vmemmap + (pfn))
| ^~~~~~~
./include/asm-generic/memory_model.h:82:21: note: in expansion of macro ‘__pfn_to_page’
82 | #define pfn_to_page __pfn_to_page
| ^~~~~~~~~~~~~
./arch/riscv/include/asm/pgtable.h:181:16: note: in expansion of macro ‘pfn_to_page’
181 | return pfn_to_page(pmd_val(pmd) >> _PAGE_PFN_SHIFT);
| ^~~~~~~~~~~ ^~~~~~~~~~~~~
[...]
```
Best regards,
Nobuhiro
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [for 5.10.y] Please revert "8af1c121b0102 riscv: Sparse-Memory/vmemmap out-of-bounds fix"
2026-03-18 2:03 [for 5.10.y] Please revert "8af1c121b0102 riscv: Sparse-Memory/vmemmap out-of-bounds fix" nobuhiro.iwamatsu.x90
@ 2026-04-23 12:01 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2026-04-23 12:01 UTC (permalink / raw)
To: nobuhiro.iwamatsu.x90; +Cc: sashal, stable, cip-dev, pavel, chris.paterson2
On Wed, Mar 18, 2026 at 02:03:44AM +0000, nobuhiro.iwamatsu.x90@mail.toshiba wrote:
> Hi Greg and Sasha,
>
> Please revert "8af1c121b0102 riscv: Sparse-Memory/vmemmap out-of-bounds fix" in Linux-5.10.y branch.
> Since `phys_ram_base` is not defined in riscv, a build error will occur if `CONFIG_SPARSEMEM_MANUAL=y`.
Can you send a revert with this information in it?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-23 12:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-18 2:03 [for 5.10.y] Please revert "8af1c121b0102 riscv: Sparse-Memory/vmemmap out-of-bounds fix" nobuhiro.iwamatsu.x90
2026-04-23 12:01 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox