[PATCH] bus: arm-cci: fix of_node_put() leak in __cci_ace_get_port()

[PATCH] bus: arm-cci: fix of_node_put() leak in __cci_ace_get_port()

[Ashutosh Desai]

of_parse_phandle() hands back a node with its refcount bumped.
__cci_ace_get_port() uses it only for a pointer comparison against
ports[], then both return paths walk away without ever calling
of_node_put(), leaking the reference each time.

Add the missing of_node_put() on both return paths.

Fixes: ed69bdd8fd9b ("drivers: bus: add ARM CCI support")
Cc: stable@vger.kernel.org
Signed-off-by: Ashutosh Desai <ashutoshdesai993@gmail.com>
---
 drivers/bus/arm-cci.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
index 7f2baf057128..223b1fe19ba0 100644
--- a/drivers/bus/arm-cci.c
+++ b/drivers/bus/arm-cci.c
@@ -167,9 +167,12 @@ static int __cci_ace_get_port(struct device_node *dn, int type)
 	cci_portn = of_parse_phandle(dn, "cci-control-port", 0);
 	for (i = 0; i < nb_cci_ports; i++) {
 		ace_match = ports[i].type == type;
-		if (ace_match && cci_portn == ports[i].dn)
+		if (ace_match && cci_portn == ports[i].dn) {
+			of_node_put(cci_portn);
 			return i;
+		}
 	}
+	of_node_put(cci_portn);
 	return -ENODEV;
 }
 
-- 
2.34.1

Re: [PATCH] bus: arm-cci: fix of_node_put() leak in __cci_ace_get_port()

[Ashutosh Desai]

Hi Lorenzo, Nicolas,

Just a gentle ping on this patch from a few weeks ago - no rush at all,
I know you're busy.

https://lore.kernel.org/linux-kernel/20260417024545.141289-1-ashutoshdesai993@gmail.com/

Happy to revise anything if needed. Thanks for your time!

Ashutosh