Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Shreenidhi Shedi <yesshedi@gmail.com>
To: gregkh@linuxfoundation.org, acme@kernel.org, linux@treblig.org,
	mikhail.v.gavrilov@gmail.com
Cc: yesshedi@gmail.com, stable@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Ian Rogers <irogers@google.com>
Subject: [PATCH 6.1.y v2 05/18] perf trace: Deal with compiler const checks
Date: Mon, 11 May 2026 12:40:38 +0530	[thread overview]
Message-ID: <20260511071051.537859-6-yesshedi@gmail.com> (raw)
In-Reply-To: <20260511071051.537859-1-yesshedi@gmail.com>

From: Arnaldo Carvalho de Melo <acme@redhat.com>

commit 2c850606a46b319d5128bda59f67b1fc642d94ef upstream

The strchr() function these days return const/non-const based on the arg
it receives, and sometimes we need to use casts when we're dealing with
variables that are used in code that needs to safely change the returned
value and sometimes not (as it points to really const areas).

Tweak one such case.

Reviewed-by: Ian Rogers <irogers@google.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
---
 tools/perf/builtin-trace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index 441655e659c2..313eb0929324 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -4622,7 +4622,7 @@ static int trace__parse_events_option(const struct option *opt, const char *str,
 	}
 
 	while (1) {
-		if ((sep = strchr(s, ',')) != NULL)
+		if ((sep = strchr((char *)s, ',')) != NULL)
 			*sep = '\0';
 
 		list = 0;
-- 
2.54.0


  parent reply	other threads:[~2026-05-11  7:37 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11  7:10 [PATCH 6.1.y v2 00/18] Backport fixes for -Wdiscarded-qualifiers and -Wnonnull with newer glibc Shreenidhi Shedi
2026-05-11  7:10 ` [PATCH 6.1.y v2 01/18] libbpf: Fix -Wdiscarded-qualifiers under C23 Shreenidhi Shedi
2026-05-11  7:10 ` [PATCH 6.1.y v2 02/18] perf diff: Constify strchr() return variables Shreenidhi Shedi
2026-05-11  7:10 ` [PATCH 6.1.y v2 03/18] perf test bpf: Address error about non-null argument for epoll_pwait 2nd arg Shreenidhi Shedi
2026-05-11  7:10 ` [PATCH 6.1.y v2 04/18] perf list: Fix -Wdiscarded-qualifiers under C23 Shreenidhi Shedi
2026-05-11  7:10 ` Shreenidhi Shedi [this message]
2026-05-11  7:10 ` [PATCH 6.1.y v2 06/18] perf tools: Use const for variables receiving str{str,r?chr}() returns Shreenidhi Shedi
2026-05-11  7:10 ` [PATCH 6.1.y v2 07/18] perf parse-events: Fix -Wdiscarded-qualifiers under C23 Shreenidhi Shedi
2026-05-11  7:10 ` [PATCH 6.1.y v2 08/18] perf tools: Remove unused color_fwrite_lines Shreenidhi Shedi
2026-05-11  7:10 ` [PATCH 6.1.y v2 09/18] perf strlist: Don't write to const memory Shreenidhi Shedi
2026-05-11  7:10 ` [PATCH 6.1.y v2 10/18] perf metricgroup: Constify variables storing the result of strchr() on const tables Shreenidhi Shedi
2026-05-11  7:10 ` [PATCH 6.1.y v2 11/18] perf session: Don't write to memory pointed to a const pointer Shreenidhi Shedi
2026-05-11  7:10 ` [PATCH 6.1.y v2 12/18] perf trace-event: Constify variables storing the result of strchr() on const tables Shreenidhi Shedi
2026-05-11  7:10 ` [PATCH 6.1.y v2 13/18] perf units: " Shreenidhi Shedi
2026-05-11  7:10 ` [PATCH 6.1.y v2 14/18] perf bpf: Fix -Wdiscarded-qualifiers under C23 Shreenidhi Shedi
2026-05-11  7:10 ` [PATCH 6.1.y v2 15/18] perf time-utils: Constify variables storing the result of strchr() on const tables Shreenidhi Shedi
2026-05-11  7:10 ` [PATCH 6.1.y v2 16/18] perf demangle-java: " Shreenidhi Shedi
2026-05-11  7:10 ` [PATCH 6.1.y v2 17/18] perf parse-events:: Fix -Wdiscarded-qualifiers under C23 Shreenidhi Shedi
2026-05-11  7:10 ` [PATCH 6.1.y v2 18/18] perf bpf-event: Constify variables storing the result of strchr() on const tables Shreenidhi Shedi
2026-05-11  8:16 ` [PATCH 6.1.y v2 00/18] Backport fixes for -Wdiscarded-qualifiers and -Wnonnull with newer glibc Greg KH
2026-05-13  6:37   ` Shreenidhi Shedi
2026-05-13  7:21     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260511071051.537859-6-yesshedi@gmail.com \
    --to=yesshedi@gmail.com \
    --cc=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=irogers@google.com \
    --cc=linux@treblig.org \
    --cc=mikhail.v.gavrilov@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox