Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Sasha Levin <sashal@kernel.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Frank Binns <frank.binns@imgtec.com>,
	Matt Coster <matt.coster@imgtec.com>,
	Brajesh Gupta <brajesh.gupta@imgtec.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Alessio Belle <alessio.belle@imgtec.com>
Subject: Re: [PATCH 6.12.y] drm/imagination: Synchronize interrupts before suspending the GPU
Date: Sun, 24 May 2026 08:09:28 -0400	[thread overview]
Message-ID: <20260524-stable-item014-reply@kernel.org> (raw)
In-Reply-To: <20260522-sync-irqs-6-12-v1-1-b0ecc9675078@imgtec.com>

> commit 2d7f05cddf4c268cc36256a2476946041dbdd36d upstream.
>
> The runtime PM suspend callback doesn't know whether the IRQ handler is
> in progress on a different CPU core and doesn't wait for it to finish.
> [...]
> This version of the patch contains only the part of the upstream commit
> that applies to 6.12; the rest was a revert of code added in 6.16.

The diff itself is fine and the synchronize_irq() portion is exactly
what we want on 6.12.y. However, the backport drops several trailers
from the upstream commit that we'd like to preserve verbatim on
stable:

  - Reviewed-by: Matt Coster <matt.coster@imgtec.com>
  - Link: https://patch.msgid.link/... (the upstream Link: trailer)
  - Signed-off-by: Matthew Brost (the upstream maintainer SoB that
    landed the patch upstream)

The upstream Fixes: tag also lists two entries:

  Fixes: cc1aeedb98ad ("drm/imagination: Implement firmware ...")
  Fixes: 96822d38ff57 ("drm/imagination: Implement Rogue safety event IRQs")

Your backport keeps only the first. I agree the second Fixes: refers
to code that doesn't exist on 6.12, but please keep it in the commit
message anyway so the trailers match upstream verbatim; stable
convention is to preserve the upstream trailer block unchanged.

Could you send a v2 with the upstream trailers (Reviewed-by, Link,
SoB, both Fixes:) restored?

-- 
Thanks,
Sasha

  reply	other threads:[~2026-05-24 12:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-22 13:15 [PATCH 6.12.y] drm/imagination: Synchronize interrupts before suspending the GPU Alessio Belle
2026-05-24 12:09 ` Sasha Levin [this message]
2026-05-26  8:14   ` Alessio Belle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260524-stable-item014-reply@kernel.org \
    --to=sashal@kernel.org \
    --cc=airlied@gmail.com \
    --cc=alessio.belle@imgtec.com \
    --cc=brajesh.gupta@imgtec.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=frank.binns@imgtec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matt.coster@imgtec.com \
    --cc=mripard@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=stable@vger.kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox