* [PATCH 6.18.y, 6.12.y, 6.6.y] media: rc: ttusbir: fix inverted error logic
@ 2026-05-30 13:51 Jan Kiszka
2026-06-03 15:14 ` Sasha Levin
0 siblings, 1 reply; 2+ messages in thread
From: Jan Kiszka @ 2026-05-30 13:51 UTC (permalink / raw)
To: stable@vger.kernel.org; +Cc: Oliver Neukum, Hans Verkuil, sean
From: Oliver Neukum <oneukum@suse.com>
[ Upstream commit 646ebdd3105809d84ed04aa9e92e47e89cc44502 ]
We have to report ENOMEM if no buffer is allocated.
Typo dropped a "!". Restore it.
Fixes: 50acaad3d202 ("media: rc: ttusbir: respect DMA coherency rules")
Cc: stable@vger.kernel.org
Signed-off-by: Oliver Neukum <oneukum@suse.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
Unclear why this failed during auto-backport because it applied
perfectly to the affected stable kernels. Just 7.0.y truly fails because
it does not carry the buggy patch 50acaad3d202.
drivers/media/rc/ttusbir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/rc/ttusbir.c b/drivers/media/rc/ttusbir.c
index dde446a95eaa9..83d206c3795c9 100644
--- a/drivers/media/rc/ttusbir.c
+++ b/drivers/media/rc/ttusbir.c
@@ -191,7 +191,7 @@ static int ttusbir_probe(struct usb_interface *intf,
tt = kzalloc(sizeof(*tt), GFP_KERNEL);
buffer = kzalloc(5, GFP_KERNEL);
rc = rc_allocate_device(RC_DRIVER_IR_RAW);
- if (!tt || !rc || buffer) {
+ if (!tt || !rc || !buffer) {
ret = -ENOMEM;
goto out;
}
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 6.18.y, 6.12.y, 6.6.y] media: rc: ttusbir: fix inverted error logic
2026-05-30 13:51 [PATCH 6.18.y, 6.12.y, 6.6.y] media: rc: ttusbir: fix inverted error logic Jan Kiszka
@ 2026-06-03 15:14 ` Sasha Levin
0 siblings, 0 replies; 2+ messages in thread
From: Sasha Levin @ 2026-06-03 15:14 UTC (permalink / raw)
To: stable@vger.kernel.org
Cc: Sasha Levin, Oliver Neukum, Hans Verkuil, sean, Jan Kiszka
Queued for 6.6.y and 6.12.y, thanks.
--
Thanks,
Sasha
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-03 15:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-30 13:51 [PATCH 6.18.y, 6.12.y, 6.6.y] media: rc: ttusbir: fix inverted error logic Jan Kiszka
2026-06-03 15:14 ` Sasha Levin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).