Linux kernel -stable discussions
 help / color / mirror / Atom feed
* [PATCH 1/4] Docs/ABI/damon: fix typo in intervals_goal sysfs path
       [not found] <20260710044737.561102-1-husong@kylinos.cn>
@ 2026-07-10  4:47 ` Song Hu
  2026-07-10 14:17   ` SJ Park
  0 siblings, 1 reply; 4+ messages in thread
From: Song Hu @ 2026-07-10  4:47 UTC (permalink / raw)
  To: sj; +Cc: damon, linux-mm, linux-kernel, linux-doc, Song Hu, stable

The ABI document spells the DAMON sysfs directory as "intrvals_goal"
(missing 'e') in four What: entries, but the kernel creates it as
"intervals_goal" (mm/damon/sysfs.c).  Following the documented path
therefore yields a non-existent directory.

Fixes: e2b23dc62369 ("Docs/ABI/damon: document intervals auto-tuning ABI")
Cc: stable@vger.kernel.org
Signed-off-by: Song Hu <husong@kylinos.cn>
---
 Documentation/ABI/testing/sysfs-kernel-mm-damon | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-damon b/Documentation/ABI/testing/sysfs-kernel-mm-damon
index dd6b5bd76e11..885409a26786 100644
--- a/Documentation/ABI/testing/sysfs-kernel-mm-damon
+++ b/Documentation/ABI/testing/sysfs-kernel-mm-damon
@@ -112,7 +112,7 @@ Description:	Writing a value to this file sets the update interval of the
 		DAMON context in microseconds as the value.  Reading this file
 		returns the value.
 
-What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/monitoring_attrs/intervals/intrvals_goal/access_bp
+What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/monitoring_attrs/intervals/intervals_goal/access_bp
 Date:		Feb 2025
 Contact:	SJ Park <sj@kernel.org>
 Description:	Writing a value to this file sets the monitoring intervals
@@ -120,7 +120,7 @@ Description:	Writing a value to this file sets the monitoring intervals
 		the given time interval (aggrs in same directory), in bp
 		(1/10,000).  Reading this file returns the value.
 
-What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/monitoring_attrs/intervals/intrvals_goal/aggrs
+What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/monitoring_attrs/intervals/intervals_goal/aggrs
 Date:		Feb 2025
 Contact:	SJ Park <sj@kernel.org>
 Description:	Writing a value to this file sets the time interval to achieve
@@ -128,14 +128,14 @@ Description:	Writing a value to this file sets the time interval to achieve
 		access events ratio (access_bp in same directory) within.
 		Reading this file returns the value.
 
-What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/monitoring_attrs/intervals/intrvals_goal/min_sample_us
+What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/monitoring_attrs/intervals/intervals_goal/min_sample_us
 Date:		Feb 2025
 Contact:	SJ Park <sj@kernel.org>
 Description:	Writing a value to this file sets the minimum value of
 		auto-tuned sampling interval in microseconds.  Reading this
 		file returns the value.
 
-What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/monitoring_attrs/intervals/intrvals_goal/max_sample_us
+What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/monitoring_attrs/intervals/intervals_goal/max_sample_us
 Date:		Feb 2025
 Contact:	SJ Park <sj@kernel.org>
 Description:	Writing a value to this file sets the maximum value of
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/4] Docs/ABI/damon: fix typo in intervals_goal sysfs path
  2026-07-10  4:47 ` [PATCH 1/4] Docs/ABI/damon: fix typo in intervals_goal sysfs path Song Hu
@ 2026-07-10 14:17   ` SJ Park
  2026-07-11  0:21     ` SJ Park
  0 siblings, 1 reply; 4+ messages in thread
From: SJ Park @ 2026-07-10 14:17 UTC (permalink / raw)
  To: Song Hu; +Cc: SJ Park, damon, linux-mm, linux-kernel, linux-doc, stable

On Fri, 10 Jul 2026 12:47:34 +0800 Song Hu <husong@kylinos.cn> wrote:

> The ABI document spells the DAMON sysfs directory as "intrvals_goal"
> (missing 'e') in four What: entries, but the kernel creates it as
> "intervals_goal" (mm/damon/sysfs.c).  Following the documented path
> therefore yields a non-existent directory.

Nice catch!

> 
> Fixes: e2b23dc62369 ("Docs/ABI/damon: document intervals auto-tuning ABI")
> Cc: stable@vger.kernel.org
> Signed-off-by: Song Hu <husong@kylinos.cn>

Reviewed-by: SJ  Park <sj@kernel.org>


Thanks,
SJ

[...]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/4] Docs/ABI/damon: fix typo in intervals_goal sysfs path
  2026-07-10 14:17   ` SJ Park
@ 2026-07-11  0:21     ` SJ Park
  2026-07-11  5:04       ` Song Hu
  0 siblings, 1 reply; 4+ messages in thread
From: SJ Park @ 2026-07-11  0:21 UTC (permalink / raw)
  To: SJ Park; +Cc: Song Hu, damon, linux-mm, linux-kernel, linux-doc, stable

On Fri, 10 Jul 2026 07:17:37 -0700 SJ Park <sj@kernel.org> wrote:

> On Fri, 10 Jul 2026 12:47:34 +0800 Song Hu <husong@kylinos.cn> wrote:
> 
> > The ABI document spells the DAMON sysfs directory as "intrvals_goal"
> > (missing 'e') in four What: entries, but the kernel creates it as
> > "intervals_goal" (mm/damon/sysfs.c).  Following the documented path
> > therefore yields a non-existent directory.
> 
> Nice catch!
> 
> > 
> > Fixes: e2b23dc62369 ("Docs/ABI/damon: document intervals auto-tuning ABI")
> > Cc: stable@vger.kernel.org

By the way, hotfixes and non-hotfixes usually take different trains to the
mainline.  Having those in single series therefore makes maintainer works
difficult.  I understand this is not a hotfix but just somewhat worthy to
eventually be backported to stable kernels.  So no problem for this.

But, from the next time, please clarify or use different series for Cc: stable@
patches.


Thanks,
SJ

[...]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/4] Docs/ABI/damon: fix typo in intervals_goal sysfs path
  2026-07-11  0:21     ` SJ Park
@ 2026-07-11  5:04       ` Song Hu
  0 siblings, 0 replies; 4+ messages in thread
From: Song Hu @ 2026-07-11  5:04 UTC (permalink / raw)
  To: SJ Park; +Cc: damon, linux-mm, linux-kernel, linux-doc, stable



于 2026年7月11日 GMT+08:00 08:21:25,SJ Park <sj@kernel.org> 写道:
>On Fri, 10 Jul 2026 07:17:37 -0700 SJ Park <sj@kernel.org> wrote:
>
>> On Fri, 10 Jul 2026 12:47:34 +0800 Song Hu <husong@kylinos.cn> wrote:
>> 
>> > The ABI document spells the DAMON sysfs directory as "intrvals_goal"
>> > (missing 'e') in four What: entries, but the kernel creates it as
>> > "intervals_goal" (mm/damon/sysfs.c).  Following the documented path
>> > therefore yields a non-existent directory.
>> 
>> Nice catch!
>> 
>> > 
>> > Fixes: e2b23dc62369 ("Docs/ABI/damon: document intervals auto-tuning ABI")
>> > Cc: stable@vger.kernel.org
>
Hi SJ,

Thanks a lot for your thorough reviews and ongoing support.

I will strictly check the complete recipient list generated by  get_maintainer.pl  for all future patch submissions.

>By the way, hotfixes and non-hotfixes usually take different trains to the
>mainline.  Having those in single series therefore makes maintainer works
>difficult.  I understand this is not a hotfix but just somewhat worthy to
>eventually be backported to stable kernels.  So no problem for this.
>
>But, from the next time, please clarify or use different series for Cc: stable@
>patches.
>
As I’m still figuring out the correct timing for  Cc: stable@ , I will consult with you prior to adding this tag next time and separate stable-bound patches into an independent series.

Thanks,
Song
>
>Thanks,
>SJ
>
>[...]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-07-11  5:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20260710044737.561102-1-husong@kylinos.cn>
2026-07-10  4:47 ` [PATCH 1/4] Docs/ABI/damon: fix typo in intervals_goal sysfs path Song Hu
2026-07-10 14:17   ` SJ Park
2026-07-11  0:21     ` SJ Park
2026-07-11  5:04       ` Song Hu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox