Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org, gregkh@linuxfoundation.org
Cc: Sasha Levin <sashal@kernel.org>,
	alifm@linux.ibm.com, Matthew Rosato <mjrosato@linux.ibm.com>
Subject: Re: [PATCH v2 stable 6.12 0/3] s390 KVM PCI backports for 6.12
Date: Tue, 11 Aug 2026 14:55:53 -0400	[thread overview]
Message-ID: <20260811184500.stable-0008-sashal@kernel.org> (raw)
In-Reply-To: <20260810182128.5458-1-alifm@linux.ibm.com>

> This patchset backports the failed commits to stable-6.12. I have resolved
> the merge conflicts and tested them on s390.

Thanks for the respin - this one does apply, and 3/3 now falls through
into free_aisb: the way mainline does, so both of my objections to v1
are addressed.

One thing left in 1/3: the conflict resolution keeps 6.12's existing
in-loop

	cur_pages = atomic_long_read(&user->locked_vm);

in account_mem() as well as adding the pre-loop read. It is harmless,
but it is the only line where 6.12 would then differ from mainline and
from 6.18/7.1. Could you drop the in-loop read and resend? The same
artifact is in the 6.6 and 6.1 submissions.

While you are respinning: 0cfe660559e8 ("KVM: s390: pci: Fix aisb
calculation") is missing from 6.18, 6.12, 6.6 and 6.1 - only 7.1 has it.
kvm_zpci_set_airq() on these trees still computes the AISB address as
aift->sbv->vector + (zdev->aisb / 64) * 8, which goes out of bounds past
64 forwarded devices. Could you or Matthew include it in the resend?

-- 
Thanks,
Sasha

  parent reply	other threads:[~2026-08-11 18:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-10 18:21 [PATCH v2 stable 6.12 0/3] s390 KVM PCI backports for 6.12 Farhan Ali
2026-08-10 18:21 ` [PATCH v2 1/3] KVM: s390: pci: Fix memory accounting for pinned/unpinned pages Farhan Ali
2026-08-10 18:21 ` [PATCH v2 2/3] KVM: s390: pci: Fix missing error codes and memory unaccounting Farhan Ali
2026-08-10 18:21 ` [PATCH v2 3/3] KVM: s390: pci: Fix resource leak on IRQ registration failure Farhan Ali
2026-08-11 18:55 ` Sasha Levin [this message]
2026-08-11 18:59   ` [PATCH v2 stable 6.12 0/3] s390 KVM PCI backports for 6.12 Farhan Ali
2026-08-12 16:26     ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260811184500.stable-0008-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=alifm@linux.ibm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=mjrosato@linux.ibm.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox