* [PATCH 5.10.y 2/4] i2c: Convert to platform remove callback returning void
2026-09-11 0:15 ` [PATCH 5.10.y 1/4] i2c: omap: Improve error reporting for problems during .remove() Sasha Levin
@ 2026-09-11 0:15 ` Sasha Levin
2026-09-11 0:15 ` [PATCH 5.10.y 3/4] i2c: qcom-cci: Do not check return value of cci_init() Sasha Levin
2026-09-11 0:15 ` [PATCH 5.10.y 4/4] i2c: qcom-cci: fix autosuspend cleanup Sasha Levin
2 siblings, 0 replies; 5+ messages in thread
From: Sasha Levin @ 2026-09-11 0:15 UTC (permalink / raw)
To: stable
Cc: Uwe Kleine-König, Alain Volmat, Ard Biesheuvel, Baruch Siach,
Florian Fainelli, Heiko Stuebner, Jarkko Nikula, Jernej Skrabec,
Jochen Friedrich, Peter Rosin, Vadim Pasternak, Asmaa Mnebhi,
Bartosz Golaszewski, Chris Packham, Chris Pringle, Claudiu Beznea,
Conor Dooley, Geert Uytterhoeven, Hans de Goede, Jean Delvare,
Konrad Dybcio, Krzysztof Kozlowski, Linus Walleij,
Martin Blumenstingl, Matthias Brugger, Patrice Chotard,
Tali Perry, Vignesh Raghavendra, Wolfram Sang, Sasha Levin
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
[ Upstream commit e190a0c389e60178fba3d532abf936dcae223e7d ]
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Alain Volmat <alain.volmat@foss.st.com>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
Acked-by: Baruch Siach <baruch@tkos.co.il>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Heiko Stuebner <heiko@sntech.de>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Acked-by: Jochen Friedrich <jochen@scram.de>
Acked-by: Peter Rosin <peda@axentia.se>
Acked-by: Vadim Pasternak <vadimp@nvidia.com>
Reviewed-by: Asmaa Mnebhi <asnaa@nvidia.com>
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Reviewed-by: Chris Pringle <chris.pringle@phabrix.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Reviewed-by: Tali Perry <tali.perry@nuvoton.com>
Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Stable dependency adaptation for 5.10:
Limit the driver conversion to Qualcomm CCI, the only driver touched by
f98d49864821. Drop the other 87 driver conversions, including drivers
absent from this branch and drivers that still use ACPI or I2C callbacks.
This branch lacks platform_driver.remove_new. Include the minimal support
from 5c5a7680e67b ("platform: Provide a remove callback that returns no
value"): add the callback member and dispatch it in the existing
platform_drv_remove(), preserving the legacy int-returning remove path.
Also adapt the CCI IRQ cleanup from f0285c286bca ("i2c: qcom-cci: Remove
overcautious disable_irq() calls"). The IRQ is already devres-managed;
remove its explicit disable calls and route both reset and initialization
failures to clock cleanup. Retain the 5.10-specific cci_init() call. This
provides the probe and remove context required for the target to apply
without conflicts. The managed runtime-PM helper used by the target is
already available in this branch.
No functions are added. The autosuspend fix remains in the target commit.
[ sashal: Reduced backport -- upstream e190a0c389e60 touches 88 file(s), this
backport carries 3. Not backported here:
drivers/i2c/busses/i2c-altera.c
drivers/i2c/busses/i2c-amd-mp2-plat.c
drivers/i2c/busses/i2c-aspeed.c
drivers/i2c/busses/i2c-at91-core.c
drivers/i2c/busses/i2c-au1550.c
drivers/i2c/busses/i2c-axxia.c
drivers/i2c/busses/i2c-bcm2835.c
drivers/i2c/busses/i2c-bcm-iproc.c
... and 79 more
This note is generated from the file lists only; see the resolution record
for the reasoning. ]
Stable-dep-of: f98d49864821 ("i2c: qcom-cci: fix autosuspend cleanup")
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/base/platform.c | 4 +++-
drivers/i2c/busses/i2c-qcom-cci.c | 13 ++++---------
include/linux/platform_device.h | 2 ++
3 files changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/base/platform.c b/drivers/base/platform.c
index 647066229fec3..94a4c8184cc91 100644
--- a/drivers/base/platform.c
+++ b/drivers/base/platform.c
@@ -783,7 +783,9 @@ static int platform_drv_remove(struct device *_dev)
struct platform_device *dev = to_platform_device(_dev);
int ret = 0;
- if (drv->remove)
+ if (drv->remove_new)
+ drv->remove_new(dev);
+ else if (drv->remove)
ret = drv->remove(dev);
dev_pm_domain_detach(_dev, true);
diff --git a/drivers/i2c/busses/i2c-qcom-cci.c b/drivers/i2c/busses/i2c-qcom-cci.c
index 7e3e1514416d8..c13cc1509b166 100644
--- a/drivers/i2c/busses/i2c-qcom-cci.c
+++ b/drivers/i2c/busses/i2c-qcom-cci.c
@@ -632,11 +632,11 @@ static int cci_probe(struct platform_device *pdev)
ret = cci_reset(cci);
if (ret < 0)
- goto error;
+ goto disable_clocks;
ret = cci_init(cci);
if (ret < 0)
- goto error;
+ goto disable_clocks;
pm_runtime_set_autosuspend_delay(dev, MSEC_PER_SEC);
pm_runtime_use_autosuspend(dev);
@@ -666,15 +666,13 @@ static int cci_probe(struct platform_device *pdev)
of_node_put(cci->master[i].adap.dev.of_node);
}
}
-error:
- disable_irq(cci->irq);
disable_clocks:
cci_disable_clocks(cci);
return ret;
}
-static int cci_remove(struct platform_device *pdev)
+static void cci_remove(struct platform_device *pdev)
{
struct cci *cci = platform_get_drvdata(pdev);
int i;
@@ -687,11 +685,8 @@ static int cci_remove(struct platform_device *pdev)
}
}
- disable_irq(cci->irq);
pm_runtime_disable(&pdev->dev);
pm_runtime_set_suspended(&pdev->dev);
-
- return 0;
}
static const struct cci_data cci_v1_data = {
@@ -784,7 +779,7 @@ MODULE_DEVICE_TABLE(of, cci_dt_match);
static struct platform_driver qcom_cci_driver = {
.probe = cci_probe,
- .remove = cci_remove,
+ .remove_new = cci_remove,
.driver = {
.name = "i2c-qcom-cci",
.of_match_table = cci_dt_match,
diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h
index e7a83b0218077..37b5161d61fcf 100644
--- a/include/linux/platform_device.h
+++ b/include/linux/platform_device.h
@@ -203,7 +203,9 @@ extern void platform_device_put(struct platform_device *pdev);
struct platform_driver {
int (*probe)(struct platform_device *);
+ /* Use remove_new for callbacks that return no value. */
int (*remove)(struct platform_device *);
+ void (*remove_new)(struct platform_device *);
void (*shutdown)(struct platform_device *);
int (*suspend)(struct platform_device *, pm_message_t state);
int (*resume)(struct platform_device *);
--
2.53.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 5.10.y 3/4] i2c: qcom-cci: Do not check return value of cci_init()
2026-09-11 0:15 ` [PATCH 5.10.y 1/4] i2c: omap: Improve error reporting for problems during .remove() Sasha Levin
2026-09-11 0:15 ` [PATCH 5.10.y 2/4] i2c: Convert to platform remove callback returning void Sasha Levin
@ 2026-09-11 0:15 ` Sasha Levin
2026-09-11 0:15 ` [PATCH 5.10.y 4/4] i2c: qcom-cci: fix autosuspend cleanup Sasha Levin
2 siblings, 0 replies; 5+ messages in thread
From: Sasha Levin @ 2026-09-11 0:15 UTC (permalink / raw)
To: stable
Cc: Vladimir Zapolskiy, Loic Poulain, Konrad Dybcio, Andi Shyti,
Sasha Levin
From: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
[ Upstream commit 17c5d247e3e4708cac05ff087c8013c0dda383a2 ]
The cci_init() function is not supposed to fail, and it never returns
a non-zero, so it'd make sense to convert its signature to void.
Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Reviewed-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/20260515234121.1607425-3-vladimir.zapolskiy@linaro.org
Stable dependency adaptation for 5.10:
Resolve the probe conflict against the earlier dependency's IRQ cleanup,
which renamed the failure destination from error to disable_clocks.
cci_init() only writes registers and always returned zero in this tree,
so retain the void conversion and replace its checked probe call with
an unconditional call. Keep the real cci_reset() failure path unchanged.
Retain the separate cci_init() calls in probe, queue timeout recovery,
and runtime resume because this branch does not have the later upstream
refactor moving initialization into cci_reset(). No functions are added.
The target f98d49864821 applies cleanly with Git's three-way merge;
its runtime PM cleanup changes remain in the target.
Stable-dep-of: f98d49864821 ("i2c: qcom-cci: fix autosuspend cleanup")
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/i2c/busses/i2c-qcom-cci.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/i2c/busses/i2c-qcom-cci.c b/drivers/i2c/busses/i2c-qcom-cci.c
index c13cc1509b166..e11aa8e495020 100644
--- a/drivers/i2c/busses/i2c-qcom-cci.c
+++ b/drivers/i2c/busses/i2c-qcom-cci.c
@@ -247,7 +247,7 @@ static int cci_reset(struct cci *cci)
return 0;
}
-static int cci_init(struct cci *cci)
+static void cci_init(struct cci *cci)
{
u32 val = CCI_IRQ_MASK_0_I2C_M0_RD_DONE |
CCI_IRQ_MASK_0_I2C_M0_Q0_REPORT |
@@ -288,8 +288,6 @@ static int cci_init(struct cci *cci)
val = hw->scl_stretch_en << 8 | hw->trdhld << 4 | hw->tsp;
writel(val, cci->base + CCI_I2C_Mm_MISC_CTL(i));
}
-
- return 0;
}
static int cci_run_queue(struct cci *cci, u8 master, u8 queue)
@@ -634,9 +632,7 @@ static int cci_probe(struct platform_device *pdev)
if (ret < 0)
goto disable_clocks;
- ret = cci_init(cci);
- if (ret < 0)
- goto disable_clocks;
+ cci_init(cci);
pm_runtime_set_autosuspend_delay(dev, MSEC_PER_SEC);
pm_runtime_use_autosuspend(dev);
--
2.53.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 5.10.y 4/4] i2c: qcom-cci: fix autosuspend cleanup
2026-09-11 0:15 ` [PATCH 5.10.y 1/4] i2c: omap: Improve error reporting for problems during .remove() Sasha Levin
2026-09-11 0:15 ` [PATCH 5.10.y 2/4] i2c: Convert to platform remove callback returning void Sasha Levin
2026-09-11 0:15 ` [PATCH 5.10.y 3/4] i2c: qcom-cci: Do not check return value of cci_init() Sasha Levin
@ 2026-09-11 0:15 ` Sasha Levin
2 siblings, 0 replies; 5+ messages in thread
From: Sasha Levin @ 2026-09-11 0:15 UTC (permalink / raw)
To: stable
Cc: Guangshuo Li, Vladimir Zapolskiy, Loic Poulain, Andi Shyti,
Sasha Levin
From: Guangshuo Li <lgs201920130244@gmail.com>
[ Upstream commit f98d4986482151a835b521a734722fe8dc5ca37d ]
cci_probe() calls pm_runtime_use_autosuspend(), but the remove path
does not call the matching pm_runtime_dont_use_autosuspend() before
disabling runtime PM.
If the autosuspend delay is set to a negative value while autosuspend
is enabled, the runtime PM core increments usage_count to prevent
runtime suspend. Without undoing the autosuspend setting during
teardown, this reference is not dropped and usage_count remains
unbalanced.
Use devm_pm_runtime_set_active_enabled() to manage the runtime PM
state. Its managed cleanup disables autosuspend and runtime PM and
restores the suspended state on probe failure and driver removal.
Remove the now redundant manual runtime PM cleanup.
This issue was found by manual code inspection.
Fixes: e517526195de ("i2c: Add Qualcomm CCI I2C driver")
Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
Cc: <stable@vger.kernel.org> # v5.8+
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Reviewed-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
Link: https://patch.msgid.link/20260812094425.3515179-1-lgs201920130244@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/i2c/busses/i2c-qcom-cci.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/i2c/busses/i2c-qcom-cci.c b/drivers/i2c/busses/i2c-qcom-cci.c
index e11aa8e495020..31d37deaa026f 100644
--- a/drivers/i2c/busses/i2c-qcom-cci.c
+++ b/drivers/i2c/busses/i2c-qcom-cci.c
@@ -635,9 +635,11 @@ static int cci_probe(struct platform_device *pdev)
cci_init(cci);
pm_runtime_set_autosuspend_delay(dev, MSEC_PER_SEC);
+ ret = devm_pm_runtime_set_active_enabled(dev);
+ if (ret)
+ goto disable_clocks;
+
pm_runtime_use_autosuspend(dev);
- pm_runtime_set_active(dev);
- pm_runtime_enable(dev);
for (i = 0; i < cci->data->num_masters; i++) {
if (!cci->master[i].cci)
@@ -653,8 +655,6 @@ static int cci_probe(struct platform_device *pdev)
return 0;
error_i2c:
- pm_runtime_disable(dev);
- pm_runtime_dont_use_autosuspend(dev);
for (--i ; i >= 0; i--) {
if (cci->master[i].cci) {
@@ -680,9 +680,6 @@ static void cci_remove(struct platform_device *pdev)
cci_halt(cci, i);
}
}
-
- pm_runtime_disable(&pdev->dev);
- pm_runtime_set_suspended(&pdev->dev);
}
static const struct cci_data cci_v1_data = {
--
2.53.0
^ permalink raw reply related [flat|nested] 5+ messages in thread