* [PATCH v2 3/4] arm64: dts: cix: fix I2C bus address and size cells on Sky1
[not found] <20261105111534.3290756-1-gary.yang@cixtech.com>
@ 2026-11-05 11:15 ` Gary Yang
0 siblings, 0 replies; only message in thread
From: Gary Yang @ 2026-11-05 11:15 UTC (permalink / raw)
To: Fugang Duan; +Cc: CIX Linux Kernel Upstream Group, Gary Yang, stable
The I2C controller nodes inherit #address-cells = <2> and #size-cells
= <2> from the soc@0 bus, but I2C child devices always use a
single-cell address and no size. With the inherited values every
child node triggers a reg_format warning, and a device described on
the bus would be decoded with the wrong address layout.
Set #address-cells = <1> and #size-cells = <0> on all eight I2C
controllers, matching the I3C nodes that already do so.
Fixes: fad32e8ac460 ("arm64: dts: cix: add DT nodes for all I2C and I3C ports for sky1")
Cc: stable@vger.kernel.org
Signed-off-by: Gary Yang <gary.yang@cixtech.com>
---
arch/arm64/boot/dts/cix/sky1.dtsi | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/arm64/boot/dts/cix/sky1.dtsi b/arch/arm64/boot/dts/cix/sky1.dtsi
index 0a820f45feb9..a18e8fd43fcf 100644
--- a/arch/arm64/boot/dts/cix/sky1.dtsi
+++ b/arch/arm64/boot/dts/cix/sky1.dtsi
@@ -290,6 +290,8 @@ soc@0 {
i2c0: i2c@4010000 {
compatible = "cdns,i2c-r1p14";
reg = <0x0 0x04010000 0x0 0x10000>;
+ #address-cells = <1>;
+ #size-cells = <0>;
clock-frequency = <400000>;
clocks = <&scmi_clk CLK_TREE_FCH_I2C0_APB>;
interrupts = <GIC_SPI 286 IRQ_TYPE_LEVEL_HIGH 0>;
@@ -299,6 +301,8 @@ i2c0: i2c@4010000 {
i2c1: i2c@4020000 {
compatible = "cdns,i2c-r1p14";
reg = <0x0 0x04020000 0x0 0x10000>;
+ #address-cells = <1>;
+ #size-cells = <0>;
clock-frequency = <400000>;
clocks = <&scmi_clk CLK_TREE_FCH_I2C1_APB>;
interrupts = <GIC_SPI 287 IRQ_TYPE_LEVEL_HIGH 0>;
@@ -308,6 +312,8 @@ i2c1: i2c@4020000 {
i2c2: i2c@4030000 {
compatible = "cdns,i2c-r1p14";
reg = <0x0 0x04030000 0x0 0x10000>;
+ #address-cells = <1>;
+ #size-cells = <0>;
clock-frequency = <400000>;
clocks = <&scmi_clk CLK_TREE_FCH_I2C2_APB>;
interrupts = <GIC_SPI 288 IRQ_TYPE_LEVEL_HIGH 0>;
@@ -317,6 +323,8 @@ i2c2: i2c@4030000 {
i2c3: i2c@4040000 {
compatible = "cdns,i2c-r1p14";
reg = <0x0 0x04040000 0x0 0x10000>;
+ #address-cells = <1>;
+ #size-cells = <0>;
clock-frequency = <400000>;
clocks = <&scmi_clk CLK_TREE_FCH_I2C3_APB>;
interrupts = <GIC_SPI 289 IRQ_TYPE_LEVEL_HIGH 0>;
@@ -326,6 +334,8 @@ i2c3: i2c@4040000 {
i2c4: i2c@4050000 {
compatible = "cdns,i2c-r1p14";
reg = <0x0 0x04050000 0x0 0x10000>;
+ #address-cells = <1>;
+ #size-cells = <0>;
clock-frequency = <400000>;
clocks = <&scmi_clk CLK_TREE_FCH_I2C4_APB>;
interrupts = <GIC_SPI 290 IRQ_TYPE_LEVEL_HIGH 0>;
@@ -335,6 +345,8 @@ i2c4: i2c@4050000 {
i2c5: i2c@4060000 {
compatible = "cdns,i2c-r1p14";
reg = <0x0 0x04060000 0x0 0x10000>;
+ #address-cells = <1>;
+ #size-cells = <0>;
clock-frequency = <400000>;
clocks = <&scmi_clk CLK_TREE_FCH_I2C5_APB>;
interrupts = <GIC_SPI 291 IRQ_TYPE_LEVEL_HIGH 0>;
@@ -344,6 +356,8 @@ i2c5: i2c@4060000 {
i2c6: i2c@4070000 {
compatible = "cdns,i2c-r1p14";
reg = <0x0 0x04070000 0x0 0x10000>;
+ #address-cells = <1>;
+ #size-cells = <0>;
clock-frequency = <400000>;
clocks = <&scmi_clk CLK_TREE_FCH_I2C6_APB>;
interrupts = <GIC_SPI 292 IRQ_TYPE_LEVEL_HIGH 0>;
@@ -353,6 +367,8 @@ i2c6: i2c@4070000 {
i2c7: i2c@4080000 {
compatible = "cdns,i2c-r1p14";
reg = <0x0 0x04080000 0x0 0x10000>;
+ #address-cells = <1>;
+ #size-cells = <0>;
clock-frequency = <400000>;
clocks = <&scmi_clk CLK_TREE_FCH_I2C7_APB>;
interrupts = <GIC_SPI 293 IRQ_TYPE_LEVEL_HIGH 0>;
--
2.50.1
^ permalink raw reply related [flat|nested] only message in thread