* [merged] mm-free-unused-page-table-allocated-by-do_set_pmd.patch removed from -mm tree
@ 2026-11-09 20:11 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2026-11-09 20:11 UTC (permalink / raw)
To: mm-commits, ziy, usama.arif, stable, ryan.roberts, qi.zheng,
nico.pache, liam, lance.yang, kas, hughd, dev.jain, baolin.wang,
baohua, david, akpm
The quilt patch titled
Subject: mm: free unused page table allocated by do_set_pmd()
has been removed from the -mm tree. Its filename was
mm-free-unused-page-table-allocated-by-do_set_pmd.patch
This patch was dropped because it was merged into mainline or a subsystem tree
------------------------------------------------------
From: "David Hildenbrand (Arm)" <david@kernel.org>
Subject: mm: free unused page table allocated by do_set_pmd()
Date: Fri, 06 Nov 2026 13:36:12 +0100
Patch series "mm: free unused page table allocated by do_set_pmd()", v2.
This patch (of 2):
do_set_pmd() can allocate vmf->prealloc_pte on architectures that need a
deposited page table, such as PowerPC with the hash MMU. If the PMD is
no longer empty when it takes the PMD lock, it returns VM_FAULT_FALLBACK
without consuming that table.
Since collapse_pte_mapped_thp() uses mmap_read_lock(), a concurrent
userfaultfd operation can install a PTE table before taking the folio
lock. If that races with set_huge_pmd(), the unused preallocated table
is lost when its local vm_fault goes out of scope.
Track whether do_set_pmd() allocated the table and free it after dropping
the PMD lock if it was not consumed. Preserve any preallocated table
supplied by the caller for PTE fallback. Successful PMD installation
consumes the table and clears the pointer.
Returning without a preallocated table matches the existing behavior on
architectures that do not need a deposited table. All callers
already handle that case.
Link: https://lore.kernel.org/20261106-khugepaged_set_pmd-v2-0-d2457b5e377a@kernel.org
Link: https://lore.kernel.org/20261106-khugepaged_set_pmd-v2-1-d2457b5e377a@kernel.org
Fixes: 1043173eb5eb ("mm/khugepaged: collapse_pte_mapped_thp() with mmap_read_lock()")
Signed-off-by: David Hildenbrand (Arm) <david@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Kiryl Shutsemau (Meta) <kas@kernel.org>
Reviewed-by: Lance Yang <lance.yang@linux.dev>
Acked-by: Usama Arif <usama.arif@linux.dev>
Cc: Zi Yan <ziy@nvidia.com>
Cc: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: Liam R. Howlett <liam@infradead.org>
Cc: Nico Pache <nico.pache@linux.dev>
Cc: Ryan Roberts <ryan.roberts@arm.com>
Cc: Dev Jain <dev.jain@arm.com>
Cc: Barry Song <baohua@kernel.org>
Cc: Qi Zheng <qi.zheng@linux.dev>
Cc: Hugh Dickins <hughd@google.com>
Cc: <stable@vger.kernel.org>
---
mm/memory.c | 6 ++++++
1 file changed, 6 insertions(+)
--- a/mm/memory.c~mm-free-unused-page-table-allocated-by-do_set_pmd
+++ a/mm/memory.c
@@ -5694,6 +5694,7 @@ vm_fault_t do_set_pmd(struct vm_fault *v
struct vm_area_struct *vma = vmf->vma;
bool write = vmf->flags & FAULT_FLAG_WRITE;
unsigned long haddr = vmf->address & HPAGE_PMD_MASK;
+ bool pgtable_allocated = false;
pmd_t entry;
vm_fault_t ret = VM_FAULT_FALLBACK;
@@ -5732,6 +5733,7 @@ vm_fault_t do_set_pmd(struct vm_fault *v
vmf->prealloc_pte = pte_alloc_one(vma->vm_mm);
if (!vmf->prealloc_pte)
return VM_FAULT_OOM;
+ pgtable_allocated = true;
}
vmf->ptl = pmd_lock(vma->vm_mm, vmf->pmd);
@@ -5762,6 +5764,10 @@ vm_fault_t do_set_pmd(struct vm_fault *v
count_vm_event(THP_FILE_MAPPED);
out:
spin_unlock(vmf->ptl);
+ if (pgtable_allocated && vmf->prealloc_pte) {
+ pte_free(vma->vm_mm, vmf->prealloc_pte);
+ vmf->prealloc_pte = NULL;
+ }
return ret;
}
#else
_
Patches currently in -mm which might be from david@kernel.org are
mm-memory-failure-fix-folio-refcount-leak-and-min_order_for_split-locking.patch
mm-dont-allocate-a-page-table-under-rcu-in-do_set_pmd.patch
mm-mprotect-dont-skip-uffd-marker-install-when-racing-with-pte-table-reclaim.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-11-09 20:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-09 20:11 [merged] mm-free-unused-page-table-allocated-by-do_set_pmd.patch removed from -mm tree Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox