Linux kernel -stable discussions
 help / color / mirror / Atom feed
* [PATCH 1/2] usb: gadget: fsl_udc: Fix potential use-after-free during removal
       [not found] <20261118-324f82bd41-usb-gadget-0@mail.sdu.edu.cn>
@ 2026-11-18 14:10 ` Guangshuo Li
  2026-11-20 12:10   ` Greg Kroah-Hartman
  0 siblings, 1 reply; 2+ messages in thread
From: Guangshuo Li @ 2026-11-18 14:10 UTC (permalink / raw)
  To: Neill Kapron, Greg Kroah-Hartman
  Cc: linux-usb, linux-kernel, linuxppc-dev, stable

usb_del_gadget_udc() can drop the last gadget device reference and call
fsl_udc_release(), which frees udc_controller. The remaining remove path
then dereferences it to release its requests, endpoints and DMA pool.

Hold a gadget device reference until this cleanup has finished.

This issue was found by our static analysis tool under development.

Fixes: eab35c4e6d95 ("usb: gadget: fsl_udc_core: let udc-core manage gadget->dev")
Cc: stable@vger.kernel.org
Signed-off-by: Guangshuo Li <liguangshuo@mail.sdu.edu.cn>
---
 drivers/usb/gadget/udc/fsl_udc_core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c b/drivers/usb/gadget/udc/fsl_udc_core.c
index 878d70b55530..9d9d2164c5bf 100644
--- a/drivers/usb/gadget/udc/fsl_udc_core.c
+++ b/drivers/usb/gadget/udc/fsl_udc_core.c
@@ -2537,6 +2537,7 @@ static void fsl_udc_remove(struct platform_device *pdev)
 	DECLARE_COMPLETION_ONSTACK(done);
 
 	udc_controller->done = &done;
+	get_device(&udc_controller->gadget.dev);
 	usb_del_gadget_udc(&udc_controller->gadget);
 
 	/* DR has been stopped in usb_gadget_unregister_driver() */
@@ -2554,6 +2555,7 @@ static void fsl_udc_remove(struct platform_device *pdev)
 		release_mem_region(res->start, resource_size(res));
 
 	/* free udc --wait for the release() finished */
+	put_device(&udc_controller->gadget.dev);
 	wait_for_completion(&done);
 
 	/*
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/2] usb: gadget: fsl_udc: Fix potential use-after-free during removal
  2026-11-18 14:10 ` [PATCH 1/2] usb: gadget: fsl_udc: Fix potential use-after-free during removal Guangshuo Li
@ 2026-11-20 12:10   ` Greg Kroah-Hartman
  0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2026-11-20 12:10 UTC (permalink / raw)
  To: Guangshuo Li; +Cc: Neill Kapron, linux-usb, linux-kernel, linuxppc-dev, stable

On Wed, Nov 18, 2026 at 10:10:53PM +0800, Guangshuo Li wrote:
> usb_del_gadget_udc() can drop the last gadget device reference and call
> fsl_udc_release(), which frees udc_controller. The remaining remove path
> then dereferences it to release its requests, endpoints and DMA pool.
> 
> Hold a gadget device reference until this cleanup has finished.
> 
> This issue was found by our static analysis tool under development.
> 
> Fixes: eab35c4e6d95 ("usb: gadget: fsl_udc_core: let udc-core manage gadget->dev")
> Cc: stable@vger.kernel.org
> Signed-off-by: Guangshuo Li <liguangshuo@mail.sdu.edu.cn>
> ---
>  drivers/usb/gadget/udc/fsl_udc_core.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c b/drivers/usb/gadget/udc/fsl_udc_core.c
> index 878d70b55530..9d9d2164c5bf 100644
> --- a/drivers/usb/gadget/udc/fsl_udc_core.c
> +++ b/drivers/usb/gadget/udc/fsl_udc_core.c
> @@ -2537,6 +2537,7 @@ static void fsl_udc_remove(struct platform_device *pdev)
>  	DECLARE_COMPLETION_ONSTACK(done);
>  
>  	udc_controller->done = &done;
> +	get_device(&udc_controller->gadget.dev);

This feels wrong, why are you needing a fake reference here?

>  	usb_del_gadget_udc(&udc_controller->gadget);

This is where it should all go away.  If not, then reorder the code
properly.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-20 12:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20261118-324f82bd41-usb-gadget-0@mail.sdu.edu.cn>
2026-11-18 14:10 ` [PATCH 1/2] usb: gadget: fsl_udc: Fix potential use-after-free during removal Guangshuo Li
2026-11-20 12:10   ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox