Linux kernel -stable discussions
 help / color / mirror / Atom feed
* [PATCH] usb: xhci-pci: don't perform Soft Retry on the AMD X470 chipset host
@ 2026-11-22  5:49 Rosen Penev
  0 siblings, 0 replies; only message in thread
From: Rosen Penev @ 2026-11-22  5:49 UTC (permalink / raw)
  To: Mathias Nyman, Greg Kroah-Hartman; +Cc: linux-usb, stable

Commit a4a251f8c235 ("usb: xhci: do not perform Soft Retry for some xHCI
hosts") disabled Soft Retry on the 300 series Promontory hosts, which
fail to resume an endpoint after it. The X470 chipset host (1022:43d0)
has the same problem.

With an RT3070 USB Wi-Fi adapter (rt2800usb) on an X470 port, the
bulk IN endpoint sees one USB Transaction Error while the interface is
brought up. xhci soft-retries it with a Reset Endpoint command that
preserves the transfer state, the endpoint context reads back as
running, and no transfer completes on it again: the adapter receives
frames (its RX FIFO overflow counter climbs) but none reach the host.
Booting with xhci_hcd.quirks=0x10000000000 (XHCI_NO_SOFT_RETRY) lets
the URB complete with an error instead, rt2x00usb resubmits it and
reception keeps working.

Cc: stable@vger.kernel.org
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 drivers/usb/host/xhci-pci.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index e278db940a58..0a8b5b04e324 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -88,6 +88,7 @@
 #define PCI_DEVICE_ID_AMD_PROMONTORYA_3			0x43ba
 #define PCI_DEVICE_ID_AMD_PROMONTORYA_2			0x43bb
 #define PCI_DEVICE_ID_AMD_PROMONTORYA_1			0x43bc
+#define PCI_DEVICE_ID_AMD_X470_XHCI			0x43d0
 
 #define PCI_DEVICE_ID_ATI_NAVI10_7316_XHCI		0x7316
 
@@ -493,7 +494,8 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
 
 	if (pdev->vendor == PCI_VENDOR_ID_AMD &&
 	    (pdev->device == PCI_DEVICE_ID_AMD_PROMONTORYA_2 ||
-	     pdev->device == PCI_DEVICE_ID_AMD_PROMONTORYA_4))
+	     pdev->device == PCI_DEVICE_ID_AMD_PROMONTORYA_4 ||
+	     pdev->device == PCI_DEVICE_ID_AMD_X470_XHCI))
 		xhci->quirks |= XHCI_NO_SOFT_RETRY;
 
 	if (pdev->vendor == PCI_VENDOR_ID_ZHAOXIN) {
-- 
2.56.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-11-22  5:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-22  5:49 [PATCH] usb: xhci-pci: don't perform Soft Retry on the AMD X470 chipset host Rosen Penev

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox