From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, stern@rowland.harvard.edu,
Paul Menzel <pmenzel@molgen.mpg.de>,
stable@vger.kernel.org
Subject: Re: [PATCH 2/2] usb: port: Don't try to peer unused USB ports based on location
Date: Thu, 22 Feb 2024 17:03:39 +0200 [thread overview]
Message-ID: <2989954e-fe0c-c0de-7e72-345762492ebf@linux.intel.com> (raw)
In-Reply-To: <2024022220-untried-routine-15e5@gregkh>
On 22.2.2024 16.06, Greg KH wrote:
> On Thu, Feb 22, 2024 at 03:38:19PM +0200, Mathias Nyman wrote:
>> Unused USB ports may have bogus location data in ACPI PLD tables.
>> This causes port peering failures as these unused USB2 and USB3 ports
>> location may match.
>>
>> This is seen on DELL systems where all unused ports return zeroed
>> location data.
>>
>> Don't try to peer or match ports that have connect type set to
>> USB_PORT_NOT_USED.
>>
>> Tested-by: Paul Menzel <pmenzel@molgen.mpg.de>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
>
> What commit does this fix? "all" of them?
Right, git blame shows the code this fixes was added 10 years ago in 3.16
Fixes: 3bfd659baec8 ("usb: find internal hub tier mismatch via acpi")
Cc: stable@vger.kernel.org # v3.16+
Thanks
Mathias
next prev parent reply other threads:[~2024-02-22 15:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240222133819.4149388-1-mathias.nyman@linux.intel.com>
2024-02-22 13:38 ` [PATCH 2/2] usb: port: Don't try to peer unused USB ports based on location Mathias Nyman
2024-02-22 14:06 ` Greg KH
2024-02-22 15:03 ` Mathias Nyman [this message]
2024-02-22 15:51 ` Paul Menzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2989954e-fe0c-c0de-7e72-345762492ebf@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
--cc=stable@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox