Problem mounting efivarfs in 3.9

Problem mounting efivarfs in 3.9

[Seth Forshee]

Hi Matt,

I found myself unable to mount efivarfs on one of my machines in 3.9.
This is due to your patch to be more aggressive about validating
filenames. This machine had some crash dumps from pstore, which start
with "dump-type". However now efivars expects the guid to follow the
first '-' character, despite the fact that the efivars pstore code is
creating the file names starting with dump-type. Since these names fail
the validation the mount fails.

These changes are now in some of the stable releases as well (3.8.x at
minumum).

Thanks,
Seth

Re: Problem mounting efivarfs in 3.9

[shea]

Hi Seth,

On 2013-03-07 09:56, Seth Forshee wrote:
> Hi Matt,
>
> I found myself unable to mount efivarfs on one of my machines in 3.9.
> This is due to your patch to be more aggressive about validating
> filenames. This machine had some crash dumps from pstore, which start
> with "dump-type". However now efivars expects the guid to follow the
> first '-' character, despite the fact that the efivars pstore code is
> creating the file names starting with dump-type. Since these names 
> fail
> the validation the mount fails.
>

A fix for this is already in mfleming/efi.git: 
http://git.kernel.org/cgit/linux/kernel/git/mfleming/efi.git/commit/?h=urgent&id=123abd76edf56c02a76b46d3d673897177ef067b 
. It's included in the efi-for-3.9-rc2 tag, and cc'd stable.

Cheers,
Shea Levy

Re: Problem mounting efivarfs in 3.9

[Matt Fleming]

On Thu, 2013-03-07 at 08:56 -0600, Seth Forshee wrote:
> Hi Matt,
> 
> I found myself unable to mount efivarfs on one of my machines in 3.9.
> This is due to your patch to be more aggressive about validating
> filenames. This machine had some crash dumps from pstore, which start
> with "dump-type". However now efivars expects the guid to follow the
> first '-' character, despite the fact that the efivars pstore code is
> creating the file names starting with dump-type. Since these names fail
> the validation the mount fails.

A patch to allow pstore names is in the pull request I sent to Peter and
Ingo yesterday,

	http://marc.info/?l=linux-kernel&m=136258373231608&w=2

Re: Problem mounting efivarfs in 3.9

[Seth Forshee]

On Thu, Mar 07, 2013 at 03:02:38PM +0000, Matt Fleming wrote:
> On Thu, 2013-03-07 at 08:56 -0600, Seth Forshee wrote:
> > Hi Matt,
> > 
> > I found myself unable to mount efivarfs on one of my machines in 3.9.
> > This is due to your patch to be more aggressive about validating
> > filenames. This machine had some crash dumps from pstore, which start
> > with "dump-type". However now efivars expects the guid to follow the
> > first '-' character, despite the fact that the efivars pstore code is
> > creating the file names starting with dump-type. Since these names fail
> > the validation the mount fails.
> 
> A patch to allow pstore names is in the pull request I sent to Peter and
> Ingo yesterday,
> 
> 	http://marc.info/?l=linux-kernel&m=136258373231608&w=2

Great. Thanks!

Seth