Re: [PATCH v2] drm/amd/display: Fix uninitialized variable usage in core_link_ 'read_dpcd() & write_dpcd()' functions

[Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>]

Hi Srinivasan

On 1/17/24 08:23, Srinivasan Shanmugam wrote:
> The 'status' variable in 'core_link_read_dpcd()' &
> 'core_link_write_dpcd()' was uninitialized.
> 
> Thus, initializing 'status' variable to 'DC_ERROR_UNEXPECTED' by default.
> 
> Fixes the below:
> drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dpcd.c:226 core_link_read_dpcd() error: uninitialized symbol 'status'.
> drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dpcd.c:248 core_link_write_dpcd() error: uninitialized symbol 'status'.
> 
> Cc: stable@vger.kernel.org
> Cc: Jerry Zuo <jerry.zuo@amd.com>
> Cc: Jun Lei <Jun.Lei@amd.com>
> Cc: Wayne Lin <Wayne.Lin@amd.com>
> Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> Cc: Hamza Mahfooz <hamza.mahfooz@amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>


This change lgtm.

Btw, avoid to send new patches as a reply of the previous one.

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>

Thanks
Siqueira

> ---
> v2:
>    - Initialized status variable to 'DC_ERROR_UNEXPECTED' default.
>    - Added Jerry to Cc
> 
>   drivers/gpu/drm/amd/display/dc/link/protocols/link_dpcd.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dpcd.c b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dpcd.c
> index 5c9a30211c10..fc50931c2aec 100644
> --- a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dpcd.c
> +++ b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dpcd.c
> @@ -205,7 +205,7 @@ enum dc_status core_link_read_dpcd(
>   	uint32_t extended_size;
>   	/* size of the remaining partitioned address space */
>   	uint32_t size_left_to_read;
> -	enum dc_status status;
> +	enum dc_status status = DC_ERROR_UNEXPECTED;
>   	/* size of the next partition to be read from */
>   	uint32_t partition_size;
>   	uint32_t data_index = 0;
> @@ -234,7 +234,7 @@ enum dc_status core_link_write_dpcd(
>   {
>   	uint32_t partition_size;
>   	uint32_t data_index = 0;
> -	enum dc_status status;
> +	enum dc_status status = DC_ERROR_UNEXPECTED;
>   
>   	while (size) {
>   		partition_size = dpcd_get_next_partition_size(address, size);