* [PATCH] drm/amd/display: Fix uninitialized variable usage in core_link_ 'read_dpcd() & write_dpcd()' functions
@ 2024-01-17 3:23 Srinivasan Shanmugam
2024-01-17 5:18 ` [PATCH v2] " Srinivasan Shanmugam
2024-01-17 15:23 ` Srinivasan Shanmugam
0 siblings, 2 replies; 4+ messages in thread
From: Srinivasan Shanmugam @ 2024-01-17 3:23 UTC (permalink / raw)
To: Rodrigo Siqueira, Aurabindo Pillai
Cc: amd-gfx, Srinivasan Shanmugam, stable, Wesley Chalmers, Jun Lei,
Wayne Lin, Hamza Mahfooz
The 'status' variable in 'core_link_read_dpcd()' &
'core_link_write_dpcd()' was uninitialized for success scenarios.
Thus, initializing 'status' variable with appropriate enum value.
Fixes the below:
drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dpcd.c:226 core_link_read_dpcd() error: uninitialized symbol 'status'.
drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dpcd.c:248 core_link_write_dpcd() error: uninitialized symbol 'status'.
Cc: stable@vger.kernel.org
Cc: Wesley Chalmers <Wesley.Chalmers@amd.com>
Cc: Jun Lei <Jun.Lei@amd.com>
Cc: Wayne Lin <Wayne.Lin@amd.com>
Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Cc: Hamza Mahfooz <hamza.mahfooz@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
---
drivers/gpu/drm/amd/display/dc/link/protocols/link_dpcd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dpcd.c b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dpcd.c
index 5c9a30211c10..2b2073dce389 100644
--- a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dpcd.c
+++ b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dpcd.c
@@ -205,7 +205,7 @@ enum dc_status core_link_read_dpcd(
uint32_t extended_size;
/* size of the remaining partitioned address space */
uint32_t size_left_to_read;
- enum dc_status status;
+ enum dc_status status = DC_OK;
/* size of the next partition to be read from */
uint32_t partition_size;
uint32_t data_index = 0;
@@ -234,7 +234,7 @@ enum dc_status core_link_write_dpcd(
{
uint32_t partition_size;
uint32_t data_index = 0;
- enum dc_status status;
+ enum dc_status status = DC_OK;
while (size) {
partition_size = dpcd_get_next_partition_size(address, size);
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] drm/amd/display: Fix uninitialized variable usage in core_link_ 'read_dpcd() & write_dpcd()' functions
2024-01-17 3:23 [PATCH] drm/amd/display: Fix uninitialized variable usage in core_link_ 'read_dpcd() & write_dpcd()' functions Srinivasan Shanmugam
@ 2024-01-17 5:18 ` Srinivasan Shanmugam
2024-01-17 15:23 ` Srinivasan Shanmugam
1 sibling, 0 replies; 4+ messages in thread
From: Srinivasan Shanmugam @ 2024-01-17 5:18 UTC (permalink / raw)
To: Rodrigo Siqueira, Aurabindo Pillai
Cc: amd-gfx, Srinivasan Shanmugam, stable, Jun Lei, Wayne Lin,
Hamza Mahfooz
The 'status' variable in 'core_link_read_dpcd()' &
'core_link_write_dpcd()' was uninitialized.
Thus, initializing 'status' variable to 'DC_ERROR_UNEXPECTED' by default.
Fixes the below:
drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dpcd.c:226 core_link_read_dpcd() error: uninitialized symbol 'status'.
drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dpcd.c:248 core_link_write_dpcd() error: uninitialized symbol 'status'.
Cc: stable@vger.kernel.org
Cc: Jun Lei <Jun.Lei@amd.com>
Cc: Wayne Lin <Wayne.Lin@amd.com>
Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Cc: Hamza Mahfooz <hamza.mahfooz@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
---
v2:
- Initialized status variable to 'DC_ERROR_UNEXPECTED' default.
drivers/gpu/drm/amd/display/dc/link/protocols/link_dpcd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dpcd.c b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dpcd.c
index 5c9a30211c10..fc50931c2aec 100644
--- a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dpcd.c
+++ b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dpcd.c
@@ -205,7 +205,7 @@ enum dc_status core_link_read_dpcd(
uint32_t extended_size;
/* size of the remaining partitioned address space */
uint32_t size_left_to_read;
- enum dc_status status;
+ enum dc_status status = DC_ERROR_UNEXPECTED;
/* size of the next partition to be read from */
uint32_t partition_size;
uint32_t data_index = 0;
@@ -234,7 +234,7 @@ enum dc_status core_link_write_dpcd(
{
uint32_t partition_size;
uint32_t data_index = 0;
- enum dc_status status;
+ enum dc_status status = DC_ERROR_UNEXPECTED;
while (size) {
partition_size = dpcd_get_next_partition_size(address, size);
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] drm/amd/display: Fix uninitialized variable usage in core_link_ 'read_dpcd() & write_dpcd()' functions
2024-01-17 3:23 [PATCH] drm/amd/display: Fix uninitialized variable usage in core_link_ 'read_dpcd() & write_dpcd()' functions Srinivasan Shanmugam
2024-01-17 5:18 ` [PATCH v2] " Srinivasan Shanmugam
@ 2024-01-17 15:23 ` Srinivasan Shanmugam
2024-01-17 22:54 ` Rodrigo Siqueira Jordao
1 sibling, 1 reply; 4+ messages in thread
From: Srinivasan Shanmugam @ 2024-01-17 15:23 UTC (permalink / raw)
To: Rodrigo Siqueira, Aurabindo Pillai
Cc: amd-gfx, Srinivasan Shanmugam, stable, Jerry Zuo, Jun Lei,
Wayne Lin, Hamza Mahfooz
The 'status' variable in 'core_link_read_dpcd()' &
'core_link_write_dpcd()' was uninitialized.
Thus, initializing 'status' variable to 'DC_ERROR_UNEXPECTED' by default.
Fixes the below:
drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dpcd.c:226 core_link_read_dpcd() error: uninitialized symbol 'status'.
drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dpcd.c:248 core_link_write_dpcd() error: uninitialized symbol 'status'.
Cc: stable@vger.kernel.org
Cc: Jerry Zuo <jerry.zuo@amd.com>
Cc: Jun Lei <Jun.Lei@amd.com>
Cc: Wayne Lin <Wayne.Lin@amd.com>
Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Cc: Hamza Mahfooz <hamza.mahfooz@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
---
v2:
- Initialized status variable to 'DC_ERROR_UNEXPECTED' default.
- Added Jerry to Cc
drivers/gpu/drm/amd/display/dc/link/protocols/link_dpcd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dpcd.c b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dpcd.c
index 5c9a30211c10..fc50931c2aec 100644
--- a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dpcd.c
+++ b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dpcd.c
@@ -205,7 +205,7 @@ enum dc_status core_link_read_dpcd(
uint32_t extended_size;
/* size of the remaining partitioned address space */
uint32_t size_left_to_read;
- enum dc_status status;
+ enum dc_status status = DC_ERROR_UNEXPECTED;
/* size of the next partition to be read from */
uint32_t partition_size;
uint32_t data_index = 0;
@@ -234,7 +234,7 @@ enum dc_status core_link_write_dpcd(
{
uint32_t partition_size;
uint32_t data_index = 0;
- enum dc_status status;
+ enum dc_status status = DC_ERROR_UNEXPECTED;
while (size) {
partition_size = dpcd_get_next_partition_size(address, size);
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drm/amd/display: Fix uninitialized variable usage in core_link_ 'read_dpcd() & write_dpcd()' functions
2024-01-17 15:23 ` Srinivasan Shanmugam
@ 2024-01-17 22:54 ` Rodrigo Siqueira Jordao
0 siblings, 0 replies; 4+ messages in thread
From: Rodrigo Siqueira Jordao @ 2024-01-17 22:54 UTC (permalink / raw)
To: Srinivasan Shanmugam, Aurabindo Pillai
Cc: amd-gfx, stable, Jerry Zuo, Jun Lei, Wayne Lin, Hamza Mahfooz
Hi Srinivasan
On 1/17/24 08:23, Srinivasan Shanmugam wrote:
> The 'status' variable in 'core_link_read_dpcd()' &
> 'core_link_write_dpcd()' was uninitialized.
>
> Thus, initializing 'status' variable to 'DC_ERROR_UNEXPECTED' by default.
>
> Fixes the below:
> drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dpcd.c:226 core_link_read_dpcd() error: uninitialized symbol 'status'.
> drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dpcd.c:248 core_link_write_dpcd() error: uninitialized symbol 'status'.
>
> Cc: stable@vger.kernel.org
> Cc: Jerry Zuo <jerry.zuo@amd.com>
> Cc: Jun Lei <Jun.Lei@amd.com>
> Cc: Wayne Lin <Wayne.Lin@amd.com>
> Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> Cc: Hamza Mahfooz <hamza.mahfooz@amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
This change lgtm.
Btw, avoid to send new patches as a reply of the previous one.
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Thanks
Siqueira
> ---
> v2:
> - Initialized status variable to 'DC_ERROR_UNEXPECTED' default.
> - Added Jerry to Cc
>
> drivers/gpu/drm/amd/display/dc/link/protocols/link_dpcd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dpcd.c b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dpcd.c
> index 5c9a30211c10..fc50931c2aec 100644
> --- a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dpcd.c
> +++ b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dpcd.c
> @@ -205,7 +205,7 @@ enum dc_status core_link_read_dpcd(
> uint32_t extended_size;
> /* size of the remaining partitioned address space */
> uint32_t size_left_to_read;
> - enum dc_status status;
> + enum dc_status status = DC_ERROR_UNEXPECTED;
> /* size of the next partition to be read from */
> uint32_t partition_size;
> uint32_t data_index = 0;
> @@ -234,7 +234,7 @@ enum dc_status core_link_write_dpcd(
> {
> uint32_t partition_size;
> uint32_t data_index = 0;
> - enum dc_status status;
> + enum dc_status status = DC_ERROR_UNEXPECTED;
>
> while (size) {
> partition_size = dpcd_get_next_partition_size(address, size);
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-01-17 22:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-17 3:23 [PATCH] drm/amd/display: Fix uninitialized variable usage in core_link_ 'read_dpcd() & write_dpcd()' functions Srinivasan Shanmugam
2024-01-17 5:18 ` [PATCH v2] " Srinivasan Shanmugam
2024-01-17 15:23 ` Srinivasan Shanmugam
2024-01-17 22:54 ` Rodrigo Siqueira Jordao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox