public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: Sasha Levin <sashal@kernel.org>, Takashi Iwai <tiwai@suse.de>,
	ALSA development <alsa-devel@alsa-project.org>,
	stable@vger.kernel.org
Subject: Re: 5.5.y - apply "ASoC: intel/skl/hda - export number of digital microphones via control components"
Date: Wed, 4 Mar 2020 13:30:59 -0600	[thread overview]
Message-ID: <3b00df9a-6b53-def7-4304-d9829de749c6@linux.intel.com> (raw)
In-Reply-To: <20200304190620.GF5646@sirena.org.uk>



On 3/4/20 1:06 PM, Mark Brown wrote:
> On Wed, Mar 04, 2020 at 12:50:54PM -0600, Pierre-Louis Bossart wrote:
> 
>>> This thread is the first suggestion I've seen that this is any kind of
>>> bug fix.  There's no Fixes tag and the patch description itself sounds
>>> like it's adding a new feature to enable new functionality in userspace
>>> (autodetection by UCM) and it was posted as part of a series "ASoC: SOF:
>>> initial cleanup for DT and multi-client support" which again doesn't
>>> give any indication that this might be supposed to be a bug fix.
> 
>> the initial patch came from Jaroslav on 11/26, not from me. Quoting your own
>> words:
> 
>> "Since Pierre seems happy with it even if he didn't ack it explicitly
>> I'll guess I'll apply it.  If git can figure out applying it after the
>> merge window and it doesn't get negative reviews there's no need to
>> resend.  If it can't and it doesn't turn up in a bigger series before
>> then I'll let you know.
>> "
> 
> Right, that's me saying I'll apply something that looks like normal
> development work after the merge window as with other normal development
> work (even Jaroslav's initial version was sent after the merge window
> opened), not that I'll apply it as a fix.  There's no hint in any of
> that thread or in your resend that this was anything other than a new
> feature, and indeed you were talking about wanting to integrate it with
> a series that you didn't want to see in v5.5.  Jaroslav mentioned not
> wanting to delay if it'd cause him to miss the merge window but didn't
> seem to complain when I said he'd missed it with his initial posting.

ok, I misunderstood your reply then. I thought you would provide it as 
an update for v5.5, thanks for the clarification

> Anyway, is my understanding correct that this is fixing a regression
> caused by switching the default to SOF?

This is fixing a regression on platforms that have digital microphones, 
where SOF is automatically selected by default. For platforms without 
DMICs, the legacy driver is still used and this patch has no effect.


  reply	other threads:[~2020-03-04 19:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04 15:25 5.5.y - apply "ASoC: intel/skl/hda - export number of digital microphones via control components" Jaroslav Kysela
2020-03-04 15:44 ` Mark Brown
2020-03-04 15:53   ` Jaroslav Kysela
2020-03-04 16:09     ` Mark Brown
2020-03-04 17:17       ` Pierre-Louis Bossart
2020-03-04 18:11         ` Mark Brown
2020-03-04 18:50           ` Pierre-Louis Bossart
2020-03-04 19:06             ` Mark Brown
2020-03-04 19:30               ` Pierre-Louis Bossart [this message]
2020-03-04 19:38                 ` Mark Brown
2020-03-06 13:15 ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b00df9a-6b53-def7-4304-d9829de749c6@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox