From: Markus Elfring <Markus.Elfring@web.de>
To: Eslam Khafagy <eslam.medhat1993@gmail.com>,
linux-input@vger.kernel.org,
Benjamin Tissoires <bentiss@kernel.org>,
Jiri Kosina <jikos@kernel.org>, Max Staudt <max@enpas.org>,
Roderick Colenbrander <roderick.colenbrander@sony.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
syzbot+4f5f81e1456a1f645bf8@syzkaller.appspotmail.com
Subject: Re: [PATCH v3] HID: memory leak in dualshock4_get_calibration_data
Date: Sat, 22 Nov 2025 19:15:23 +0100 [thread overview]
Message-ID: <3b8adba8-0cfa-4a83-8776-ba7245c58947@web.de> (raw)
In-Reply-To: <20251122173712.76397-1-eslam.medhat1993@gmail.com>
> Function dualshock4_get_calibration_data allocates memory to pointer
> buf .However, the function may exit prematurely due to transfer_failure
transfer failure.?
> in this case it does not handle freeing memory.
>
> This patch handles memory deallocation at exit.
Would a corresponding imperative wording become helpful for an improved change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18-rc6#n94
Would a summary phrase like “Prevent memory leak in dualshock4_get_calibration_data()”
be nicer?
Regards,
Markus
next prev parent reply other threads:[~2025-11-22 18:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-22 17:37 [PATCH v3] HID: memory leak in dualshock4_get_calibration_data Eslam Khafagy
2025-11-22 18:09 ` Max Staudt
2025-11-22 18:15 ` Markus Elfring [this message]
2025-11-24 6:32 ` Jiri Slaby
2025-11-24 14:06 ` Max Staudt
2025-11-25 18:19 ` Eslam Khafagy
2025-11-27 16:55 ` Max Staudt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b8adba8-0cfa-4a83-8776-ba7245c58947@web.de \
--to=markus.elfring@web.de \
--cc=bentiss@kernel.org \
--cc=eslam.medhat1993@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=max@enpas.org \
--cc=roderick.colenbrander@sony.com \
--cc=stable@vger.kernel.org \
--cc=syzbot+4f5f81e1456a1f645bf8@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox