From: Max Staudt <max@enpas.org>
To: Eslam Khafagy <eslam.medhat1993@gmail.com>,
Jiri Slaby <jirislaby@kernel.org>,
roderick.colenbrander@sony.com, jikos@kernel.org,
bentiss@kernel.org
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+4f5f81e1456a1f645bf8@syzkaller.appspotmail.com,
stable@vger.kernel.org
Subject: Re: [PATCH v3] HID: memory leak in dualshock4_get_calibration_data
Date: Fri, 28 Nov 2025 01:55:29 +0900 [thread overview]
Message-ID: <e1fb509f-6a3a-411f-a756-03c389eb4335@enpas.org> (raw)
In-Reply-To: <f67a5702-4b44-41bb-9538-19063bc28b41@gmail.com>
On 11/26/25 3:19 AM, Eslam Khafagy wrote:
> Lastly, One question to max,
> at the beginning of the function dualshock4_get_calibration_data
> buf = kzalloc(DS4_FEATURE_REPORT_CALIBRATION_SIZE, GFP_KERNEL); if (!
> buf) { ret = -ENOMEM; goto transfer_failed; }
> if the allocation fails. can't we just return here
Never.
> or do we need to go the the end of the function and do sanity checks
> at the end?
Correct.
Without the sanitisation code, the driver will divide by zero.
Max
prev parent reply other threads:[~2025-11-27 16:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-22 17:37 [PATCH v3] HID: memory leak in dualshock4_get_calibration_data Eslam Khafagy
2025-11-22 18:09 ` Max Staudt
2025-11-22 18:15 ` Markus Elfring
2025-11-24 6:32 ` Jiri Slaby
2025-11-24 14:06 ` Max Staudt
2025-11-25 18:19 ` Eslam Khafagy
2025-11-27 16:55 ` Max Staudt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1fb509f-6a3a-411f-a756-03c389eb4335@enpas.org \
--to=max@enpas.org \
--cc=bentiss@kernel.org \
--cc=eslam.medhat1993@gmail.com \
--cc=jikos@kernel.org \
--cc=jirislaby@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roderick.colenbrander@sony.com \
--cc=stable@vger.kernel.org \
--cc=syzbot+4f5f81e1456a1f645bf8@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox