Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: "Stephan Müller" <smueller@chronox.de>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: keyrings@vger.kernel.org, David Howells <dhowells@redhat.com>,
	Eric Biggers <ebiggers3@gmail.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Kirill Marinushkin <k.marinushkin@gmail.com>,
	security@kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] security/keys: rewrite all of big_key crypto
Date: Wed, 07 Jun 2017 07:14:20 +0200	[thread overview]
Message-ID: <4079216.Z1x2SUeU2i@tauon.chronox.de> (raw)
In-Reply-To: <20170606173900.29279-1-Jason@zx2c4.com>

Am Dienstag, 6. Juni 2017, 19:39:00 CEST schrieb Jason A. Donenfeld:

Hi Jason,

> This started out as just replacing the use of crypto/rng with

I have some concerns on this part. The use of crypto/rng is to help all users, 
including those who like FIPS and Co. The crypto/rng code per default uses the 
DRBG which is mandatory for several people.

I wish it would not be needed such that the get_random_bytes provides the 
possibility to use a DRBG ... .

As the DRBG has considerations around early boot entropy, I would think that 
the entropy discussion is not applicable here.

Thanks
Stephan

  parent reply	other threads:[~2017-06-07  5:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-06 17:39 [PATCH] security/keys: rewrite all of big_key crypto Jason A. Donenfeld
2017-06-06 17:40 ` Jason A. Donenfeld
2017-06-06 17:58 ` David Howells
2017-06-06 18:25   ` Jason A. Donenfeld
2017-06-06 18:45     ` David Howells
2017-06-06 19:18       ` Jason A. Donenfeld
2017-06-06 20:58 ` Eric Biggers
2017-06-06 21:31   ` Jason A. Donenfeld
2017-06-07  5:14 ` Stephan Müller [this message]
2017-06-07 10:09   ` Jason A. Donenfeld
2017-06-07 11:30     ` Stephan Müller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4079216.Z1x2SUeU2i@tauon.chronox.de \
    --to=smueller@chronox.de \
    --cc=Jason@zx2c4.com \
    --cc=dhowells@redhat.com \
    --cc=ebiggers3@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=k.marinushkin@gmail.com \
    --cc=keyrings@vger.kernel.org \
    --cc=security@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox