* [PATCH] HID: hid-input: battery quirk for Apple keyboard
@ 2012-11-25 14:08 Ortwin Glück
2012-11-25 14:13 ` devendra.aaru
2012-11-26 13:27 ` Jiri Kosina
0 siblings, 2 replies; 6+ messages in thread
From: Ortwin Glück @ 2012-11-25 14:08 UTC (permalink / raw)
To: linux-kernel, linux-input, Jiri Kosina; +Cc: stable
Support battery capacity on another Apple wireless
keyboard.
NB: most likely all other APPLE_ALU_WIRELESS_*
keyboards should be added as well.
Signed-off-by: Ortwin Gl�ck <odi@odi.ch>
---
diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index 5301006..b2ae097 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -299,6 +299,9 @@ static enum power_supply_property hidinput_battery_props[] = {
static const struct hid_device_id hid_battery_quirks[] = {
{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
+ USB_DEVICE_ID_APPLE_ALU_WIRELESS_2009_ISO),
+ HID_BATTERY_QUIRK_PERCENT | HID_BATTERY_QUIRK_FEATURE },
+ { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
USB_DEVICE_ID_APPLE_ALU_WIRELESS_2011_ANSI),
HID_BATTERY_QUIRK_PERCENT | HID_BATTERY_QUIRK_FEATURE },
{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] HID: hid-input: battery quirk for Apple keyboard
2012-11-25 14:08 [PATCH] HID: hid-input: battery quirk for Apple keyboard Ortwin Glück
@ 2012-11-25 14:13 ` devendra.aaru
2012-11-26 0:45 ` Ben Hutchings
2012-11-26 13:27 ` Jiri Kosina
1 sibling, 1 reply; 6+ messages in thread
From: devendra.aaru @ 2012-11-25 14:13 UTC (permalink / raw)
To: Ortwin Glück
Cc: linux-kernel@vger.kernel.org, Linux Input, Jiri Kosina, stable
i think you should simply do a cc: stable@vger.kernel.org just right
above your signedoff-by, which is the way that stable patches gets
into i think.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] HID: hid-input: battery quirk for Apple keyboard
2012-11-25 14:13 ` devendra.aaru
@ 2012-11-26 0:45 ` Ben Hutchings
0 siblings, 0 replies; 6+ messages in thread
From: Ben Hutchings @ 2012-11-26 0:45 UTC (permalink / raw)
To: devendra.aaru
Cc: Ortwin Glück, linux-kernel@vger.kernel.org, Linux Input,
Jiri Kosina, stable
[-- Attachment #1: Type: text/plain, Size: 488 bytes --]
On Sun, 2012-11-25 at 09:13 -0500, devendra.aaru wrote:
> i think you should simply do a cc: stable@vger.kernel.org just right
> above your signedoff-by, which is the way that stable patches gets
> into i think.
It's OK to cc stable@ when submitting a patch, but that line must be
included in the commit message to ensure it actually gets considered for
stable updates.
Ben.
--
Ben Hutchings
Never attribute to conspiracy what can adequately be explained by stupidity.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] HID: hid-input: battery quirk for Apple keyboard
@ 2012-11-26 12:32 Ortwin Glück
2012-11-26 14:46 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Ortwin Glück @ 2012-11-26 12:32 UTC (permalink / raw)
To: linux-kernel; +Cc: stable
Support battery capacity on another Apple wireless
keyboard.
NB: most likely all other APPLE_ALU_WIRELESS_*
keyboards should be added as well.
Cc: stable <at> kernel.org
Signed-off-by: Ortwin Gl�ck <odi@odi.ch>
---
diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index 5301006..b2ae097 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -299,6 +299,9 @@ static enum power_supply_property
hidinput_battery_props[] = {
static const struct hid_device_id hid_battery_quirks[] = {
{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
+ USB_DEVICE_ID_APPLE_ALU_WIRELESS_2009_ISO),
+ HID_BATTERY_QUIRK_PERCENT | HID_BATTERY_QUIRK_FEATURE },
+ { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
USB_DEVICE_ID_APPLE_ALU_WIRELESS_2011_ANSI),
HID_BATTERY_QUIRK_PERCENT | HID_BATTERY_QUIRK_FEATURE },
{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] HID: hid-input: battery quirk for Apple keyboard
2012-11-25 14:08 [PATCH] HID: hid-input: battery quirk for Apple keyboard Ortwin Glück
2012-11-25 14:13 ` devendra.aaru
@ 2012-11-26 13:27 ` Jiri Kosina
1 sibling, 0 replies; 6+ messages in thread
From: Jiri Kosina @ 2012-11-26 13:27 UTC (permalink / raw)
To: Ortwin Glück; +Cc: linux-kernel, linux-input, stable
On Sun, 25 Nov 2012, Ortwin Gl�ck wrote:
> Support battery capacity on another Apple wireless
> keyboard.
Your patch has been whitespace damaged. I have fixed it by hand and
applied, but please fix your process for any future patch submissions.
Thanks.
> NB: most likely all other APPLE_ALU_WIRELESS_* keyboards should be added
> as well.
I think it's likely true, but I prefer to have it actually tested before
doing such changes blindly.
Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] HID: hid-input: battery quirk for Apple keyboard
2012-11-26 12:32 Ortwin Glück
@ 2012-11-26 14:46 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2012-11-26 14:46 UTC (permalink / raw)
To: Ortwin Glück; +Cc: linux-kernel, stable
On Mon, Nov 26, 2012 at 01:32:07PM +0100, Ortwin Gl�ck wrote:
> Support battery capacity on another Apple wireless
> keyboard.
>
> NB: most likely all other APPLE_ALU_WIRELESS_*
> keyboards should be added as well.
>
> Cc: stable <at> kernel.org
> Signed-off-by: Ortwin Gl�ck <odi@odi.ch>
> ---
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read Documentation/stable_kernel_rules.txt
for how to do this properly.
</formletter>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-11-26 14:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-25 14:08 [PATCH] HID: hid-input: battery quirk for Apple keyboard Ortwin Glück
2012-11-25 14:13 ` devendra.aaru
2012-11-26 0:45 ` Ben Hutchings
2012-11-26 13:27 ` Jiri Kosina
-- strict thread matches above, loose matches on Subject: below --
2012-11-26 12:32 Ortwin Glück
2012-11-26 14:46 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox