* Mainline: Build error in drivers/nvdimm/pmem.c due to commit 658922e57b84
@ 2016-05-06 6:12 Guenter Roeck
2016-05-06 15:31 ` Dan Williams
0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2016-05-06 6:12 UTC (permalink / raw)
To: linux-kernel@vger.kernel.org; +Cc: Dan Williams, stable
alpha:allmodconfig fails to build with the following error.
drivers/nvdimm/pmem.c: In function 'nd_pfn_init':
drivers/nvdimm/pmem.c:407:17: error: 'HPAGE_SIZE' undeclared
Problem is due to commit 658922e57b84 ("libnvdimm, pfn: fix memmap
reservation sizing").
HPAGE_SIZE is not defined for all architectures and was up to now not used
in driver code. All other architectures with 64 bit physical address provide the
definition, though, as far as I can see, so it may be that only alpha is affected.
Since stable is copied - this will also result in stable build errors
if applied to -stable branches.
Guenter
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Mainline: Build error in drivers/nvdimm/pmem.c due to commit 658922e57b84
2016-05-06 6:12 Mainline: Build error in drivers/nvdimm/pmem.c due to commit 658922e57b84 Guenter Roeck
@ 2016-05-06 15:31 ` Dan Williams
0 siblings, 0 replies; 2+ messages in thread
From: Dan Williams @ 2016-05-06 15:31 UTC (permalink / raw)
To: Guenter Roeck; +Cc: linux-kernel@vger.kernel.org, stable
On Thu, May 5, 2016 at 11:12 PM, Guenter Roeck <guenter@roeck-us.net> wrote:
> alpha:allmodconfig fails to build with the following error.
>
> drivers/nvdimm/pmem.c: In function 'nd_pfn_init':
> drivers/nvdimm/pmem.c:407:17: error: 'HPAGE_SIZE' undeclared
>
> Problem is due to commit 658922e57b84 ("libnvdimm, pfn: fix memmap
> reservation sizing").
>
> HPAGE_SIZE is not defined for all architectures and was up to now not used
> in driver code. All other architectures with 64 bit physical address provide
> the
> definition, though, as far as I can see, so it may be that only alpha is
> affected.
>
> Since stable is copied - this will also result in stable build errors
> if applied to -stable branches.
Ah, sorry, I had only built alpha_defconfig before pushing that one.
I'll send a follow on fix, thanks for the report.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-06 15:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-06 6:12 Mainline: Build error in drivers/nvdimm/pmem.c due to commit 658922e57b84 Guenter Roeck
2016-05-06 15:31 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox