From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Felipe Balbi <felipe.balbi@linux.intel.com>, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2 3/3] xhci: Manually give back cancelled URB if queuing it for cancel fails
Date: Tue, 28 Mar 2017 13:30:31 +0300 [thread overview]
Message-ID: <58DA3B47.1000700@linux.intel.com> (raw)
In-Reply-To: <87y3vpj3q4.fsf@linux.intel.com>
On 28.03.2017 09:49, Felipe Balbi wrote:
>
> Hi,
>
> Mathias Nyman <mathias.nyman@linux.intel.com> writes:
>> On 27.03.2017 17:54, Felipe Balbi wrote:
>>>
>>> Hi,
>>>
>>> Mathias Nyman <mathias.nyman@linux.intel.com> writes:
>>>> Manually give back URB if we are can not add it to the cancel queue, and
>>>> stop the endpoint normally.
>>>
>>> this sentence doesn't parse very well ;-)
>>>
>>>> This can happen if device just reset before URB timed out and dequeued,
>>>> leading to missing endpoint ring.
>>>
>>> seems like this could be extended a bit too.
>>>
I'll clean up those commit messages, and modify patch 2/3 a bit to only touch
the error message and URB actual_length for endpoint stopped at status stage.
This way there is as little change going to usb-linus and stable as possible,
saving the reset for usb-next
-Mathias
prev parent reply other threads:[~2017-03-28 10:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1490624830-9761-1-git-send-email-mathias.nyman@linux.intel.com>
2017-03-27 14:27 ` [PATCH v2 2/3] xhci: Set URB actual length for stopped control transfers Mathias Nyman
2017-03-27 14:47 ` Felipe Balbi
2017-03-27 15:52 ` Mathias Nyman
2017-03-27 14:27 ` [PATCH v2 3/3] xhci: Manually give back cancelled URB if queuing it for cancel fails Mathias Nyman
2017-03-27 14:54 ` Felipe Balbi
2017-03-27 14:57 ` Felipe Balbi
2017-03-27 15:20 ` Mathias Nyman
2017-03-28 6:49 ` Felipe Balbi
2017-03-28 10:30 ` Mathias Nyman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58DA3B47.1000700@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox