Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Alan Jenkins <alan.christopher.jenkins@gmail.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Bart Van Assche <bart.vanassche@wdc.com>,
	stable@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: request for 4.14-stable: 1dc3039bc87a ("block: do not use interruptible wait anywhere")
Date: Fri, 20 Jul 2018 09:37:29 +0100	[thread overview]
Message-ID: <5f24dbd5-3c1d-9cab-eeca-467a4dd38a2d@gmail.com> (raw)
In-Reply-To: <20180719220936.wala6fa7st6q3xok@debian>

On 19/07/18 23:09, Sudip Mukherjee wrote:
> Hi Greg,
>
> This was missing in 4.14-stable. Please apply to your queue.
>
> --
> Regards
> Sudip

Hi Sudip,

This is correct, seems low-risk, and I don't mind it going ahead. But 
I'm curious� why you're interested in it for v4.14.� Mostly, I wonder if 
the same reason would apply to older kernels as well?

While the bugfix is applicable to v4.14, the nasty X crash on suspend is 
only on v4.15 and v4.16.� I think I left it to other's judgement, as to 
whether the bugfix would be wanted outside that case.

IIUC, the bugfix could be applied to *three* of the "longterm" kernel 
lines: 4.14.56, 4.9.113, 4.4.142.� Since the commit says this bug was 
introduced to the single-queue block layer in v4.4, commit 3ef28e8 
("block: generic request_queue reference counting").

Regards
Alan******

  parent reply	other threads:[~2018-07-20  9:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-19 22:09 request for 4.14-stable: 1dc3039bc87a ("block: do not use interruptible wait anywhere") Sudip Mukherjee
2018-07-20  7:26 ` Greg Kroah-Hartman
2018-07-20  8:37 ` Alan Jenkins [this message]
2018-07-20 10:26   ` Sudip Mukherjee
2018-07-20 11:09     ` Alan Jenkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f24dbd5-3c1d-9cab-eeca-467a4dd38a2d@gmail.com \
    --to=alan.christopher.jenkins@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=bart.vanassche@wdc.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=stable@vger.kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox