From: Arnd Bergmann <arnd@arndb.de>
To: Gabor Juhos <juhosg@openwrt.org>
Cc: Tejun Heo <tj@kernel.org>,
linux-ide@vger.kernel.org, Alban Bedel <albeu@free.fr>,
Ralf Baechle <ralf@linux-mips.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] pata-rb532-cf: get rid of the irq_to_gpio() call
Date: Thu, 18 Feb 2016 17:46:59 +0100 [thread overview]
Message-ID: <61574946.qI16Kz5bLp@wuerfel> (raw)
In-Reply-To: <1455710300-30920-1-git-send-email-juhosg@openwrt.org>
On Wednesday 17 February 2016 12:58:20 Gabor Juhos wrote:
> The RB532 platform specific irq_to_gpio() implementation has been
> removed with commit 832f5dacfa0b ("MIPS: Remove all the uses of
> custom gpio.h"). Now the platform uses the generic stub which causes
> the following error:
>
> pata-rb532-cf pata-rb532-cf: no GPIO found for irq149
> pata-rb532-cf: probe of pata-rb532-cf failed with error -2
>
> Drop the irq_to_gpio() call and get the GPIO number from platform
> data instead. After this change, the driver works again:
>
> scsi host0: pata-rb532-cf
> ata1: PATA max PIO4 irq 149
> ata1.00: CFA: CF 1GB, 20080820, max MWDMA4
> ata1.00: 1989792 sectors, multi 0: LBA
> ata1.00: configured for PIO4
> scsi 0:0:0:0: Direct-Access ATA CF 1GB 0820 PQ: 0\
> ANSI: 5
> sd 0:0:0:0: [sda] 1989792 512-byte logical blocks: (1.01 GB/971 MiB)
> sd 0:0:0:0: [sda] Write Protect is off
> sd 0:0:0:0: [sda] Write cache: disabled, read cache: enabled, doesn't\
> support DPO or FUA
> sda: sda1 sda2
> sd 0:0:0:0: [sda] Attached SCSI disk
>
> Fixes: 832f5dacfa0b ("MIPS: Remove all the uses of custom gpio.h")
> Cc: Alban Bedel <albeu@free.fr>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>
The patch looks good, but I now saw that drivers/pcmcia/db1xxx_ss.c
must have been broken by the same patch as this one, and it probably
needs a similar fix.
Arnd
prev parent reply other threads:[~2016-02-18 16:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 11:58 [PATCH] pata-rb532-cf: get rid of the irq_to_gpio() call Gabor Juhos
2016-02-17 12:40 ` Alban
2016-02-18 10:05 ` Gabor Juhos
2016-02-18 16:28 ` Tejun Heo
2016-02-18 16:46 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61574946.qI16Kz5bLp@wuerfel \
--to=arnd@arndb.de \
--cc=albeu@free.fr \
--cc=juhosg@openwrt.org \
--cc=linux-ide@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox