[PATCH] scsi: pm8001: add MODULE_AUTHOR entries for new contributors

[PATCH] scsi: pm8001: add MODULE_AUTHOR entries for new contributors

[Sagar Biradar]

Add MODULE_AUTHOR declarations for the developers who have
been actively working on the pm8001/pm80xx driver in recent years.

This helps properly credit the people involved in the ongoing
maintenance and the current upstreaming effort.

Signed-off-by: Sagar Biradar <sagar.biradar@microchip.com>
---
 drivers/scsi/pm8001/pm8001_init.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c
index e93ea76b565e..487f9bc237ef 100644
--- a/drivers/scsi/pm8001/pm8001_init.c
+++ b/drivers/scsi/pm8001/pm8001_init.c
@@ -1569,6 +1569,9 @@ MODULE_AUTHOR("Jack Wang <jack_wang@usish.com>");
 MODULE_AUTHOR("Anand Kumar Santhanam <AnandKumar.Santhanam@pmcs.com>");
 MODULE_AUTHOR("Sangeetha Gnanasekaran <Sangeetha.Gnanasekaran@pmcs.com>");
 MODULE_AUTHOR("Nikith Ganigarakoppal <Nikith.Ganigarakoppal@pmcs.com>");
+MODULE_AUTHOR("Abhinav Kuchibhotla <Abhinav.Kuchibhotla@microchip.com>");
+MODULE_AUTHOR("Kumar Meiyappan <Kumar.Meiyappan@microchip.com>");
+MODULE_AUTHOR("Sagar Biradar <Sagar.Biradar@microchip.com>");
 MODULE_DESCRIPTION(
 		"PMC-Sierra PM8001/8006/8081/8088/8089/8074/8076/8077/8070/8072 "
 		"SAS/SATA controller driver");
-- 
2.43.0

Re: [PATCH] scsi: pm8001: add MODULE_AUTHOR entries for new contributors

[Damien Le Moal]

On 4/22/26 06:22, Sagar Biradar wrote:
> Add MODULE_AUTHOR declarations for the developers who have
> been actively working on the pm8001/pm80xx driver in recent years.
> 
> This helps properly credit the people involved in the ongoing
> maintenance and the current upstreaming effort.
> 
> Signed-off-by: Sagar Biradar <sagar.biradar@microchip.com>

Well, if you go there, then you are really missing *a lot* of people.
Just run:

git shortlog -n -s -- drivers/scsi/pm8001

and see the ranking by number of commits.

So in the end, I really do not see the point of this patch since git log can
give a full (and correct) list of contributors.

> ---
>  drivers/scsi/pm8001/pm8001_init.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c
> index e93ea76b565e..487f9bc237ef 100644
> --- a/drivers/scsi/pm8001/pm8001_init.c
> +++ b/drivers/scsi/pm8001/pm8001_init.c
> @@ -1569,6 +1569,9 @@ MODULE_AUTHOR("Jack Wang <jack_wang@usish.com>");
>  MODULE_AUTHOR("Anand Kumar Santhanam <AnandKumar.Santhanam@pmcs.com>");
>  MODULE_AUTHOR("Sangeetha Gnanasekaran <Sangeetha.Gnanasekaran@pmcs.com>");
>  MODULE_AUTHOR("Nikith Ganigarakoppal <Nikith.Ganigarakoppal@pmcs.com>");
> +MODULE_AUTHOR("Abhinav Kuchibhotla <Abhinav.Kuchibhotla@microchip.com>");
> +MODULE_AUTHOR("Kumar Meiyappan <Kumar.Meiyappan@microchip.com>");
> +MODULE_AUTHOR("Sagar Biradar <Sagar.Biradar@microchip.com>");
>  MODULE_DESCRIPTION(
>  		"PMC-Sierra PM8001/8006/8081/8088/8089/8074/8076/8077/8070/8072 "
>  		"SAS/SATA controller driver");


-- 
Damien Le Moal
Western Digital Research

Re: [PATCH] scsi: pm8001: add MODULE_AUTHOR entries for new contributors

[Jinpu Wang]

On Fri, Apr 24, 2026 at 4:35 AM Damien Le Moal <dlemoal@kernel.org> wrote:
>
> On 4/22/26 06:22, Sagar Biradar wrote:
> > Add MODULE_AUTHOR declarations for the developers who have
> > been actively working on the pm8001/pm80xx driver in recent years.
> >
> > This helps properly credit the people involved in the ongoing
> > maintenance and the current upstreaming effort.
> >
> > Signed-off-by: Sagar Biradar <sagar.biradar@microchip.com>
>
> Well, if you go there, then you are really missing *a lot* of people.
> Just run:
>
> git shortlog -n -s -- drivers/scsi/pm8001
>
> and see the ranking by number of commits.
>
> So in the end, I really do not see the point of this patch since git log can
> give a full (and correct) list of contributors.
+1
>
> > ---
> >  drivers/scsi/pm8001/pm8001_init.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c
> > index e93ea76b565e..487f9bc237ef 100644
> > --- a/drivers/scsi/pm8001/pm8001_init.c
> > +++ b/drivers/scsi/pm8001/pm8001_init.c
> > @@ -1569,6 +1569,9 @@ MODULE_AUTHOR("Jack Wang <jack_wang@usish.com>");
> >  MODULE_AUTHOR("Anand Kumar Santhanam <AnandKumar.Santhanam@pmcs.com>");
> >  MODULE_AUTHOR("Sangeetha Gnanasekaran <Sangeetha.Gnanasekaran@pmcs.com>");
> >  MODULE_AUTHOR("Nikith Ganigarakoppal <Nikith.Ganigarakoppal@pmcs.com>");
> > +MODULE_AUTHOR("Abhinav Kuchibhotla <Abhinav.Kuchibhotla@microchip.com>");
> > +MODULE_AUTHOR("Kumar Meiyappan <Kumar.Meiyappan@microchip.com>");
> > +MODULE_AUTHOR("Sagar Biradar <Sagar.Biradar@microchip.com>");
> >  MODULE_DESCRIPTION(
> >               "PMC-Sierra PM8001/8006/8081/8088/8089/8074/8076/8077/8070/8072 "
> >               "SAS/SATA controller driver");
>
>
> --
> Damien Le Moal
> Western Digital Research

RE: [PATCH] scsi: pm8001: add MODULE_AUTHOR entries for new contributors

[Sagar.Biradar]

> -----Original Message-----
> From: Jinpu Wang <jinpu.wang@ionos.com>
> Sent: Thursday, April 23, 2026 11:00 PM
> To: Damien Le Moal <dlemoal@kernel.org>
> Cc: Sagar Biradar - C34249 <Sagar.Biradar@microchip.com>; Martin K. Petersen
> <martin.petersen@oracle.com>; James Bottomley
> <James.Bottomley@hansenpartnership.com>; linux-scsi <linux-
> scsi@vger.kernel.org>; stable@vger.kernel.org; Don Brace - C33706
> <Don.Brace@microchip.com>; Raja VS - C33522 <Raja.VS@microchip.com>;
> Kumar Meiyappan - C62069 <Kumar.Meiyappan@microchip.com>; Abhinav
> Kuchibhotla - C70322 <Abhinav.Kuchibhotla@microchip.com>; Uday kumar
> Bagam - C74375 <Udaykumar.Bagam@microchip.com>; Advait Churi - C72763
> <Advait.Churi@microchip.com>
> Subject: Re: [PATCH] scsi: pm8001: add MODULE_AUTHOR entries for new
> contributors
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> On Fri, Apr 24, 2026 at 4:35 AM Damien Le Moal <dlemoal@kernel.org> wrote:
> >
> > On 4/22/26 06:22, Sagar Biradar wrote:
> > > Add MODULE_AUTHOR declarations for the developers who have
> > > been actively working on the pm8001/pm80xx driver in recent years.
> > >
> > > This helps properly credit the people involved in the ongoing
> > > maintenance and the current upstreaming effort.
> > >
> > > Signed-off-by: Sagar Biradar <sagar.biradar@microchip.com>
> >
> > Well, if you go there, then you are really missing *a lot* of people.
> > Just run:
> >
> > git shortlog -n -s -- drivers/scsi/pm8001
> >
> > and see the ranking by number of commits.
> >
> > So in the end, I really do not see the point of this patch since git log can
> > give a full (and correct) list of contributors.
> +1
> >
Hi Damien/Jinpu,
Thanks for your review and for pointing this out. I value them.
The intent was to make the current Microchip-side points of contact for the pm8001/pm80xx driver more visible,  since Microchip owns the hardware and we plan to send more changes upstream.
It was not meant to overlook or displace the existing contributors.

I now see that MODULE_AUTHOR() is not the right mechanism for this since git history already captures the contributor record accurately. I’ll drop this patch.

We’ll look at a MAINTAINERS update separately if/when appropriate.
Thanks again

> > > ---
> > >  drivers/scsi/pm8001/pm8001_init.c | 3 +++
> > >  1 file changed, 3 insertions(+)
> > >
> > > diff --git a/drivers/scsi/pm8001/pm8001_init.c
> b/drivers/scsi/pm8001/pm8001_init.c
> > > index e93ea76b565e..487f9bc237ef 100644
> > > --- a/drivers/scsi/pm8001/pm8001_init.c
> > > +++ b/drivers/scsi/pm8001/pm8001_init.c
> > > @@ -1569,6 +1569,9 @@ MODULE_AUTHOR("Jack Wang
> <jack_wang@usish.com>");
> > >  MODULE_AUTHOR("Anand Kumar Santhanam
> <AnandKumar.Santhanam@pmcs.com>");
> > >  MODULE_AUTHOR("Sangeetha Gnanasekaran
> <Sangeetha.Gnanasekaran@pmcs.com>");
> > >  MODULE_AUTHOR("Nikith Ganigarakoppal
> <Nikith.Ganigarakoppal@pmcs.com>");
> > > +MODULE_AUTHOR("Abhinav Kuchibhotla
> <Abhinav.Kuchibhotla@microchip.com>");
> > > +MODULE_AUTHOR("Kumar Meiyappan
> <Kumar.Meiyappan@microchip.com>");
> > > +MODULE_AUTHOR("Sagar Biradar <Sagar.Biradar@microchip.com>");
> > >  MODULE_DESCRIPTION(
> > >               "PMC-Sierra
> PM8001/8006/8081/8088/8089/8074/8076/8077/8070/8072 "
> > >               "SAS/SATA controller driver");
> >
> >
> > --
> > Damien Le Moal
> > Western Digital Research