From: Krzysztof Kozlowski <krzk@kernel.org>
To: Umang Jain <umang.jain@ideasonboard.com>, linux-media@vger.kernel.org
Cc: stable@vger.kernel.org,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Tommaso Merciai <tomm.merciai@gmail.com>,
Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: imx335: Mention reset-gpio polarity
Date: Mon, 29 Jul 2024 16:08:18 +0200 [thread overview]
Message-ID: <7537c281-2f0d-43e1-9260-2d469d5a1f21@kernel.org> (raw)
In-Reply-To: <20240729110437.199428-2-umang.jain@ideasonboard.com>
On 29/07/2024 13:04, Umang Jain wrote:
> Mention the reset-gpio polarity in the device tree bindings.
> It is GPIO_ACTIVE_LOW according to the datasheet.
>
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
> ---
IdeasOnBoard folks are seasoned developers, although I noticed from time
to time you do not cc all necessary addresses. I wonder why? Something
is missing in internal guideline?
That's not the first case, but pasting same form letter is a bit
annoying, especially considering that *tools tell you to do correct
stuff* and you do not need *person to tell you that*.
<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.
You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.
Please kindly resend and include all necessary To/Cc entries.
</form letter>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-29 14:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 11:04 [PATCH v2 0/2] media: imx335: Fix reset-gpio handling Umang Jain
2024-07-29 11:04 ` [PATCH v2 1/2] dt-bindings: imx335: Mention reset-gpio polarity Umang Jain
2024-07-29 11:10 ` Laurent Pinchart
2024-07-29 12:06 ` Umang Jain
2024-07-29 14:27 ` Laurent Pinchart
2024-07-29 13:14 ` kernel test robot
2024-07-29 14:08 ` Krzysztof Kozlowski [this message]
2024-07-29 14:20 ` Laurent Pinchart
2024-07-29 11:04 ` [PATCH v2 2/2] media: imx335: Fix reset-gpio handling Umang Jain
2024-07-29 11:13 ` Laurent Pinchart
2024-07-30 8:17 ` Sakari Ailus
2024-07-29 14:09 ` Krzysztof Kozlowski
2024-07-30 8:24 ` Sakari Ailus
2024-07-30 8:42 ` Krzysztof Kozlowski
2024-07-30 9:10 ` Laurent Pinchart
2024-07-31 5:41 ` Umang Jain
2024-07-31 9:02 ` Kieran Bingham
2024-07-31 9:06 ` Krzysztof Kozlowski
2024-07-31 9:39 ` Laurent Pinchart
2024-08-01 16:09 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7537c281-2f0d-43e1-9260-2d469d5a1f21@kernel.org \
--to=krzk@kernel.org \
--cc=jacopo.mondi@ideasonboard.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=tomm.merciai@gmail.com \
--cc=umang.jain@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox