From: Krzysztof Kozlowski <krzk@kernel.org>
To: Umang Jain <umang.jain@ideasonboard.com>, linux-media@vger.kernel.org
Cc: stable@vger.kernel.org,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Tommaso Merciai <tomm.merciai@gmail.com>,
Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v2 2/2] media: imx335: Fix reset-gpio handling
Date: Mon, 29 Jul 2024 16:09:39 +0200 [thread overview]
Message-ID: <ef05c39a-ad5c-4751-a758-f73a2d114823@kernel.org> (raw)
In-Reply-To: <20240729110437.199428-3-umang.jain@ideasonboard.com>
On 29/07/2024 13:04, Umang Jain wrote:
> Rectify the logical value of reset-gpio so that it is set to
> 0 (disabled) during power-on and to 1 (enabled) during power-off.
>
> Meanwhile at it, set the reset-gpio to GPIO_OUT_HIGH at initialization
> time to make sure it starts off in reset.
>
> Fixes: 45d19b5fb9ae ("media: i2c: Add imx335 camera sensor driver")
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
> ---
> drivers/media/i2c/imx335.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
This will break all the users, so no. At least not without mentioning
ABI break and some sort of investigating how customers or users are
affected.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-29 14:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 11:04 [PATCH v2 0/2] media: imx335: Fix reset-gpio handling Umang Jain
2024-07-29 11:04 ` [PATCH v2 1/2] dt-bindings: imx335: Mention reset-gpio polarity Umang Jain
2024-07-29 11:10 ` Laurent Pinchart
2024-07-29 12:06 ` Umang Jain
2024-07-29 14:27 ` Laurent Pinchart
2024-07-29 13:14 ` kernel test robot
2024-07-29 14:08 ` Krzysztof Kozlowski
2024-07-29 14:20 ` Laurent Pinchart
2024-07-29 11:04 ` [PATCH v2 2/2] media: imx335: Fix reset-gpio handling Umang Jain
2024-07-29 11:13 ` Laurent Pinchart
2024-07-30 8:17 ` Sakari Ailus
2024-07-29 14:09 ` Krzysztof Kozlowski [this message]
2024-07-30 8:24 ` Sakari Ailus
2024-07-30 8:42 ` Krzysztof Kozlowski
2024-07-30 9:10 ` Laurent Pinchart
2024-07-31 5:41 ` Umang Jain
2024-07-31 9:02 ` Kieran Bingham
2024-07-31 9:06 ` Krzysztof Kozlowski
2024-07-31 9:39 ` Laurent Pinchart
2024-08-01 16:09 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef05c39a-ad5c-4751-a758-f73a2d114823@kernel.org \
--to=krzk@kernel.org \
--cc=jacopo.mondi@ideasonboard.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=tomm.merciai@gmail.com \
--cc=umang.jain@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox