Re: [PATCH] arm64: dts: qcom: hamoa-iot-evk: Enable retimer on USB0 port

[Prashanth K <prashanth.k@oss.qualcomm.com>]

On 4/22/2026 4:13 PM, Konrad Dybcio wrote:
> On 4/22/26 12:32 PM, Prashanth K wrote:
>>
>>
>> On 4/22/2026 3:56 PM, Konrad Dybcio wrote:
>>> On 4/22/26 11:39 AM, Prashanth K wrote:
>>>> Add the retimer for usb_1_ss0 port (USB0), in order to enable
>>>> super-speed enumeration on that port.
>>>>
>>>> Fixes: c11645afb0e2 ("arm64: dts: qcom: Add base HAMOA-IOT-EVK board")
>>>> Cc: stable@vger.kernel.org
>>>
>>> This is a feature addition, not a fix
>>>
>>> [...]
>>>
>> Sure.
>>>> +		ports {
>>>> +			#address-cells = <1>;
>>>> +			#size-cells = <0>;
>>>> +
>>>> +			port@0 {
>>>> +				reg = <0>;
>>>> +
>>>> +				retimer_ss0_ss_out: endpoint {
>>>> +					remote-endpoint = <&pmic_glink_ss0_ss_in>;
>>>> +				};
>>>> +			};
>>>> +
>>>> +			port@1 {
>>>> +				reg = <1>;
>>>> +
>>>> +				retimer_ss0_ss_in: endpoint {
>>>> +					remote-endpoint = <&usb_1_ss0_qmpphy_out>;
>>>> +				};
>>>> +			};
>>>> +
>>>
>>> Stray \n, but you should really have a @2 port here as well.
>>>
>>> Konrad
>> Can we ad port@2 and leave it empty?
> 
> Why would you? Just connect it to port2 of the connector under pmic-glink
> 
> Konrad

Because the port@2 of pmic-glink (pmic_glink_ss0_sbu) is already
connected to usb-1-ss0-sbu-mux (onn,fsusb42). This is different compared
to other connectors.

Regards,
Prashanth K