public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Prashanth K <prashanth.k@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: hamoa-iot-evk: Enable retimer on USB0 port
Date: Wed, 22 Apr 2026 16:02:40 +0530	[thread overview]
Message-ID: <8cb5e28c-1c6e-450e-855b-32491ee73885@oss.qualcomm.com> (raw)
In-Reply-To: <6c2c5fd6-c032-4658-9a15-039c77074c4b@oss.qualcomm.com>



On 4/22/2026 3:56 PM, Konrad Dybcio wrote:
> On 4/22/26 11:39 AM, Prashanth K wrote:
>> Add the retimer for usb_1_ss0 port (USB0), in order to enable
>> super-speed enumeration on that port.
>>
>> Fixes: c11645afb0e2 ("arm64: dts: qcom: Add base HAMOA-IOT-EVK board")
>> Cc: stable@vger.kernel.org
> 
> This is a feature addition, not a fix
> 
> [...]
> 
Sure.
>> +		ports {
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +
>> +			port@0 {
>> +				reg = <0>;
>> +
>> +				retimer_ss0_ss_out: endpoint {
>> +					remote-endpoint = <&pmic_glink_ss0_ss_in>;
>> +				};
>> +			};
>> +
>> +			port@1 {
>> +				reg = <1>;
>> +
>> +				retimer_ss0_ss_in: endpoint {
>> +					remote-endpoint = <&usb_1_ss0_qmpphy_out>;
>> +				};
>> +			};
>> +
> 
> Stray \n, but you should really have a @2 port here as well.
> 
> Konrad
Can we ad port@2 and leave it empty?

Regards,
Prashanth K

  reply	other threads:[~2026-04-22 10:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-22  9:39 [PATCH] arm64: dts: qcom: hamoa-iot-evk: Enable retimer on USB0 port Prashanth K
2026-04-22 10:26 ` Konrad Dybcio
2026-04-22 10:32   ` Prashanth K [this message]
2026-04-22 10:43     ` Konrad Dybcio
2026-04-22 11:04       ` Prashanth K
2026-04-22 11:09         ` Konrad Dybcio
2026-04-22 11:52           ` Dmitry Baryshkov
  -- strict thread matches above, loose matches on Subject: below --
2026-04-22  9:06 Prashanth K

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8cb5e28c-1c6e-450e-855b-32491ee73885@oss.qualcomm.com \
    --to=prashanth.k@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krishna.kurapati@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox