Re: [PATCH v3] virtio_vsock: Fix race condition in virtio_transport_recv_pkt()

Re: [PATCH v3] virtio_vsock: Fix race condition in virtio_transport_recv_pkt()

[Markus Elfring]

> This fixes it by checking sk->sk_shutdown(suggested by Stefano) after
> lock_sock since sk->sk_shutdown is set to SHUTDOWN_MASK under the
> protection of lock_sock_nested.

How do you think about a wording variant like the following?

  Thus check the data structure member “sk_shutdown” (suggested by Stefano)
  after a call of the function “lock_sock” since this field is set to
  “SHUTDOWN_MASK” under the protection of “lock_sock_nested”.


Would you like to add the tag “Fixes” to the commit message?

Regards,
Markus

RE: [PATCH v3] virtio_vsock: Fix race condition in virtio_transport_recv_pkt()

[Justin He]

Hi Markus

> -----Original Message-----
> From: Markus Elfring <Markus.Elfring@web.de>
> Sent: Saturday, May 30, 2020 6:41 PM
> To: Justin He <Justin.He@arm.com>; kvm@vger.kernel.org;
> netdev@vger.kernel.org; virtualization@lists.linux-foundation.org
> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org;
> stable@vger.kernel.org; David S. Miller <davem@davemloft.net>; Jakub
> Kicinski <kuba@kernel.org>; Kaly Xin <Kaly.Xin@arm.com>; Stefan Hajnoczi
> <stefanha@redhat.com>; Stefano Garzarella <sgarzare@redhat.com>
> Subject: Re: [PATCH v3] virtio_vsock: Fix race condition in
> virtio_transport_recv_pkt()
>
> > This fixes it by checking sk->sk_shutdown(suggested by Stefano) after
> > lock_sock since sk->sk_shutdown is set to SHUTDOWN_MASK under the
> > protection of lock_sock_nested.
>
> How do you think about a wording variant like the following?
>
>   Thus check the data structure member “sk_shutdown” (suggested by Stefano)
>   after a call of the function “lock_sock” since this field is set to
>   “SHUTDOWN_MASK” under the protection of “lock_sock_nested”.
>
Okay, will update the commit msg.

>
> Would you like to add the tag “Fixes” to the commit message?
Sure.

Thanks


--
Cheers,
Justin (Jia He)


>
> Regards,
> Markus
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.