Re: [PATCH 4.19] iwlwifi: mvm: Send LQ command as async when necessary

[Luciano Coelho <luciano.coelho@intel.com>]

On Thu, 2019-01-24 at 18:50 +0100, Greg KH wrote:
> On Thu, Jan 24, 2019 at 10:47:12AM +0200, Luciano Coelho wrote:
> > Hi Greg,
> > 
> > This patch fixes a few bugs reported in bugzilla, about scheduling
> > while atomic.  There were at least 4 reports[1], so it seems to be
> > a
> > common occurrence.
> > 
> > The patch looks large, but it's basically just a new boolean been
> > passed around in order to decide whether we send a message
> > synchronously or not.
> > 
> > Is it possible to queue it for 4.19.y?
> > 
> > [1] https://bugzilla.kernel.org/show_bug.cgi?id=200991
> >     https://bugzilla.kernel.org/show_bug.cgi?id=202219
> >     https://bugzilla.kernel.org/show_bug.cgi?id=201297
> >     https://bugzilla.kernel.org/show_bug.cgi?id=201355
> 
> Now queued up, thanks.

Thanks, Greg!


> Note, apis that add "booleans" to them are horrid, good luck
> maintaining that mess :(

Yeah, you're right.  This patch demonstrates that, the boolean needs to
be passed from and to everywhere.  We should probably just split that
function in two.  Thanks for the comment.

--
Cheers,
Luca.