From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: "Jisheng Zhang" <Jisheng.Zhang@synaptics.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Adrian Hunter" <adrian.hunter@intel.com>,
linux-mmc@vger.kernel.org, "Andrew Lunn" <andrew@lunn.ch>,
"Yehuda Yitschak" <yehuday@marvell.com>,
"Jason Cooper" <jason@lakedaemon.net>,
"Antoine Tenart" <antoine.tenart@free-electrons.com>,
"Omri Itach" <omrii@marvell.com>, Stable <stable@vger.kernel.org>,
"Nadav Haklai" <nadavh@marvell.com>,
"Shadi Ammouri" <shadi@marvell.com>,
"Igal Liberman" <igall@marvell.com>,
"Miquèl Raynal" <miquel.raynal@free-electrons.com>,
"Marcin Wojtas" <mw@semihalf.com>,
"Hanna Hawa" <hannah@marvell.com>,
linux-arm-kernel@lists.infradead.org,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH] mmc: sdhci-xenon: Fix clock resource by adding an optional bus clock
Date: Fri, 29 Sep 2017 11:22:05 +0200 [thread overview]
Message-ID: <87bmlthnb6.fsf@free-electrons.com> (raw)
In-Reply-To: <20170929111550.065e7948@windsurf.lan> (Thomas Petazzoni's message of "Fri, 29 Sep 2017 11:15:50 +0200")
Hi Thomas,
On ven., sept. 29 2017, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Fri, 29 Sep 2017 11:13:00 +0200, Gregory CLEMENT wrote:
>
>> >> - clock-names:
>> >> Array of names corresponding to clocks property.
>> >> The input clock for Xenon IP core should be named as "core".
>> >> + The input clock for the AXI bus must be named as "axi".
>> >
>> > Is "bus" more suitable?
>>
>> I find bus too vague.
>
> Actually no, I believe "bus" is more common. Indeed, you could have the
> same IP, attached to a different interconnect I guess.
>
>> >> /*
>> >> * Link Xenon specific mmc_host_ops function,
>> >> @@ -491,9 +493,20 @@ static int xenon_probe(struct platform_device *pdev)
>> >> if (err)
>> >> goto free_pltfm;
>> >>
>> >> + priv->axi_clk = devm_clk_get(&pdev->dev, "axi");
>> >> + if (IS_ERR(priv->axi_clk)) {
>
> -EPROBE_DEFER handling ?
See
http://lists.infradead.org/pipermail/linux-arm-kernel/2017-September/533510.html
Gregory
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2017-09-29 9:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 15:05 [PATCH] mmc: sdhci-xenon: Fix clock resource by adding an optional bus clock Gregory CLEMENT
2017-09-28 15:57 ` Gregory CLEMENT
2017-09-29 2:39 ` Jisheng Zhang
2017-09-29 9:13 ` Gregory CLEMENT
2017-09-29 9:15 ` Thomas Petazzoni
2017-09-29 9:22 ` Gregory CLEMENT [this message]
2017-09-30 2:47 ` Ziji Hu
2017-09-30 2:56 ` Jisheng Zhang
-- strict thread matches above, loose matches on Subject: below --
2017-10-12 16:13 Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmlthnb6.fsf@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=Jisheng.Zhang@synaptics.com \
--cc=adrian.hunter@intel.com \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=hannah@marvell.com \
--cc=igall@marvell.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=miquel.raynal@free-electrons.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=omrii@marvell.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=shadi@marvell.com \
--cc=stable@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
--cc=ulf.hansson@linaro.org \
--cc=yehuday@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox