* [PATCH v5.15 1/1] Kconfig.debug: provide a little extra FRAME_WARN leeway when KASAN is enabled
@ 2022-12-06 12:42 Lee Jones
2022-12-06 12:50 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Lee Jones @ 2022-12-06 12:42 UTC (permalink / raw)
To: lee
Cc: stable, Arnd Bergmann, Alex Deucher, Christian König,
Daniel Vetter, David Airlie, Harry Wentland, Leo Li,
Maarten Lankhorst, Maxime Ripard, Nathan Chancellor,
Nick Desaulniers, Pan, Xinhui, Rodrigo Siqueira,
Thomas Zimmermann, Tom Rix, Andrew Morton
commit 152fe65f300e1819d59b80477d3e0999b4d5d7d2 upstream.
When enabled, KASAN enlarges function's stack-frames. Pushing quite a few
over the current threshold. This can mainly be seen on 32-bit
architectures where the present limit (when !GCC) is a lowly 1024-Bytes.
Link: https://lkml.kernel.org/r/20221125120750.3537134-3-lee@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: David Airlie <airlied@gmail.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Leo Li <sunpeng.li@amd.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Nathan Chancellor <nathan@kernel.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Tom Rix <trix@redhat.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
[Lee: Back-ported to linux-5.15.y]
Signed-off-by: Lee Jones <lee@kernel.org>
---
lib/Kconfig.debug | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 1699b21245586..cfbadc7c919d8 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -353,6 +353,7 @@ config FRAME_WARN
range 0 8192
default 2048 if GCC_PLUGIN_LATENT_ENTROPY
default 1536 if (!64BIT && (PARISC || XTENSA))
+ default 1280 if KASAN && !64BIT
default 1024 if (!64BIT && !PARISC)
default 2048 if 64BIT
help
--
2.39.0.rc0.267.gcb52ba06e7-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v5.15 1/1] Kconfig.debug: provide a little extra FRAME_WARN leeway when KASAN is enabled
2022-12-06 12:42 [PATCH v5.15 1/1] Kconfig.debug: provide a little extra FRAME_WARN leeway when KASAN is enabled Lee Jones
@ 2022-12-06 12:50 ` Greg KH
2022-12-06 14:00 ` Lee Jones
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2022-12-06 12:50 UTC (permalink / raw)
To: Lee Jones
Cc: stable, Arnd Bergmann, Alex Deucher, Christian König,
Daniel Vetter, David Airlie, Harry Wentland, Leo Li,
Maarten Lankhorst, Maxime Ripard, Nathan Chancellor,
Nick Desaulniers, Pan, Xinhui, Rodrigo Siqueira,
Thomas Zimmermann, Tom Rix, Andrew Morton
On Tue, Dec 06, 2022 at 12:42:23PM +0000, Lee Jones wrote:
> commit 152fe65f300e1819d59b80477d3e0999b4d5d7d2 upstream.
>
> When enabled, KASAN enlarges function's stack-frames. Pushing quite a few
> over the current threshold. This can mainly be seen on 32-bit
> architectures where the present limit (when !GCC) is a lowly 1024-Bytes.
>
> Link: https://lkml.kernel.org/r/20221125120750.3537134-3-lee@kernel.org
> Signed-off-by: Lee Jones <lee@kernel.org>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Nathan Chancellor <nathan@kernel.org>
> Cc: Nick Desaulniers <ndesaulniers@google.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Tom Rix <trix@redhat.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> [Lee: Back-ported to linux-5.15.y]
> Signed-off-by: Lee Jones <lee@kernel.org>
This is already in the -rc1 releases of 5.15 (and 5.10) that went out
yesterday, right?
Or is that version not correct somehow?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v5.15 1/1] Kconfig.debug: provide a little extra FRAME_WARN leeway when KASAN is enabled
2022-12-06 12:50 ` Greg KH
@ 2022-12-06 14:00 ` Lee Jones
2022-12-06 15:59 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Lee Jones @ 2022-12-06 14:00 UTC (permalink / raw)
To: Greg KH
Cc: stable, Arnd Bergmann, Alex Deucher, Christian König,
Daniel Vetter, David Airlie, Harry Wentland, Leo Li,
Maarten Lankhorst, Maxime Ripard, Nathan Chancellor,
Nick Desaulniers, Pan, Xinhui, Rodrigo Siqueira,
Thomas Zimmermann, Tom Rix, Andrew Morton
On Tue, 06 Dec 2022, Greg KH wrote:
> On Tue, Dec 06, 2022 at 12:42:23PM +0000, Lee Jones wrote:
> > commit 152fe65f300e1819d59b80477d3e0999b4d5d7d2 upstream.
> >
> > When enabled, KASAN enlarges function's stack-frames. Pushing quite a few
> > over the current threshold. This can mainly be seen on 32-bit
> > architectures where the present limit (when !GCC) is a lowly 1024-Bytes.
> >
> > Link: https://lkml.kernel.org/r/20221125120750.3537134-3-lee@kernel.org
> > Signed-off-by: Lee Jones <lee@kernel.org>
> > Acked-by: Arnd Bergmann <arnd@arndb.de>
> > Cc: Alex Deucher <alexander.deucher@amd.com>
> > Cc: "Christian König" <christian.koenig@amd.com>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: David Airlie <airlied@gmail.com>
> > Cc: Harry Wentland <harry.wentland@amd.com>
> > Cc: Leo Li <sunpeng.li@amd.com>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Maxime Ripard <mripard@kernel.org>
> > Cc: Nathan Chancellor <nathan@kernel.org>
> > Cc: Nick Desaulniers <ndesaulniers@google.com>
> > Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> > Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> > Cc: Thomas Zimmermann <tzimmermann@suse.de>
> > Cc: Tom Rix <trix@redhat.com>
> > Cc: <stable@vger.kernel.org>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> > [Lee: Back-ported to linux-5.15.y]
> > Signed-off-by: Lee Jones <lee@kernel.org>
>
> This is already in the -rc1 releases of 5.15 (and 5.10) that went out
> yesterday, right?
>
> Or is that version not correct somehow?
Did you fix the back-port already? I was working on the back of:
FAILED: patch "[PATCH] Kconfig.debug: provide a little extra FRAME_WARN leeway when" failed to apply to 5.10-stable tree
FAILED: patch "[PATCH] Kconfig.debug: provide a little extra FRAME_WARN leeway when" failed to apply to 5.15-stable tree
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v5.15 1/1] Kconfig.debug: provide a little extra FRAME_WARN leeway when KASAN is enabled
2022-12-06 14:00 ` Lee Jones
@ 2022-12-06 15:59 ` Greg KH
2022-12-06 16:13 ` Lee Jones
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2022-12-06 15:59 UTC (permalink / raw)
To: Lee Jones
Cc: stable, Arnd Bergmann, Alex Deucher, Christian König,
Daniel Vetter, David Airlie, Harry Wentland, Leo Li,
Maarten Lankhorst, Maxime Ripard, Nathan Chancellor,
Nick Desaulniers, Pan, Xinhui, Rodrigo Siqueira,
Thomas Zimmermann, Tom Rix, Andrew Morton
On Tue, Dec 06, 2022 at 02:00:56PM +0000, Lee Jones wrote:
> On Tue, 06 Dec 2022, Greg KH wrote:
>
> > On Tue, Dec 06, 2022 at 12:42:23PM +0000, Lee Jones wrote:
> > > commit 152fe65f300e1819d59b80477d3e0999b4d5d7d2 upstream.
> > >
> > > When enabled, KASAN enlarges function's stack-frames. Pushing quite a few
> > > over the current threshold. This can mainly be seen on 32-bit
> > > architectures where the present limit (when !GCC) is a lowly 1024-Bytes.
> > >
> > > Link: https://lkml.kernel.org/r/20221125120750.3537134-3-lee@kernel.org
> > > Signed-off-by: Lee Jones <lee@kernel.org>
> > > Acked-by: Arnd Bergmann <arnd@arndb.de>
> > > Cc: Alex Deucher <alexander.deucher@amd.com>
> > > Cc: "Christian König" <christian.koenig@amd.com>
> > > Cc: Daniel Vetter <daniel@ffwll.ch>
> > > Cc: David Airlie <airlied@gmail.com>
> > > Cc: Harry Wentland <harry.wentland@amd.com>
> > > Cc: Leo Li <sunpeng.li@amd.com>
> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > > Cc: Maxime Ripard <mripard@kernel.org>
> > > Cc: Nathan Chancellor <nathan@kernel.org>
> > > Cc: Nick Desaulniers <ndesaulniers@google.com>
> > > Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> > > Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> > > Cc: Thomas Zimmermann <tzimmermann@suse.de>
> > > Cc: Tom Rix <trix@redhat.com>
> > > Cc: <stable@vger.kernel.org>
> > > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> > > [Lee: Back-ported to linux-5.15.y]
> > > Signed-off-by: Lee Jones <lee@kernel.org>
> >
> > This is already in the -rc1 releases of 5.15 (and 5.10) that went out
> > yesterday, right?
> >
> > Or is that version not correct somehow?
>
> Did you fix the back-port already? I was working on the back of:
>
> FAILED: patch "[PATCH] Kconfig.debug: provide a little extra FRAME_WARN leeway when" failed to apply to 5.10-stable tree
> FAILED: patch "[PATCH] Kconfig.debug: provide a little extra FRAME_WARN leeway when" failed to apply to 5.15-stable tree
Sasha seems to have already fixed it, look at the -rc releases for the
backports.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v5.15 1/1] Kconfig.debug: provide a little extra FRAME_WARN leeway when KASAN is enabled
2022-12-06 15:59 ` Greg KH
@ 2022-12-06 16:13 ` Lee Jones
0 siblings, 0 replies; 5+ messages in thread
From: Lee Jones @ 2022-12-06 16:13 UTC (permalink / raw)
To: Greg KH
Cc: stable, Arnd Bergmann, Alex Deucher, Christian König,
Daniel Vetter, David Airlie, Harry Wentland, Leo Li,
Maarten Lankhorst, Maxime Ripard, Nathan Chancellor,
Nick Desaulniers, Pan, Xinhui, Rodrigo Siqueira,
Thomas Zimmermann, Tom Rix, Andrew Morton
On Tue, 06 Dec 2022, Greg KH wrote:
> On Tue, Dec 06, 2022 at 02:00:56PM +0000, Lee Jones wrote:
> > On Tue, 06 Dec 2022, Greg KH wrote:
> >
> > > On Tue, Dec 06, 2022 at 12:42:23PM +0000, Lee Jones wrote:
> > > > commit 152fe65f300e1819d59b80477d3e0999b4d5d7d2 upstream.
> > > >
> > > > When enabled, KASAN enlarges function's stack-frames. Pushing quite a few
> > > > over the current threshold. This can mainly be seen on 32-bit
> > > > architectures where the present limit (when !GCC) is a lowly 1024-Bytes.
> > > >
> > > > Link: https://lkml.kernel.org/r/20221125120750.3537134-3-lee@kernel.org
> > > > Signed-off-by: Lee Jones <lee@kernel.org>
> > > > Acked-by: Arnd Bergmann <arnd@arndb.de>
> > > > Cc: Alex Deucher <alexander.deucher@amd.com>
> > > > Cc: "Christian König" <christian.koenig@amd.com>
> > > > Cc: Daniel Vetter <daniel@ffwll.ch>
> > > > Cc: David Airlie <airlied@gmail.com>
> > > > Cc: Harry Wentland <harry.wentland@amd.com>
> > > > Cc: Leo Li <sunpeng.li@amd.com>
> > > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > > > Cc: Maxime Ripard <mripard@kernel.org>
> > > > Cc: Nathan Chancellor <nathan@kernel.org>
> > > > Cc: Nick Desaulniers <ndesaulniers@google.com>
> > > > Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> > > > Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> > > > Cc: Thomas Zimmermann <tzimmermann@suse.de>
> > > > Cc: Tom Rix <trix@redhat.com>
> > > > Cc: <stable@vger.kernel.org>
> > > > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> > > > [Lee: Back-ported to linux-5.15.y]
> > > > Signed-off-by: Lee Jones <lee@kernel.org>
> > >
> > > This is already in the -rc1 releases of 5.15 (and 5.10) that went out
> > > yesterday, right?
> > >
> > > Or is that version not correct somehow?
> >
> > Did you fix the back-port already? I was working on the back of:
> >
> > FAILED: patch "[PATCH] Kconfig.debug: provide a little extra FRAME_WARN leeway when" failed to apply to 5.10-stable tree
> > FAILED: patch "[PATCH] Kconfig.debug: provide a little extra FRAME_WARN leeway when" failed to apply to 5.15-stable tree
>
> Sasha seems to have already fixed it, look at the -rc releases for the
> backports.
Works for me. Thank you Sasha.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-12-06 16:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-06 12:42 [PATCH v5.15 1/1] Kconfig.debug: provide a little extra FRAME_WARN leeway when KASAN is enabled Lee Jones
2022-12-06 12:50 ` Greg KH
2022-12-06 14:00 ` Lee Jones
2022-12-06 15:59 ` Greg KH
2022-12-06 16:13 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox