From: Sasha Levin <sashal@kernel.org>
To: Alexander Ovechkin <ovov@yandex-team.ru>
Cc: stable@vger.kernel.org, edumazet@google.com, davem@davemloft.net,
zeil@yandex-team.ru, dmtrmonakhov@yandex-team.ru,
olegsenin@yandex-team.ru
Subject: Re: [PATCH 4.19] tcp: relookup sock for RST+ACK packets handled by obsolete req sock
Date: Tue, 30 Mar 2021 12:56:41 -0400 [thread overview]
Message-ID: <YGNYSaHYUI8YmbNW@sashalap> (raw)
In-Reply-To: <20210329175541.150651-1-ovov@yandex-team.ru>
On Mon, Mar 29, 2021 at 08:55:41PM +0300, Alexander Ovechkin wrote:
>commit 7233da86697efef41288f8b713c10c2499cffe85 upstream.
>
>Currently tcp_check_req can be called with obsolete req socket for which big
>socket have been already created (because of CPU race or early demux
>assigning req socket to multiple packets in gro batch).
>
>Commit e0f9759f530bf789e984 ("tcp: try to keep packet if SYN_RCV race
>is lost") added retry in case when tcp_check_req is called for PSH|ACK packet.
>But if client sends RST+ACK immediatly after connection being
>established (it is performing healthcheck, for example) retry does not
>occur. In that case tcp_check_req tries to close req socket,
>leaving big socket active.
>
>Fixes: e0f9759f530b ("tcp: try to keep packet if SYN_RCV race is lost")
>Signed-off-by: Alexander Ovechkin <ovov@yandex-team.ru>
>Reported-by: Oleg Senin <olegsenin@yandex-team.ru>
Queued up, thanks!
--
Thanks,
Sasha
prev parent reply other threads:[~2021-03-30 16:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 17:55 [PATCH 4.19] tcp: relookup sock for RST+ACK packets handled by obsolete req sock Alexander Ovechkin
2021-03-30 16:56 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGNYSaHYUI8YmbNW@sashalap \
--to=sashal@kernel.org \
--cc=davem@davemloft.net \
--cc=dmtrmonakhov@yandex-team.ru \
--cc=edumazet@google.com \
--cc=olegsenin@yandex-team.ru \
--cc=ovov@yandex-team.ru \
--cc=stable@vger.kernel.org \
--cc=zeil@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox