* Re: [PATCH 1/1] rtc: pcf85063: fallback to parent of_node [not found] ` <161861118020.865088.6364463756780633947.b4-ty@bootlin.com> @ 2021-05-22 15:36 ` Marc Kleine-Budde 2021-05-23 8:21 ` Greg Kroah-Hartman 0 siblings, 1 reply; 4+ messages in thread From: Marc Kleine-Budde @ 2021-05-22 15:36 UTC (permalink / raw) To: Alexandre Belloni, Greg Kroah-Hartman Cc: Francois Gervais, linux-rtc, Michael McCormick, Alessandro Zummo, linux-kernel, stable [-- Attachment #1: Type: text/plain, Size: 1120 bytes --] Hello Greg, On 17.04.2021 00:16:40, Alexandre Belloni wrote: > On Wed, 10 Mar 2021 16:10:26 -0500, Francois Gervais wrote: > > The rtc device node is always or at the very least can possibly be NULL. > > > > Since v5.12-rc1-dontuse/3c9ea42802a1fbf7ef29660ff8c6e526c58114f6 this > > will lead to a NULL pointer dereference. > > > > To fix this we fallback to using the parent node which is the i2c client > > node as set by devm_rtc_allocate_device(). > > > > [...] > > Applied, thanks! > > [1/1] rtc: pcf85063: fallback to parent of_node > commit: 03531606ef4cda25b629f500d1ffb6173b805c05 > > I made the fallback unconditionnal because this should have been that way from > the beginning as you point out. can you queue this for stable, as it causes a NULL Pointer deref with (at least) v5.12. Thanks, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] rtc: pcf85063: fallback to parent of_node 2021-05-22 15:36 ` [PATCH 1/1] rtc: pcf85063: fallback to parent of_node Marc Kleine-Budde @ 2021-05-23 8:21 ` Greg Kroah-Hartman 2021-05-23 18:24 ` Marc Kleine-Budde 0 siblings, 1 reply; 4+ messages in thread From: Greg Kroah-Hartman @ 2021-05-23 8:21 UTC (permalink / raw) To: Marc Kleine-Budde Cc: Alexandre Belloni, Francois Gervais, linux-rtc, Michael McCormick, Alessandro Zummo, linux-kernel, stable On Sat, May 22, 2021 at 05:36:36PM +0200, Marc Kleine-Budde wrote: > Hello Greg, > > On 17.04.2021 00:16:40, Alexandre Belloni wrote: > > On Wed, 10 Mar 2021 16:10:26 -0500, Francois Gervais wrote: > > > The rtc device node is always or at the very least can possibly be NULL. > > > > > > Since v5.12-rc1-dontuse/3c9ea42802a1fbf7ef29660ff8c6e526c58114f6 this > > > will lead to a NULL pointer dereference. > > > > > > To fix this we fallback to using the parent node which is the i2c client > > > node as set by devm_rtc_allocate_device(). > > > > > > [...] > > > > Applied, thanks! > > > > [1/1] rtc: pcf85063: fallback to parent of_node > > commit: 03531606ef4cda25b629f500d1ffb6173b805c05 > > > > I made the fallback unconditionnal because this should have been that way from > > the beginning as you point out. > > can you queue this for stable, as it causes a NULL Pointer deref with > (at least) v5.12. After it hits Linus's tree, let stable@vger.kernel.org know the id and we will glad to add it to the stable trees. thanks, greg k-h ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] rtc: pcf85063: fallback to parent of_node 2021-05-23 8:21 ` Greg Kroah-Hartman @ 2021-05-23 18:24 ` Marc Kleine-Budde 2021-05-24 12:45 ` Greg Kroah-Hartman 0 siblings, 1 reply; 4+ messages in thread From: Marc Kleine-Budde @ 2021-05-23 18:24 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Alexandre Belloni, Francois Gervais, linux-rtc, Michael McCormick, Alessandro Zummo, linux-kernel, stable [-- Attachment #1: Type: text/plain, Size: 1019 bytes --] On 23.05.2021 10:21:10, Greg Kroah-Hartman wrote: > On Sat, May 22, 2021 at 05:36:36PM +0200, Marc Kleine-Budde wrote: > > > [1/1] rtc: pcf85063: fallback to parent of_node > > > commit: 03531606ef4cda25b629f500d1ffb6173b805c05 > > > > > > I made the fallback unconditionnal because this should have been that way from > > > the beginning as you point out. > > > > can you queue this for stable, as it causes a NULL Pointer deref with > > (at least) v5.12. > > After it hits Linus's tree, let stable@vger.kernel.org know the id and > we will glad to add it to the stable trees. It's in Linus's tree since v5.13-rc1~64^2~19 and the commit id is 03531606ef4c ("rtc: pcf85063: fallback to parent of_node"). regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] rtc: pcf85063: fallback to parent of_node 2021-05-23 18:24 ` Marc Kleine-Budde @ 2021-05-24 12:45 ` Greg Kroah-Hartman 0 siblings, 0 replies; 4+ messages in thread From: Greg Kroah-Hartman @ 2021-05-24 12:45 UTC (permalink / raw) To: Marc Kleine-Budde Cc: Alexandre Belloni, Francois Gervais, linux-rtc, Michael McCormick, Alessandro Zummo, linux-kernel, stable On Sun, May 23, 2021 at 08:24:41PM +0200, Marc Kleine-Budde wrote: > On 23.05.2021 10:21:10, Greg Kroah-Hartman wrote: > > On Sat, May 22, 2021 at 05:36:36PM +0200, Marc Kleine-Budde wrote: > > > > [1/1] rtc: pcf85063: fallback to parent of_node > > > > commit: 03531606ef4cda25b629f500d1ffb6173b805c05 > > > > > > > > I made the fallback unconditionnal because this should have been that way from > > > > the beginning as you point out. > > > > > > can you queue this for stable, as it causes a NULL Pointer deref with > > > (at least) v5.12. > > > > After it hits Linus's tree, let stable@vger.kernel.org know the id and > > we will glad to add it to the stable trees. > > It's in Linus's tree since v5.13-rc1~64^2~19 and the commit id is > 03531606ef4c ("rtc: pcf85063: fallback to parent of_node"). Now queued up, thanks. greg k-h ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-24 12:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210310211026.27299-1-fgervais@distech-controls.com>
[not found] ` <161861118020.865088.6364463756780633947.b4-ty@bootlin.com>
2021-05-22 15:36 ` [PATCH 1/1] rtc: pcf85063: fallback to parent of_node Marc Kleine-Budde
2021-05-23 8:21 ` Greg Kroah-Hartman
2021-05-23 18:24 ` Marc Kleine-Budde
2021-05-24 12:45 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox