coresight-tmc-etf.c:477:33: error: 'CORESIGHT_BARRIER_PKT_SIZE' undeclared (first use in this function)

coresight-tmc-etf.c:477:33: error: 'CORESIGHT_BARRIER_PKT_SIZE' undeclared (first use in this function)

[Naresh Kamboju]

Results from Linaro’s test farm.
Regression detected on arm and arm64 due to the following patch
with CONFIG_CORESIGHT=y enabled,

coresight: tmc-etf: Fix global-out-of-bounds in tmc_update_etf_buffer()
commit 5fae8a946ac2df879caf3f79a193d4766d00239b upstream.

Build error:
------------
drivers/hwtracing/coresight/coresight-tmc-etf.c: In function
'tmc_update_etf_buffer':
drivers/hwtracing/coresight/coresight-tmc-etf.c:477:33: error:
'CORESIGHT_BARRIER_PKT_SIZE' undeclared (first use in this function)
  477 |                 if (lost && i < CORESIGHT_BARRIER_PKT_SIZE) {
      |                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~

Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>

ref:
https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc/-/jobs/1427834041#L384
https://builds.tuxbuild.com/1vMA3olyV9E6Yr1Ix0LWLlXinkv/

--
Linaro LKFT
https://lkft.linaro.org

Re: coresight-tmc-etf.c:477:33: error: 'CORESIGHT_BARRIER_PKT_SIZE' undeclared (first use in this function)

[Greg Kroah-Hartman]

On Thu, Jul 15, 2021 at 11:22:52PM +0530, Naresh Kamboju wrote:
> Results from Linaro’s test farm.
> Regression detected on arm and arm64 due to the following patch
> with CONFIG_CORESIGHT=y enabled,
> 
> coresight: tmc-etf: Fix global-out-of-bounds in tmc_update_etf_buffer()
> commit 5fae8a946ac2df879caf3f79a193d4766d00239b upstream.
> 
> Build error:
> ------------
> drivers/hwtracing/coresight/coresight-tmc-etf.c: In function
> 'tmc_update_etf_buffer':
> drivers/hwtracing/coresight/coresight-tmc-etf.c:477:33: error:
> 'CORESIGHT_BARRIER_PKT_SIZE' undeclared (first use in this function)
>   477 |                 if (lost && i < CORESIGHT_BARRIER_PKT_SIZE) {
>       |                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> 
> ref:
> https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc/-/jobs/1427834041#L384
> https://builds.tuxbuild.com/1vMA3olyV9E6Yr1Ix0LWLlXinkv/

I have no idea what tree/branch/queue this report is from :(

Re: coresight-tmc-etf.c:477:33: error: 'CORESIGHT_BARRIER_PKT_SIZE' undeclared (first use in this function)

[Naresh Kamboju]

On Thu, 15 Jul 2021 at 23:27, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Thu, Jul 15, 2021 at 11:22:52PM +0530, Naresh Kamboju wrote:
> > Results from Linaro’s test farm.
> > Regression detected on arm and arm64 due to the following patch
> > with CONFIG_CORESIGHT=y enabled,
> >
> > coresight: tmc-etf: Fix global-out-of-bounds in tmc_update_etf_buffer()
> > commit 5fae8a946ac2df879caf3f79a193d4766d00239b upstream.
> >
> > Build error:
> > ------------
> > drivers/hwtracing/coresight/coresight-tmc-etf.c: In function
> > 'tmc_update_etf_buffer':
> > drivers/hwtracing/coresight/coresight-tmc-etf.c:477:33: error:
> > 'CORESIGHT_BARRIER_PKT_SIZE' undeclared (first use in this function)
> >   477 |                 if (lost && i < CORESIGHT_BARRIER_PKT_SIZE) {
> >       |                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> >
> > ref:
> > https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc/-/jobs/1427834041#L384
> > https://builds.tuxbuild.com/1vMA3olyV9E6Yr1Ix0LWLlXinkv/
>
> I have no idea what tree/branch/queue this report is from :(

Sorry,
stable-rc 4.14.240-rc1.

c81cb98781af ("Linux 4.14.240-rc1") arm64 (defconfig+7) with gcc-11

steps to reproduce:
------------------------
# TuxMake is a command line tool and Python library that provides
# portable and repeatable Linux kernel builds across a variety of
# architectures, toolchains, kernel configurations, and make targets.
#
# TuxMake supports the concept of runtimes.
# See https://docs.tuxmake.org/runtimes/, for that to work it requires
# that you install podman or docker on your system.
#
# To install tuxmake on your system globally:
# sudo pip3 install -U tuxmake
#
# See https://docs.tuxmake.org/ for complete documentation.


tuxmake --runtime podman --target-arch arm64 --toolchain gcc-11
--kconfig defconfig --kconfig-add
https://builds.tuxbuild.com/1vMA3olyV9E6Yr1Ix0LWLlXinkv/config


- Naresh

Re: coresight-tmc-etf.c:477:33: error: 'CORESIGHT_BARRIER_PKT_SIZE' undeclared (first use in this function)

[Greg Kroah-Hartman]

On Thu, Jul 15, 2021 at 11:59:58PM +0530, Naresh Kamboju wrote:
> On Thu, 15 Jul 2021 at 23:27, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Thu, Jul 15, 2021 at 11:22:52PM +0530, Naresh Kamboju wrote:
> > > Results from Linaro’s test farm.
> > > Regression detected on arm and arm64 due to the following patch
> > > with CONFIG_CORESIGHT=y enabled,
> > >
> > > coresight: tmc-etf: Fix global-out-of-bounds in tmc_update_etf_buffer()
> > > commit 5fae8a946ac2df879caf3f79a193d4766d00239b upstream.
> > >
> > > Build error:
> > > ------------
> > > drivers/hwtracing/coresight/coresight-tmc-etf.c: In function
> > > 'tmc_update_etf_buffer':
> > > drivers/hwtracing/coresight/coresight-tmc-etf.c:477:33: error:
> > > 'CORESIGHT_BARRIER_PKT_SIZE' undeclared (first use in this function)
> > >   477 |                 if (lost && i < CORESIGHT_BARRIER_PKT_SIZE) {
> > >       |                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~
> > >
> > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > >
> > > ref:
> > > https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc/-/jobs/1427834041#L384
> > > https://builds.tuxbuild.com/1vMA3olyV9E6Yr1Ix0LWLlXinkv/
> >
> > I have no idea what tree/branch/queue this report is from :(
> 
> Sorry,
> stable-rc 4.14.240-rc1.

Thanks, now fixed by dropping the offending patch.

greg k-h