Linux kernel -stable discussions
 help / color / mirror / Atom feed
* [PATCH v2] clocksource: stm32-lptimer: use wakeup capable instead of init wakeup
@ 2025-03-06  8:34 Fabrice Gasnier
  2025-03-06  8:38 ` kernel test robot
  0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Gasnier @ 2025-03-06  8:34 UTC (permalink / raw)
  To: daniel.lezcano, tglx
  Cc: stable, alexandre.torgue, olivier.moysan, fabrice.gasnier,
	linux-kernel, linux-arm-kernel, linux-stm32

From: Alexandre Torgue <alexandre.torgue@foss.st.com>

"wakeup-source" property describes a device which has wakeup capability
but should not force this device as a wakeup source.

Fixes: 48b41c5e2de6 ("clocksource: Add Low Power STM32 timers driver")
Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
---
 drivers/clocksource/timer-stm32-lp.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/clocksource/timer-stm32-lp.c b/drivers/clocksource/timer-stm32-lp.c
index a4c95161cb22..193e4f643358 100644
--- a/drivers/clocksource/timer-stm32-lp.c
+++ b/drivers/clocksource/timer-stm32-lp.c
@@ -168,9 +168,7 @@ static int stm32_clkevent_lp_probe(struct platform_device *pdev)
 	}
 
 	if (of_property_read_bool(pdev->dev.parent->of_node, "wakeup-source")) {
-		ret = device_init_wakeup(&pdev->dev, true);
-		if (ret)
-			goto out_clk_disable;
+		device_set_wakeup_capable(&pdev->dev, true);
 
 		ret = dev_pm_set_wake_irq(&pdev->dev, irq);
 		if (ret)
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] clocksource: stm32-lptimer: use wakeup capable instead of init wakeup
  2025-03-06  8:34 [PATCH v2] clocksource: stm32-lptimer: use wakeup capable instead of init wakeup Fabrice Gasnier
@ 2025-03-06  8:38 ` kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2025-03-06  8:38 UTC (permalink / raw)
  To: Fabrice Gasnier; +Cc: stable, oe-kbuild-all

Hi,

Thanks for your patch.

FYI: kernel test robot notices the stable kernel rule is not satisfied.

The check is based on https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html#option-1

Rule: add the tag "Cc: stable@vger.kernel.org" in the sign-off area to have the patch automatically included in the stable tree.
Subject: [PATCH v2] clocksource: stm32-lptimer: use wakeup capable instead of init wakeup
Link: https://lore.kernel.org/stable/20250306083407.2374894-1-fabrice.gasnier%40foss.st.com

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-03-06  8:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-06  8:34 [PATCH v2] clocksource: stm32-lptimer: use wakeup capable instead of init wakeup Fabrice Gasnier
2025-03-06  8:38 ` kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox