Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>,
	Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: bug-make@gnu.org, stable@vger.kernel.org,
	Dmitry Goncharov <dgoncharov@users.sf.net>
Subject: Re: No progress output when make 4.4.1 builds Linux 4.19 and earlier
Date: Tue, 7 Mar 2023 22:34:23 -0800	[thread overview]
Message-ID: <ZAgsb/P1NLugNeUl@sol.localdomain> (raw)
In-Reply-To: <ZAgogdFlu69QlYwu@kroah.com>

On Wed, Mar 08, 2023 at 07:17:37AM +0100, Greg KH wrote:
> On Tue, Mar 07, 2023 at 10:13:45PM -0800, Eric Biggers wrote:
> > After upgrading to make v4.4.1 (released last week), there's no longer any
> > progress output from builds of the Linux kernel v4.19 and earlier.  It seems the
> > actual build still works, but it's now silent except for warnings and errors.
> > 
> > It bisects to the following 'make' commit:
> > 
> >     commit dc2d963989b96161472b2cd38cef5d1f4851ea34
> >     Author: Dmitry Goncharov <dgoncharov@users.sf.net>
> >     Date:   Sun Nov 27 14:09:17 2022 -0500
> > 
> >         [SV 63347] Always add command line variable assignments to MAKEFLAGS
> > 
> > Is this an intentional breakage from the 'make' side?
> 
> Ah, thanks for figuring this out, it's been bugging me locally for a bit
> as well!  The fact that kernels 5.4 and newer imply to me that there is
> a kernel build fix that should resolve this if someone can take the time
> to bisect it...
> 

Fix bisection comes up with the following kernel commit:

    commit 80463f1b7bf9f822fd3495139bcf3ef254fdca10
    Author: Masahiro Yamada <yamada.masahiro@socionext.com>
    Date:   Fri Sep 14 15:33:23 2018 +0900
    
        kbuild: add --include-dir flag only for out-of-tree build

But only for in-tree builds.  Out-of-tree builds need:

    commit 3812b8c5c5d527239ac015f1f2c7654da7fcfbba
    Author: Masahiro Yamada <yamada.masahiro@socionext.com>
    Date:   Fri Feb 22 16:40:07 2019 +0900

        kbuild: make -r/-R effective in top Makefile for old Make versions

Masahiro, what dependencies (if any) do the above two commits have in order to
be backported to 4.19 and 4.14?

- Eric

  reply	other threads:[~2023-03-08  6:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-08  6:13 No progress output when make 4.4.1 builds Linux 4.19 and earlier Eric Biggers
2023-03-08  6:17 ` Greg KH
2023-03-08  6:34   ` Eric Biggers [this message]
2023-03-08 13:12   ` Dmitry Goncharov
2023-03-08 13:27     ` Greg KH
2023-03-08 13:57     ` Paul Smith
2023-03-08 14:31       ` Greg KH
2023-03-08 14:39       ` Dmitry Goncharov
2023-03-08 15:53       ` David Laight
2023-03-08 17:50         ` Paul Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZAgsb/P1NLugNeUl@sol.localdomain \
    --to=ebiggers@kernel.org \
    --cc=bug-make@gnu.org \
    --cc=dgoncharov@users.sf.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=stable@vger.kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox