Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Paul Smith <psmith@gnu.org>
Cc: Eric Biggers <ebiggers@kernel.org>,
	bug-make@gnu.org, stable@vger.kernel.org
Subject: Re: No progress output when make 4.4.1 builds Linux 4.19 and earlier
Date: Wed, 8 Mar 2023 15:31:17 +0100	[thread overview]
Message-ID: <ZAicNUe2XfdQudex@kroah.com> (raw)
In-Reply-To: <4e731dfbe197f5c0a6c1093aee503b7f4d76cc1a.camel@gnu.org>

On Wed, Mar 08, 2023 at 08:57:34AM -0500, Paul Smith wrote:
> On Wed, 2023-03-08 at 08:12 -0500, Dmitry Goncharov wrote:
> > > > Is this an intentional breakage from the 'make' side?
> > No it is not an intentional breakage.
> > This is a fix for https://savannah.gnu.org/bugs/?63347.
> 
> Just to note, it was possible to run into this problem with earlier
> versions of GNU Make as well, it just became much simpler once the
> variables were available since it's easier to have an "s" in some
> variable.  But it is possible to have an "s" in a MAKEFLAGS flag which
> is not introduced with a "--", and doesn't represent the short option.
> 
> I give some examples in that Savannah bug.
> 
> > > The fact that kernels 5.4 and newer imply to me that there is
> > > a kernel build fix that should resolve this if someone can take the
> > > time to bisect it...
> > 
> > Kernel makefile was updated to work with old and new make in
> > 4bf73588165ba7d32131a043775557a54b6e1db5.
> > If you wanted to backport, try this commit.
> 
> Does anyone know why this commit is using a make version comparison? 
> That seems totally unnecessary to me; am I forgetting something?  As
> far as I remember,
> 
>     silence := $(findstring s,$(firstword -$(MAKEFLAGS)))
> 
> has always been the proper way to check for the short option "s", and
> has always worked in every version of GNU Make.
> 
> https://github.com/torvalds/linux/commit/4bf73588165ba7d32131a043775557a54b6e1db5

No idea, sorry, submit a patch to the kbuild maintainer and they will
probably accept it.

thanks,

greg k-h

  reply	other threads:[~2023-03-08 14:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-08  6:13 No progress output when make 4.4.1 builds Linux 4.19 and earlier Eric Biggers
2023-03-08  6:17 ` Greg KH
2023-03-08  6:34   ` Eric Biggers
2023-03-08 13:12   ` Dmitry Goncharov
2023-03-08 13:27     ` Greg KH
2023-03-08 13:57     ` Paul Smith
2023-03-08 14:31       ` Greg KH [this message]
2023-03-08 14:39       ` Dmitry Goncharov
2023-03-08 15:53       ` David Laight
2023-03-08 17:50         ` Paul Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZAicNUe2XfdQudex@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bug-make@gnu.org \
    --cc=ebiggers@kernel.org \
    --cc=psmith@gnu.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox