Re: Patch "fbdev: omapfb: Drop unused remove function" has been added to the 6.6-stable tree

Re: Patch "fbdev: omapfb: Drop unused remove function" has been added to the 6.6-stable tree

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 2006 bytes --]

On Sun, Nov 12, 2023 at 11:36:02PM -0500, Sasha Levin wrote:
> This is a note to let you know that I've just added the patch titled
> 
>     fbdev: omapfb: Drop unused remove function
> 
> to the 6.6-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>      fbdev-omapfb-drop-unused-remove-function.patch
> and it can be found in the queue-6.6 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.
> 
> 
> 
> commit a772de6bea2f5a9b5dad8afe0d9145fd8ee62564
> Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Date:   Fri Nov 3 18:35:58 2023 +0100
> 
>     fbdev: omapfb: Drop unused remove function
>     
>     [ Upstream commit fc6699d62f5f4facc3e934efd25892fc36050b70 ]
>     
>     OMAP2_VRFB is a bool, so the vrfb driver can never be compiled as a
>     module. With that __exit_p(vrfb_remove) always evaluates to NULL and
>     vrfb_remove() is unused.
>     
>     If the driver was compilable as a module, it would fail to build because
>     the type of vrfb_remove() isn't compatible with struct
>     platform_driver::remove(). (The former returns void, the latter int.)
>     
>     Fixes: aa1e49a3752f ("OMAPDSS: VRFB: add omap_vrfb_supported()")
>     Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>     Signed-off-by: Helge Deller <deller@gmx.de>
>     Signed-off-by: Sasha Levin <sashal@kernel.org>

While it doesn't hurt to backport this patch, I guess it also doesn't
give any benefit (apart from increasing my patch count in stable :-).

This commit just removes code that was thrown away by the compiler
before. So I'd not backport it.
 
Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Patch "fbdev: omapfb: Drop unused remove function" has been added to the 6.6-stable tree

[Sasha Levin]

On Mon, Nov 13, 2023 at 09:53:30AM +0100, Uwe Kleine-König wrote:
>On Sun, Nov 12, 2023 at 11:36:02PM -0500, Sasha Levin wrote:
>> This is a note to let you know that I've just added the patch titled
>>
>>     fbdev: omapfb: Drop unused remove function
>>
>> to the 6.6-stable tree which can be found at:
>>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
>>
>> The filename of the patch is:
>>      fbdev-omapfb-drop-unused-remove-function.patch
>> and it can be found in the queue-6.6 subdirectory.
>>
>> If you, or anyone else, feels it should not be added to the stable tree,
>> please let <stable@vger.kernel.org> know about it.
>>
>>
>>
>> commit a772de6bea2f5a9b5dad8afe0d9145fd8ee62564
>> Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>> Date:   Fri Nov 3 18:35:58 2023 +0100
>>
>>     fbdev: omapfb: Drop unused remove function
>>
>>     [ Upstream commit fc6699d62f5f4facc3e934efd25892fc36050b70 ]
>>
>>     OMAP2_VRFB is a bool, so the vrfb driver can never be compiled as a
>>     module. With that __exit_p(vrfb_remove) always evaluates to NULL and
>>     vrfb_remove() is unused.
>>
>>     If the driver was compilable as a module, it would fail to build because
>>     the type of vrfb_remove() isn't compatible with struct
>>     platform_driver::remove(). (The former returns void, the latter int.)
>>
>>     Fixes: aa1e49a3752f ("OMAPDSS: VRFB: add omap_vrfb_supported()")
>>     Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>>     Signed-off-by: Helge Deller <deller@gmx.de>
>>     Signed-off-by: Sasha Levin <sashal@kernel.org>
>
>While it doesn't hurt to backport this patch, I guess it also doesn't
>give any benefit (apart from increasing my patch count in stable :-).
>
>This commit just removes code that was thrown away by the compiler
>before. So I'd not backport it.

Ack, dropped. Thanks!

-- 
Thanks,
Sasha