Re: Patch "selftests: mptcp: join: ability to invert ADD_ADDR check" has been added to the 6.10-stable tree

Re: Patch "selftests: mptcp: join: ability to invert ADD_ADDR check" has been added to the 6.10-stable tree

[Matthieu Baerts]

Hi Sasha, Greg,

On 11/08/2024 14:56, Sasha Levin wrote:
> This is a note to let you know that I've just added the patch titled
> 
>     selftests: mptcp: join: ability to invert ADD_ADDR check
> 
> to the 6.10-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>      selftests-mptcp-join-ability-to-invert-add_addr-chec.patch
> and it can be found in the queue-6.10 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.
> 
> 
> 
> commit 469e6fe99988649029b7f136218d5c3d8854e705
> Author: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> Date:   Wed Jul 31 13:05:58 2024 +0200
> 
>     selftests: mptcp: join: ability to invert ADD_ADDR check
>     
>     [ Upstream commit bec1f3b119ebc613d08dfbcdbaef01a79aa7de92 ]
>     
>     In the following commit, the client will initiate the ADD_ADDR, instead
>     of the server. We need to way to verify the ADD_ADDR have been correctly
>     sent.
>     
>     Note: the default expected counters for when the port number is given
>     are never changed by the caller, no need to accept them as parameter
>     then.
>     
>     The 'Fixes' tag here below is the same as the one from the previous
>     commit: this patch here is not fixing anything wrong in the selftests,
>     but it validates the previous fix for an issue introduced by this commit
>     ID.

Sorry, I just realised I forgot to add the "Cc: Stable" on all patches
from this series :-/

This patch and "selftests: mptcp: join: test both signal & subflow"
should be backported with the other patches modifying files in
net/mptcp. Without them, the two patches that have just been added to
the queue will just make the selftests failing.

Is it then possible to drop these two patches from the 6.10, 6.6 and 6.1
queues for the moment please? I can send patches for these versions
later on.

  selftests-mptcp-join-ability-to-invert-add_addr-chec.patch: 6.10, 6.6
  selftests-mptcp-join-test-both-signal-subflow.patch: 6.10, 6.6 and 6.1

>     Fixes: 86e39e04482b ("mptcp: keep track of local endpoint still available for each msk")
>     Reviewed-by: Mat Martineau <martineau@kernel.org>
>     Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
>     Link: https://patch.msgid.link/20240731-upstream-net-20240731-mptcp-endp-subflow-signal-v1-6-c8a9b036493b@kernel.org
>     Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>     Signed-off-by: Sasha Levin <sashal@kernel.org>
Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

Re: Patch "selftests: mptcp: join: ability to invert ADD_ADDR check" has been added to the 6.10-stable tree

[Sasha Levin]

On Sun, Aug 11, 2024 at 05:46:22PM +0200, Matthieu Baerts wrote:
>Hi Sasha, Greg,
>
>On 11/08/2024 14:56, Sasha Levin wrote:
>> This is a note to let you know that I've just added the patch titled
>>
>>     selftests: mptcp: join: ability to invert ADD_ADDR check
>>
>> to the 6.10-stable tree which can be found at:
>>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
>>
>> The filename of the patch is:
>>      selftests-mptcp-join-ability-to-invert-add_addr-chec.patch
>> and it can be found in the queue-6.10 subdirectory.
>>
>> If you, or anyone else, feels it should not be added to the stable tree,
>> please let <stable@vger.kernel.org> know about it.
>>
>>
>>
>> commit 469e6fe99988649029b7f136218d5c3d8854e705
>> Author: Matthieu Baerts (NGI0) <matttbe@kernel.org>
>> Date:   Wed Jul 31 13:05:58 2024 +0200
>>
>>     selftests: mptcp: join: ability to invert ADD_ADDR check
>>
>>     [ Upstream commit bec1f3b119ebc613d08dfbcdbaef01a79aa7de92 ]
>>
>>     In the following commit, the client will initiate the ADD_ADDR, instead
>>     of the server. We need to way to verify the ADD_ADDR have been correctly
>>     sent.
>>
>>     Note: the default expected counters for when the port number is given
>>     are never changed by the caller, no need to accept them as parameter
>>     then.
>>
>>     The 'Fixes' tag here below is the same as the one from the previous
>>     commit: this patch here is not fixing anything wrong in the selftests,
>>     but it validates the previous fix for an issue introduced by this commit
>>     ID.
>
>Sorry, I just realised I forgot to add the "Cc: Stable" on all patches
>from this series :-/
>
>This patch and "selftests: mptcp: join: test both signal & subflow"
>should be backported with the other patches modifying files in
>net/mptcp. Without them, the two patches that have just been added to
>the queue will just make the selftests failing.
>
>Is it then possible to drop these two patches from the 6.10, 6.6 and 6.1
>queues for the moment please? I can send patches for these versions
>later on.
>
>  selftests-mptcp-join-ability-to-invert-add_addr-chec.patch: 6.10, 6.6
>  selftests-mptcp-join-test-both-signal-subflow.patch: 6.10, 6.6 and 6.1

Sure, now dropped.

-- 
Thanks,
Sasha