Re: Patch "tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status bool active" has been added to the 6.1-stable tree

Re: Patch "tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status bool active" has been added to the 6.1-stable tree

[Jiri Slaby]

On 22. 10. 24, 19:54, Sasha Levin wrote:
> This is a note to let you know that I've just added the patch titled
> 
>      tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status bool active

This is a cleanup, not needed in stable. (Unless something 
context-depends on it.)

-- 
js
suse labs

Re: Patch "tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status bool active" has been added to the 6.1-stable tree

[Sasha Levin]

On Wed, Oct 23, 2024 at 08:25:12AM +0200, Jiri Slaby wrote:
>On 22. 10. 24, 19:54, Sasha Levin wrote:
>>This is a note to let you know that I've just added the patch titled
>>
>>     tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status bool active
>
>This is a cleanup, not needed in stable. (Unless something 
>context-depends on it.)

The 3 commits you've pointed out are a pre-req for 30c9ae5ece8e ("xhci:
dbc: honor usb transfer size boundaries.").

-- 
Thanks,
Sasha

Re: Patch "tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status bool active" has been added to the 6.1-stable tree

[Ilpo Järvinen]

On Wed, 23 Oct 2024, Sasha Levin wrote:

> On Wed, Oct 23, 2024 at 08:25:12AM +0200, Jiri Slaby wrote:
> > On 22. 10. 24, 19:54, Sasha Levin wrote:
> > > This is a note to let you know that I've just added the patch titled
> > > 
> > >     tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status bool
> > > active
> > 
> > This is a cleanup, not needed in stable. (Unless something context-depends
> > on it.)
> 
> The 3 commits you've pointed out are a pre-req for 30c9ae5ece8e ("xhci:
> dbc: honor usb transfer size boundaries.").

Hi Sasha,

I wonder if that information could be added automatically into the 
notification email as it feels useful to know?

I assume there's some tool which figures these pre-reqs out, if it's based 
on manual work, please disregard my suggestion.

-- 
 i.

Re: Patch "tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status bool active" has been added to the 6.1-stable tree

[Sasha Levin]

On Wed, Oct 23, 2024 at 02:56:06PM +0300, Ilpo Järvinen wrote:
>On Wed, 23 Oct 2024, Sasha Levin wrote:
>
>> On Wed, Oct 23, 2024 at 08:25:12AM +0200, Jiri Slaby wrote:
>> > On 22. 10. 24, 19:54, Sasha Levin wrote:
>> > > This is a note to let you know that I've just added the patch titled
>> > >
>> > >     tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status bool
>> > > active
>> >
>> > This is a cleanup, not needed in stable. (Unless something context-depends
>> > on it.)
>>
>> The 3 commits you've pointed out are a pre-req for 30c9ae5ece8e ("xhci:
>> dbc: honor usb transfer size boundaries.").
>
>Hi Sasha,
>
>I wonder if that information could be added automatically into the
>notification email as it feels useful to know?
>
>I assume there's some tool which figures these pre-reqs out, if it's based
>on manual work, please disregard my suggestion.

We already add a tag to indicate the dependency, sometimes folks miss it.

In the case of this patch, here it is:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-6.1/tty-serial-make-dcd_change-uart_handle_dcd_change-st.patch#n25

-- 
Thanks,
Sasha

Re: Patch "tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status bool active" has been added to the 6.1-stable tree

[Ilpo Järvinen]

[-- Attachment #1: Type: text/plain, Size: 1387 bytes --]

On Wed, 23 Oct 2024, Sasha Levin wrote:

> On Wed, Oct 23, 2024 at 02:56:06PM +0300, Ilpo Järvinen wrote:
> > On Wed, 23 Oct 2024, Sasha Levin wrote:
> > 
> > > On Wed, Oct 23, 2024 at 08:25:12AM +0200, Jiri Slaby wrote:
> > > > On 22. 10. 24, 19:54, Sasha Levin wrote:
> > > > > This is a note to let you know that I've just added the patch titled
> > > > >
> > > > >     tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status
> > > bool
> > > > > active
> > > >
> > > > This is a cleanup, not needed in stable. (Unless something
> > > context-depends
> > > > on it.)
> > > 
> > > The 3 commits you've pointed out are a pre-req for 30c9ae5ece8e ("xhci:
> > > dbc: honor usb transfer size boundaries.").
> > 
> > Hi Sasha,
> > 
> > I wonder if that information could be added automatically into the
> > notification email as it feels useful to know?
> > 
> > I assume there's some tool which figures these pre-reqs out, if it's based
> > on manual work, please disregard my suggestion.
> 
> We already add a tag to indicate the dependency, sometimes folks miss it.

Heheh, it seems I'm too among them. Thanks a lot for pointing that out.

> In the case of this patch, here it is:
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-6.1/tty-serial-make-dcd_change-uart_handle_dcd_change-st.patch#n25

-- 
 i.

Re: Patch "tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status bool active" has been added to the 6.1-stable tree

[Jiri Slaby]

On 23. 10. 24, 13:48, Sasha Levin wrote:
> On Wed, Oct 23, 2024 at 08:25:12AM +0200, Jiri Slaby wrote:
>> On 22. 10. 24, 19:54, Sasha Levin wrote:
>>> This is a note to let you know that I've just added the patch titled
>>>
>>>     tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status 
>>> bool active
>>
>> This is a cleanup, not needed in stable. (Unless something context- 
>> depends on it.)
> 
> The 3 commits you've pointed out are a pre-req for 30c9ae5ece8e ("xhci:
> dbc: honor usb transfer size boundaries.").

Ah, OK, thanks.

And OMG (side note), the patch reintroduced the non-sense pattern I 
removed (the added kfifo_len()).




But re. this patch
   0388a152fc55 tty/serial: Make ->dcd_change()+uart_handle_dcd_change() 
status bool active
with
   Stable-dep-of: 40d7903386df ("serial: imx: Update mctrl old_status on 
RTSD interrupt")

I fail to see how is that a dep?

thanks,
-- 
js
suse labs