From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: "Wentland, Harry" <Harry.Wentland@amd.com>,
Alex Deucher <alexdeucher@gmail.com>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Cc: "Deucher, Alexander" <Alexander.Deucher@amd.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] Revert "drm/amd/display: add -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines"
Date: Wed, 30 Jan 2019 11:35:28 +0100 [thread overview]
Message-ID: <a66a5a9d-941f-38a9-0a34-8d8a066a3571@gmail.com> (raw)
In-Reply-To: <05ee719f-ac7e-bcb0-59f0-920b72f65524@amd.com>
Am 29.01.19 um 19:28 schrieb Wentland, Harry:
> On 2019-01-29 11:57 a.m., Alex Deucher wrote:
>> This reverts commit 10117450735c7a7c0858095fb46a860e7037cb9a.
>>
>> Causes a crash.
>>
>> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=109487
>> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>> Cc: stable@vger.kernel.org # 4.19
> Thanks for finding and reverting.
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
I find it really troubling that we run into so many issues with that.
Christian.
>
> Harry
>
>> ---
>> drivers/gpu/drm/amd/display/dc/calcs/Makefile | 2 +-
>> drivers/gpu/drm/amd/display/dc/dml/Makefile | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/dc/calcs/Makefile b/drivers/gpu/drm/amd/display/dc/calcs/Makefile
>> index dc85a3c088af..95f332ee3e7e 100644
>> --- a/drivers/gpu/drm/amd/display/dc/calcs/Makefile
>> +++ b/drivers/gpu/drm/amd/display/dc/calcs/Makefile
>> @@ -30,7 +30,7 @@ else ifneq ($(call cc-option, -mstack-alignment=16),)
>> cc_stack_align := -mstack-alignment=16
>> endif
>>
>> -calcs_ccflags := -mhard-float -msse -msse2 $(cc_stack_align)
>> +calcs_ccflags := -mhard-float -msse $(cc_stack_align)
>>
>> CFLAGS_dcn_calcs.o := $(calcs_ccflags)
>> CFLAGS_dcn_calc_auto.o := $(calcs_ccflags)
>> diff --git a/drivers/gpu/drm/amd/display/dc/dml/Makefile b/drivers/gpu/drm/amd/display/dc/dml/Makefile
>> index 33c7d7588712..d97ca6528f9d 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dml/Makefile
>> +++ b/drivers/gpu/drm/amd/display/dc/dml/Makefile
>> @@ -30,7 +30,7 @@ else ifneq ($(call cc-option, -mstack-alignment=16),)
>> cc_stack_align := -mstack-alignment=16
>> endif
>>
>> -dml_ccflags := -mhard-float -msse -msse2 $(cc_stack_align)
>> +dml_ccflags := -mhard-float -msse $(cc_stack_align)
>>
>> CFLAGS_display_mode_lib.o := $(dml_ccflags)
>> CFLAGS_display_pipe_clocks.o := $(dml_ccflags)
>>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2019-01-30 10:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 16:57 [PATCH] Revert "drm/amd/display: add -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines" Alex Deucher
2019-01-29 17:38 ` Greg KH
2019-01-29 18:07 ` Alex Deucher
2019-01-29 18:28 ` Wentland, Harry
2019-01-30 10:35 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a66a5a9d-941f-38a9-0a34-8d8a066a3571@gmail.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=Alexander.Deucher@amd.com \
--cc=Harry.Wentland@amd.com \
--cc=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox