* [PATCH 1/6] pinctrl: airoha: fix wrong PHY LED mux value for LED1 GPIO46 [not found] <20250527222040.32000-1-ansuelsmth@gmail.com> @ 2025-05-27 22:20 ` Christian Marangi 2025-05-28 7:16 ` Lorenzo Bianconi 0 siblings, 1 reply; 2+ messages in thread From: Christian Marangi @ 2025-05-27 22:20 UTC (permalink / raw) To: Lorenzo Bianconi, Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Sean Wang, Matthias Brugger, AngeloGioacchino Del Regno, Benjamin Larsson, linux-mediatek, linux-gpio, devicetree, linux-kernel, linux-arm-kernel Cc: Christian Marangi, stable In all the MUX value for LED1 GPIO46 there is a Copy-Paste error where the MUX value is set to LED0_MODE_MASK instead of LED1_MODE_MASK. This wasn't notice as there were no board that made use of the secondary PHY LED but looking at the internal Documentation the actual value should be LED1_MODE_MASK similar to the other GPIO entry. Fix the wrong value to apply the correct MUX configuration. Cc: stable@vger.kernel.org Fixes: 1c8ace2d0725 ("pinctrl: airoha: Add support for EN7581 SoC") Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> --- drivers/pinctrl/mediatek/pinctrl-airoha.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-airoha.c b/drivers/pinctrl/mediatek/pinctrl-airoha.c index b97b28ebb37a..8ef7f88477aa 100644 --- a/drivers/pinctrl/mediatek/pinctrl-airoha.c +++ b/drivers/pinctrl/mediatek/pinctrl-airoha.c @@ -1752,8 +1752,8 @@ static const struct airoha_pinctrl_func_group phy1_led1_func_group[] = { .regmap[0] = { AIROHA_FUNC_MUX, REG_GPIO_2ND_I2C_MODE, - GPIO_LAN3_LED0_MODE_MASK, - GPIO_LAN3_LED0_MODE_MASK + GPIO_LAN3_LED1_MODE_MASK, + GPIO_LAN3_LED1_MODE_MASK }, .regmap[1] = { AIROHA_FUNC_MUX, @@ -1816,8 +1816,8 @@ static const struct airoha_pinctrl_func_group phy2_led1_func_group[] = { .regmap[0] = { AIROHA_FUNC_MUX, REG_GPIO_2ND_I2C_MODE, - GPIO_LAN3_LED0_MODE_MASK, - GPIO_LAN3_LED0_MODE_MASK + GPIO_LAN3_LED1_MODE_MASK, + GPIO_LAN3_LED1_MODE_MASK }, .regmap[1] = { AIROHA_FUNC_MUX, @@ -1880,8 +1880,8 @@ static const struct airoha_pinctrl_func_group phy3_led1_func_group[] = { .regmap[0] = { AIROHA_FUNC_MUX, REG_GPIO_2ND_I2C_MODE, - GPIO_LAN3_LED0_MODE_MASK, - GPIO_LAN3_LED0_MODE_MASK + GPIO_LAN3_LED1_MODE_MASK, + GPIO_LAN3_LED1_MODE_MASK }, .regmap[1] = { AIROHA_FUNC_MUX, @@ -1944,8 +1944,8 @@ static const struct airoha_pinctrl_func_group phy4_led1_func_group[] = { .regmap[0] = { AIROHA_FUNC_MUX, REG_GPIO_2ND_I2C_MODE, - GPIO_LAN3_LED0_MODE_MASK, - GPIO_LAN3_LED0_MODE_MASK + GPIO_LAN3_LED1_MODE_MASK, + GPIO_LAN3_LED1_MODE_MASK }, .regmap[1] = { AIROHA_FUNC_MUX, -- 2.48.1 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/6] pinctrl: airoha: fix wrong PHY LED mux value for LED1 GPIO46 2025-05-27 22:20 ` [PATCH 1/6] pinctrl: airoha: fix wrong PHY LED mux value for LED1 GPIO46 Christian Marangi @ 2025-05-28 7:16 ` Lorenzo Bianconi 0 siblings, 0 replies; 2+ messages in thread From: Lorenzo Bianconi @ 2025-05-28 7:16 UTC (permalink / raw) To: Christian Marangi Cc: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Sean Wang, Matthias Brugger, AngeloGioacchino Del Regno, Benjamin Larsson, linux-mediatek, linux-gpio, devicetree, linux-kernel, linux-arm-kernel, stable [-- Attachment #1: Type: text/plain, Size: 2465 bytes --] > In all the MUX value for LED1 GPIO46 there is a Copy-Paste error where > the MUX value is set to LED0_MODE_MASK instead of LED1_MODE_MASK. > > This wasn't notice as there were no board that made use of the > secondary PHY LED but looking at the internal Documentation the actual > value should be LED1_MODE_MASK similar to the other GPIO entry. > > Fix the wrong value to apply the correct MUX configuration. Acked-by: Lorenzo Bianconi <lorenzo@kernel.org> > > Cc: stable@vger.kernel.org > Fixes: 1c8ace2d0725 ("pinctrl: airoha: Add support for EN7581 SoC") > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > --- > drivers/pinctrl/mediatek/pinctrl-airoha.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/pinctrl/mediatek/pinctrl-airoha.c b/drivers/pinctrl/mediatek/pinctrl-airoha.c > index b97b28ebb37a..8ef7f88477aa 100644 > --- a/drivers/pinctrl/mediatek/pinctrl-airoha.c > +++ b/drivers/pinctrl/mediatek/pinctrl-airoha.c > @@ -1752,8 +1752,8 @@ static const struct airoha_pinctrl_func_group phy1_led1_func_group[] = { > .regmap[0] = { > AIROHA_FUNC_MUX, > REG_GPIO_2ND_I2C_MODE, > - GPIO_LAN3_LED0_MODE_MASK, > - GPIO_LAN3_LED0_MODE_MASK > + GPIO_LAN3_LED1_MODE_MASK, > + GPIO_LAN3_LED1_MODE_MASK > }, > .regmap[1] = { > AIROHA_FUNC_MUX, > @@ -1816,8 +1816,8 @@ static const struct airoha_pinctrl_func_group phy2_led1_func_group[] = { > .regmap[0] = { > AIROHA_FUNC_MUX, > REG_GPIO_2ND_I2C_MODE, > - GPIO_LAN3_LED0_MODE_MASK, > - GPIO_LAN3_LED0_MODE_MASK > + GPIO_LAN3_LED1_MODE_MASK, > + GPIO_LAN3_LED1_MODE_MASK > }, > .regmap[1] = { > AIROHA_FUNC_MUX, > @@ -1880,8 +1880,8 @@ static const struct airoha_pinctrl_func_group phy3_led1_func_group[] = { > .regmap[0] = { > AIROHA_FUNC_MUX, > REG_GPIO_2ND_I2C_MODE, > - GPIO_LAN3_LED0_MODE_MASK, > - GPIO_LAN3_LED0_MODE_MASK > + GPIO_LAN3_LED1_MODE_MASK, > + GPIO_LAN3_LED1_MODE_MASK > }, > .regmap[1] = { > AIROHA_FUNC_MUX, > @@ -1944,8 +1944,8 @@ static const struct airoha_pinctrl_func_group phy4_led1_func_group[] = { > .regmap[0] = { > AIROHA_FUNC_MUX, > REG_GPIO_2ND_I2C_MODE, > - GPIO_LAN3_LED0_MODE_MASK, > - GPIO_LAN3_LED0_MODE_MASK > + GPIO_LAN3_LED1_MODE_MASK, > + GPIO_LAN3_LED1_MODE_MASK > }, > .regmap[1] = { > AIROHA_FUNC_MUX, > -- > 2.48.1 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-28 7:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20250527222040.32000-1-ansuelsmth@gmail.com>
2025-05-27 22:20 ` [PATCH 1/6] pinctrl: airoha: fix wrong PHY LED mux value for LED1 GPIO46 Christian Marangi
2025-05-28 7:16 ` Lorenzo Bianconi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox