* Re: Patch "Bluetooth: MGMT: Remove unused mgmt_pending_find_data" has been added to the 6.12-stable tree [not found] <20250615130532.1082031-1-sashal@kernel.org> @ 2025-06-15 13:09 ` Dr. David Alan Gilbert 2025-06-15 14:29 ` Sasha Levin 0 siblings, 1 reply; 3+ messages in thread From: Dr. David Alan Gilbert @ 2025-06-15 13:09 UTC (permalink / raw) To: stable Cc: stable-commits, Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz * Sasha Levin (sashal@kernel.org) wrote: > This is a note to let you know that I've just added the patch titled > > Bluetooth: MGMT: Remove unused mgmt_pending_find_data > > to the 6.12-stable tree which can be found at: > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > The filename of the patch is: > bluetooth-mgmt-remove-unused-mgmt_pending_find_data.patch > and it can be found in the queue-6.12 subdirectory. > > If you, or anyone else, feels it should not be added to the stable tree, > please let <stable@vger.kernel.org> know about it. It's a cleanup only, so I wouldn't backport it unless it makes backporting a useful patch easier. Dave > > > commit 17d285fbdeb9dabee6c6c348a528ac81ca65a6da > Author: Dr. David Alan Gilbert <linux@treblig.org> > Date: Mon Jan 27 21:37:15 2025 +0000 > > Bluetooth: MGMT: Remove unused mgmt_pending_find_data > > [ Upstream commit 276af34d82f13bda0b2a4d9786c90b8bbf1cd064 ] > > mgmt_pending_find_data() last use was removed in 2021 by > commit 5a7501374664 ("Bluetooth: hci_sync: Convert MGMT_OP_GET_CLOCK_INFO") > > Remove it. > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> > Reviewed-by: Simon Horman <horms@kernel.org> > Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> > Stable-dep-of: 6fe26f694c82 ("Bluetooth: MGMT: Protect mgmt_pending list with its own lock") > Signed-off-by: Sasha Levin <sashal@kernel.org> > > diff --git a/net/bluetooth/mgmt_util.c b/net/bluetooth/mgmt_util.c > index 67db32a60c6a9..3713ff490c65d 100644 > --- a/net/bluetooth/mgmt_util.c > +++ b/net/bluetooth/mgmt_util.c > @@ -229,23 +229,6 @@ struct mgmt_pending_cmd *mgmt_pending_find(unsigned short channel, u16 opcode, > return NULL; > } > > -struct mgmt_pending_cmd *mgmt_pending_find_data(unsigned short channel, > - u16 opcode, > - struct hci_dev *hdev, > - const void *data) > -{ > - struct mgmt_pending_cmd *cmd; > - > - list_for_each_entry(cmd, &hdev->mgmt_pending, list) { > - if (cmd->user_data != data) > - continue; > - if (cmd->opcode == opcode) > - return cmd; > - } > - > - return NULL; > -} > - > void mgmt_pending_foreach(u16 opcode, struct hci_dev *hdev, > void (*cb)(struct mgmt_pending_cmd *cmd, void *data), > void *data) > diff --git a/net/bluetooth/mgmt_util.h b/net/bluetooth/mgmt_util.h > index bdf978605d5a8..f2ba994ab1d84 100644 > --- a/net/bluetooth/mgmt_util.h > +++ b/net/bluetooth/mgmt_util.h > @@ -54,10 +54,6 @@ int mgmt_cmd_complete(struct sock *sk, u16 index, u16 cmd, u8 status, > > struct mgmt_pending_cmd *mgmt_pending_find(unsigned short channel, u16 opcode, > struct hci_dev *hdev); > -struct mgmt_pending_cmd *mgmt_pending_find_data(unsigned short channel, > - u16 opcode, > - struct hci_dev *hdev, > - const void *data); > void mgmt_pending_foreach(u16 opcode, struct hci_dev *hdev, > void (*cb)(struct mgmt_pending_cmd *cmd, void *data), > void *data); -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/ ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Patch "Bluetooth: MGMT: Remove unused mgmt_pending_find_data" has been added to the 6.12-stable tree 2025-06-15 13:09 ` Patch "Bluetooth: MGMT: Remove unused mgmt_pending_find_data" has been added to the 6.12-stable tree Dr. David Alan Gilbert @ 2025-06-15 14:29 ` Sasha Levin 2025-06-15 14:35 ` Dr. David Alan Gilbert 0 siblings, 1 reply; 3+ messages in thread From: Sasha Levin @ 2025-06-15 14:29 UTC (permalink / raw) To: Dr. David Alan Gilbert Cc: stable, stable-commits, Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz On Sun, Jun 15, 2025 at 01:09:24PM +0000, Dr. David Alan Gilbert wrote: >* Sasha Levin (sashal@kernel.org) wrote: >> This is a note to let you know that I've just added the patch titled >> >> Bluetooth: MGMT: Remove unused mgmt_pending_find_data >> >> to the 6.12-stable tree which can be found at: >> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary >> >> The filename of the patch is: >> bluetooth-mgmt-remove-unused-mgmt_pending_find_data.patch >> and it can be found in the queue-6.12 subdirectory. >> >> If you, or anyone else, feels it should not be added to the stable tree, >> please let <stable@vger.kernel.org> know about it. > >It's a cleanup only, so I wouldn't backport it unless it makes backporting >a useful patch easier. Right, it was taken as a dependency to make a later patch apply cleanly: >> Stable-dep-of: 6fe26f694c82 ("Bluetooth: MGMT: Protect mgmt_pending list with its own lock") -- Thanks, Sasha ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Patch "Bluetooth: MGMT: Remove unused mgmt_pending_find_data" has been added to the 6.12-stable tree 2025-06-15 14:29 ` Sasha Levin @ 2025-06-15 14:35 ` Dr. David Alan Gilbert 0 siblings, 0 replies; 3+ messages in thread From: Dr. David Alan Gilbert @ 2025-06-15 14:35 UTC (permalink / raw) To: Sasha Levin Cc: stable, stable-commits, Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz * Sasha Levin (sashal@kernel.org) wrote: > On Sun, Jun 15, 2025 at 01:09:24PM +0000, Dr. David Alan Gilbert wrote: > > * Sasha Levin (sashal@kernel.org) wrote: > > > This is a note to let you know that I've just added the patch titled > > > > > > Bluetooth: MGMT: Remove unused mgmt_pending_find_data > > > > > > to the 6.12-stable tree which can be found at: > > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > > > > > The filename of the patch is: > > > bluetooth-mgmt-remove-unused-mgmt_pending_find_data.patch > > > and it can be found in the queue-6.12 subdirectory. > > > > > > If you, or anyone else, feels it should not be added to the stable tree, > > > please let <stable@vger.kernel.org> know about it. > > > > It's a cleanup only, so I wouldn't backport it unless it makes backporting > > a useful patch easier. > > Right, it was taken as a dependency to make a later patch apply cleanly: > > > > Stable-dep-of: 6fe26f694c82 ("Bluetooth: MGMT: Protect mgmt_pending list with its own lock") Oh right, that's fine. Dave > > -- > Thanks, > Sasha -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/ ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-06-15 14:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20250615130532.1082031-1-sashal@kernel.org>
2025-06-15 13:09 ` Patch "Bluetooth: MGMT: Remove unused mgmt_pending_find_data" has been added to the 6.12-stable tree Dr. David Alan Gilbert
2025-06-15 14:29 ` Sasha Levin
2025-06-15 14:35 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox