* Re: [PATCH] iommu/amd: Fix ivrs_base memleak in early_amd_iommu_init()
[not found] <20250822024915.673427-1-zhen.ni@easystack.cn>
@ 2025-08-22 20:59 ` Suthikulpanit, Suravee
2025-09-05 12:42 ` Joerg Roedel
1 sibling, 0 replies; 2+ messages in thread
From: Suthikulpanit, Suravee @ 2025-08-22 20:59 UTC (permalink / raw)
To: Zhen Ni, joro, will, robin.murphy; +Cc: iommu, stable
On 8/21/2025 9:49 PM, Zhen Ni wrote:
> Fix a permanent ACPI table memory leak in early_amd_iommu_init() when
> CMPXCHG16B feature is not supported
>
> Fixes: 82582f85ed22 ("iommu/amd: Disable AMD IOMMU if CMPXCHG16B feature is not supported")
> Cc: stable@vger.kernel.org
> Signed-off-by: Zhen Ni <zhen.ni@easystack.cn>
> ---
> drivers/iommu/amd/init.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c
> index 7b5af6176de9..dddc432de7b0 100644
> --- a/drivers/iommu/amd/init.c
> +++ b/drivers/iommu/amd/init.c
> @@ -3067,7 +3067,8 @@ static int __init early_amd_iommu_init(void)
>
> if (!boot_cpu_has(X86_FEATURE_CX16)) {
> pr_err("Failed to initialize. The CMPXCHG16B feature is required.\n");
> - return -EINVAL;
> + ret = -EINVAL;
> + goto out;
> }
>
> /*
Reviewed-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Thanks,
Suravee
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] iommu/amd: Fix ivrs_base memleak in early_amd_iommu_init()
[not found] <20250822024915.673427-1-zhen.ni@easystack.cn>
2025-08-22 20:59 ` [PATCH] iommu/amd: Fix ivrs_base memleak in early_amd_iommu_init() Suthikulpanit, Suravee
@ 2025-09-05 12:42 ` Joerg Roedel
1 sibling, 0 replies; 2+ messages in thread
From: Joerg Roedel @ 2025-09-05 12:42 UTC (permalink / raw)
To: Zhen Ni; +Cc: suravee.suthikulpanit, will, robin.murphy, iommu, stable
On Fri, Aug 22, 2025 at 10:49:15AM +0800, Zhen Ni wrote:
> Fix a permanent ACPI table memory leak in early_amd_iommu_init() when
> CMPXCHG16B feature is not supported
>
> Fixes: 82582f85ed22 ("iommu/amd: Disable AMD IOMMU if CMPXCHG16B feature is not supported")
> Cc: stable@vger.kernel.org
> Signed-off-by: Zhen Ni <zhen.ni@easystack.cn>
> ---
> drivers/iommu/amd/init.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied for -rc, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread